[TabAlert] Completely remove TabAlert code out of tab_utils.h [chromium/src : main]
0 views
Skip to first unread message
David Pennington (Gerrit)
Aug 18, 2025, 11:44:30 AMAug 18
to Steven Luong, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, jophba...@chromium.org
Attention needed from Steven Luong
David Pennington voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Steven Luong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Luong (Gerrit)
Aug 18, 2025, 12:23:33 PMAug 18
to David Pennington, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, jophba...@chromium.org
Steven Luong voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 18, 2025, 1:22:22 PMAug 18
to Steven Luong, David Pennington, chromium...@chromium.org, chrome-gr...@chromium.org, jophba...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[TabAlert] Completely remove TabAlert code out of tab_utils.h
Move GetTabAlertStateText() out of TabUtils and into TabAlertController.
Now that all tab alert code is out of TabUtils, this CL also removes
includes of tab_utils.h that are no longer needed.
Fixed: 422748580
Change-Id: I1490334eaf159bf1e9f5115599c87412f367ad3e
Commit-Queue: Steven Luong <stl...@chromium.org>
Reviewed-by: David Pennington <dpen...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1502794}
Files:
- M chrome/browser/resource_coordinator/tab_manager.cc
- M chrome/browser/ui/tabs/alert/tab_alert_controller.cc
- M chrome/browser/ui/tabs/alert/tab_alert_controller.h
- M chrome/browser/ui/tabs/tab_renderer_data.cc
- M chrome/browser/ui/tabs/tab_strip_api/converters/tab_converters.cc
- M chrome/browser/ui/tabs/tab_utils.cc
- M chrome/browser/ui/tabs/tab_utils.h
- M chrome/browser/ui/views/frame/multi_contents_view_mini_toolbar.cc
- M chrome/browser/ui/views/tabs/alert_indicator_button.h
- M chrome/browser/ui/views/tabs/fade_footer_view.cc
- M chrome/browser/ui/views/tabs/tab.cc
- M chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.h
- M chrome/browser/ui/views/tabs/tab_strip.h
- M chrome/browser/ui/views/tabs/tab_unittest.cc
- M chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc
- M chrome/browser/ui/webui/tab_search/tab_search_page_handler_unittest.cc
Change size: M
Delta: 16 files changed, 78 insertions(+), 91 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Pennington
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages