[Code Health] Remove stale base::Feature kCustomizedTabLoadTimeout [chromium/src : main]
7 views
Skip to first unread message
Francois Pierre Doray (Gerrit)
Dec 16, 2025, 4:51:23 PM (12 days ago) Dec 16
to Atharv Maan, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Atharv Maan
Francois Pierre Doray added 2 comments![]( "Open in Gerrit")
File chrome/browser/sessions/tab_loader_delegate.cc
Line 46, Patchset 3 (Latest):
return base::Milliseconds(first_timeout_.InMilliseconds());Francois Pierre Doray . unresolved
Return `first_timeout_` directly.
Reason: It's a base::TimeDelta, no conversion required.
Line 51, Patchset 3 (Latest):
return base::Milliseconds(timeout_.InMilliseconds());Francois Pierre Doray . unresolved
Return `timeout_` directly.
Reason: It's a base::TimeDelta, no conversion required.
Related details
Attention is currently required from:
- Atharv Maan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atharv Maan (Gerrit)
Dec 17, 2025, 3:47:20 PM (11 days ago) Dec 17
to AyeAye, Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org
Attention needed from Francois Pierre Doray
Atharv Maan added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Atharv Maan . resolved
@fdo...@chromium.org there were a few files which had the header included - removed the includes.
File chrome/browser/sessions/tab_loader_delegate.cc
Line 46, Patchset 3:
return base::Milliseconds(first_timeout_.InMilliseconds());Francois Pierre Doray . resolved
Return `first_timeout_` directly.
Reason: It's a base::TimeDelta, no conversion required.
Atharv Maan
Done
Line 51, Patchset 3:
return base::Milliseconds(timeout_.InMilliseconds());Francois Pierre Doray . resolved
Return `timeout_` directly.
Reason: It's a base::TimeDelta, no conversion required.
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atharv Maan (Gerrit)
Dec 17, 2025, 3:48:56 PM (11 days ago) Dec 17
to AyeAye, Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org
Attention needed from Francois Pierre Doray
Atharv Maan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Atharv Maan . resolved
@fdo...@chromium.org there were a few files which had the header included - removed the includes.
Atharv Maan
Also the `base/system/sys_info.h` header was being transitively included in 2 files, which broke compilation after removing the `tab_, also added the include in those files.
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Dec 18, 2025, 9:53:29 AM (10 days ago) Dec 18
to Atharv Maan, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org
Attention needed from Atharv Maan
Francois Pierre Doray voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Atharv Maan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atharv Maan (Gerrit)
Dec 18, 2025, 1:53:26 PM (10 days ago) Dec 18
to Darryl James, Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org
Attention needed from Darryl James
Atharv Maan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Dec 18, 2025, 3:39:03 PM (10 days ago) Dec 18
to Atharv Maan, Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org
Attention needed from Atharv Maan
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Atharv Maan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atharv Maan (Gerrit)
Dec 18, 2025, 3:50:31 PM (10 days ago) Dec 18
to Darryl James, Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org
Atharv Maan voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 18, 2025, 4:47:15 PM (10 days ago) Dec 18
to Atharv Maan, Darryl James, Francois Pierre Doray, AyeAye, chromium...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Code Health] Remove stale base::Feature kCustomizedTabLoadTimeout
This CL removes the stale base::Feature kCustomizedTabLoadTimeout and
removes all code paths that relied on it.
Bug: 356235580
Change-Id: I70a6b722c0f4aac7d6d87ca4b516b87aa8eadae5
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Atharv Maan <athar...@chromium.org>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1560806}
Files:
- M chrome/browser/BUILD.gn
- M chrome/browser/about_flags.cc
- M chrome/browser/component_updater/registration.cc
- M chrome/browser/resource_coordinator/BUILD.gn
- M chrome/browser/resource_coordinator/session_restore_policy.cc
- M chrome/browser/resource_coordinator/session_restore_policy.h
- M chrome/browser/resource_coordinator/session_restore_policy_unittest.cc
- M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
- M chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
- M chrome/browser/resource_coordinator/tab_manager.cc
- M chrome/browser/resource_coordinator/tab_manager.h
- M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
- D chrome/browser/resource_coordinator/tab_manager_features.cc
- D chrome/browser/resource_coordinator/tab_manager_features.h
- M chrome/browser/resource_coordinator/tab_manager_unittest.cc
- M chrome/browser/sessions/session_restore_browsertest.cc
- M chrome/browser/sessions/tab_loader_delegate.cc
- M chrome/browser/sessions/tab_loader_unittest.cc
- M chrome/test/BUILD.gn
Change size: M
Delta: 19 files changed, 4 insertions(+), 92 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Francois Pierre Doray, +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages