Finish modularizing c/b/resource_coordinator [chromium/src : main]
0 views
Skip to first unread message
Orko Garai (Gerrit)
Apr 16, 2026, 12:44:18 PM (9 days ago) Apr 16
to chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, performance-m...@chromium.org
Attention needed from chromium-bedrock-reviews
Orko Garai voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- chromium-bedrock-reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Apr 16, 2026, 12:47:18 PM (9 days ago) Apr 16
to Orko Garai, chromium-bedrock-reviews, Sophie Chang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, performance-m...@chromium.org
Attention needed from Sophie Chang
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
sophi...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)
Related details
Attention is currently required from:
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
Apr 16, 2026, 8:00:26 PM (8 days ago) Apr 16
to Orko Garai, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, performance-m...@chromium.org
Sophie Chang added 1 comment![]( "Open in Gerrit")
File chrome/browser/resource_coordinator/BUILD.gn
Line 16, Patchset 4 (Latest):
"lifecycle_unit_observer.h",Sophie Chang . unresolved
this was behind !is_android before - should it still be?
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Apr 17, 2026, 12:20:34 PM (8 days ago) Apr 17
to chromium-bedrock-reviews, Sophie Chang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, performance-m...@chromium.org
Attention needed from Sophie Chang
Orko Garai added 1 comment![]( "Open in Gerrit")
File chrome/browser/resource_coordinator/BUILD.gn
this was behind !is_android before - should it still be?
Attention is currently required from:
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
Apr 17, 2026, 1:38:57 PM (8 days ago) Apr 17
to Orko Garai, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, performance-m...@chromium.org
Attention needed from Orko Garai
Sophie Chang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Apr 17, 2026, 3:00:12 PM (8 days ago) Apr 17
to Sophie Chang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, performance-m...@chromium.org
Orko Garai voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 17, 2026, 3:13:05 PM (8 days ago) Apr 17
to Orko Garai, Sophie Chang, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, performance-m...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Finish modularizing c/b/resource_coordinator
Move the remaining resource_coordinator sources from c/b to
c/b/resource_coordinator target.
Cq-Include-Trybots: luci.chromium.try:android-cast-arm-rel
Bug: 353332589
Change-Id: Ie5e7c8783eb7fcd5c262afc500955a6ea8f5a898
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Commit-Queue: Orko Garai <or...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1616752}
Files:
- M chrome/browser/BUILD.gn
- M chrome/browser/extensions/BUILD.gn
- M chrome/browser/memory/BUILD.gn
- M chrome/browser/performance_manager/BUILD.gn
- M chrome/browser/resource_coordinator/BUILD.gn
- M chrome/browser/ui/performance_controls/test_support/BUILD.gn
- M chrome/browser/ui/tabs/BUILD.gn
- M chrome/browser/ui/tabs/saved_tab_groups/BUILD.gn
- M chrome/test/BUILD.gn
Change size: L
Delta: 9 files changed, 240 insertions(+), 49 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sophie Chang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages