[bedrock] Drop unused includes of chrome/browser/ui/browser_finder.h [chromium/src : main]

1 view
Skip to first unread message

SLSA Policy Verification Service (Gerrit)

unread,
May 7, 2026, 4:25:35 AM (10 days ago) May 7
to Yu He, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Yu He

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5650e304d617f1cecc93c546e74f261c6161608
Gerrit-Change-Number: 7826189
Gerrit-PatchSet: 2
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Yu He <y...@microsoft.com>
Gerrit-Comment-Date: Thu, 07 May 2026 08:25:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yu He (Gerrit)

unread,
May 7, 2026, 5:28:07 AM (10 days ago) May 7
to Thomas Lukaszewicz, Qikai Zhong, Kun Wang, Kevin DiClemente, SLSA Policy Verification Service, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong and Thomas Lukaszewicz

Yu He voted and added 1 comment

Votes added by Yu He

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yu He . resolved

This Cl is ready, please help to review, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5650e304d617f1cecc93c546e74f261c6161608
Gerrit-Change-Number: 7826189
Gerrit-PatchSet: 2
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Kun Wang <kun...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 09:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

SLSA Policy Verification Service (Gerrit)

unread,
May 7, 2026, 5:31:32 AM (10 days ago) May 7
to Yu He, Thomas Lukaszewicz, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong, Thomas Lukaszewicz and Yu He

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified+1
Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Thomas Lukaszewicz
  • Yu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5650e304d617f1cecc93c546e74f261c6161608
Gerrit-Change-Number: 7826189
Gerrit-PatchSet: 3
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Kun Wang <kun...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Yu He <y...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 09:31:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
May 7, 2026, 1:59:13 PM (10 days ago) May 7
to Yu He, Hidehiko Abe, SLSA Policy Verification Service, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Hidehiko Abe, Qikai Zhong and Yu He

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Thomas Lukaszewicz . resolved

nice! hidehiko ptal for chromeos deps

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Qikai Zhong
  • Yu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5650e304d617f1cecc93c546e74f261c6161608
Gerrit-Change-Number: 7826189
Gerrit-PatchSet: 3
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Kun Wang <kun...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Yu He <y...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 17:58:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
May 7, 2026, 8:57:55 PM (9 days ago) May 7
to Yu He, Thomas Lukaszewicz, SLSA Policy Verification Service, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong and Yu He

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review+1

1 comment

Patchset-level comments
Hidehiko Abe . resolved

LGTM for c/b/**/ash/**/DEPS files.

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Yu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Gerrit-Comment-Date: Fri, 08 May 2026 00:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

SLSA Policy Verification Service (Gerrit)

unread,
May 7, 2026, 9:56:47 PM (9 days ago) May 7
to Yu He, Hidehiko Abe, Thomas Lukaszewicz, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong and Yu He

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified+1
Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Yu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5650e304d617f1cecc93c546e74f261c6161608
Gerrit-Change-Number: 7826189
Gerrit-PatchSet: 4
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Kun Wang <kun...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Yu He <y...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Fri, 08 May 2026 01:56:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yu He (Gerrit)

unread,
May 7, 2026, 10:00:03 PM (9 days ago) May 7
to SLSA Policy Verification Service, Hidehiko Abe, Thomas Lukaszewicz, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong

Yu He voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Fri, 08 May 2026 01:59:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yu He (Gerrit)

unread,
May 7, 2026, 10:01:21 PM (9 days ago) May 7
to SLSA Policy Verification Service, Hidehiko Abe, Thomas Lukaszewicz, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Gerrit-Comment-Date: Fri, 08 May 2026 02:00:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 7, 2026, 10:10:18 PM (9 days ago) May 7
to Yu He, SLSA Policy Verification Service, Hidehiko Abe, Thomas Lukaszewicz, Qikai Zhong, Kun Wang, Kevin DiClemente, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Simon Hangl, aixba+wat...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, ashleydp+fe...@google.com, ayman...@chromium.org, cbe-cep-eng...@google.com, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, csharrison+...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, iclella...@chromium.org, japhet+...@chromium.org, jatapiaro+wat...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, longbowei+fe...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mdjone...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nator...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-revi...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tgupta...@chromium.org, titoua...@chromium.org, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+fe...@google.com, webap...@microsoft.com, xiangdongkong+...@google.com, xiaohui...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[bedrock] Drop unused includes of chrome/browser/ui/browser_finder.h

A large portion of files that include chrome/browser/ui/browser_finder.h
no longer reference any of its declarations after the ongoing migration
to GlobalBrowserCollection / ProfileBrowserCollection /
BrowserWindowInterface APIs. This change drops those now-unused

Scope:
* 193 source files: removed
#include "chrome/browser/ui/browser_finder.h"
after verifying that none of the symbols declared in the header
(FindTabbedBrowser, FindBrowserWithProfile, FindBrowserWithTab,
FindLastActive[WithProfile], GetTotalBrowserCount, GetBrowserCount,
GetIncognitoBrowserCount, CloseAllBrowsersWith[Incognito]Profile,
GetOffTheRecordBrowsersActiveForProfile, IsOffTheRecordBrowserInUse,
GetGuestBrowserCount, ProfileBrowsersCloseCallback) are still in use.
* 35 DEPS files: removed the now-unused
"+chrome/browser/ui/browser_finder.h"
entry from include_rules / specific_include_rules. Entries that still
apply to files which legitimately depend on browser_finder.h are kept
untouched.

The header itself and the 63 remaining callers are unchanged. No
BUILD.gn changes are needed -- the source list for the
browser_finder.cc/.h target is unaffected.

No behavior change.
Bug: 494010890
Change-Id: Ic5650e304d617f1cecc93c546e74f261c6161608
Commit-Queue: Yu He <y...@microsoft.com>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1627428}
Files:
  • M chrome/browser/ai/ai_data_keyed_service.cc
  • M chrome/browser/app_controller_mac_browsertest.mm
  • M chrome/browser/app_controller_mac_interactive_uitest.mm
  • M chrome/browser/apps/app_service/metrics/app_platform_input_metrics.cc
  • M chrome/browser/apps/app_service/metrics/website_metrics_browsertest.cc
  • M chrome/browser/apps/platform_apps/platform_app_navigation_redirector.cc
  • M chrome/browser/ash/app_list/DEPS
  • M chrome/browser/ash/app_list/app_list_client_impl_browsertest.cc
  • M chrome/browser/ash/app_list/search/DEPS
  • M chrome/browser/ash/app_list/search/test/app_list_search_test_helper.h
  • M chrome/browser/ash/app_mode/DEPS
  • M chrome/browser/ash/app_mode/kiosk_troubleshooting_tools_browsertest.cc
  • M chrome/browser/ash/app_mode/test/DEPS
  • M chrome/browser/ash/app_mode/test/kiosk_browsertest.cc
  • M chrome/browser/ash/app_mode/test/kiosk_test_utils.cc
  • M chrome/browser/ash/app_mode/test/new_windows_in_kiosk_allowed_browsertest.cc
  • M chrome/browser/ash/app_restore/DEPS
  • M chrome/browser/ash/app_restore/full_restore_app_launch_handler_browsertest.cc
  • M chrome/browser/ash/app_restore/informed_restore_browsertest.cc
  • M chrome/browser/ash/boca/on_task/DEPS
  • M chrome/browser/ash/boca/on_task/on_task_locked_session_navigation_throttle_interactive_ui_test.cc
  • M chrome/browser/ash/boca/on_task/on_task_locked_session_window_tracker_browsertest.cc
  • M chrome/browser/ash/browser_delegate/browser_controller_impl.cc
  • M chrome/browser/ash/child_accounts/DEPS
  • M chrome/browser/ash/child_accounts/family_user_chrome_activity_metrics_unittest.cc
  • M chrome/browser/ash/eol/DEPS
  • M chrome/browser/ash/file_manager/DEPS
  • M chrome/browser/ash/input_method/DEPS
  • M chrome/browser/ash/input_method/native_input_method_engine_without_ime_service_browsertest.cc
  • M chrome/browser/ash/input_method/text_field_contextual_info_fetcher.h
  • M chrome/browser/ash/login/DEPS
  • M chrome/browser/ash/login/app_mode/test/kiosk_accelerator_browsertest.cc
  • M chrome/browser/ash/login/demo_mode/demo_mode_idle_handler_unittest.cc
  • M chrome/browser/ash/os_feedback/DEPS
  • M chrome/browser/ash/os_feedback/chrome_os_feedback_delegate_browsertest.cc
  • M chrome/browser/ash/policy/core/DEPS
  • M chrome/browser/ash/policy/core/device_local_account_browsertest.cc
  • M chrome/browser/ash/policy/core/user_cloud_policy_manager_ash_browsertest.cc
  • M chrome/browser/ash/policy/handlers/DEPS
  • M chrome/browser/ash/policy/handlers/restore_on_startup_browsertest.cc
  • M chrome/browser/ash/policy/login/DEPS
  • M chrome/browser/ash/policy/login/force_maximize_on_first_run_browsertest.cc
  • M chrome/browser/ash/policy/networking/DEPS
  • M chrome/browser/ash/system_web_apps/apps/camera_app/camera_app_integration_browsertest.cc
  • M chrome/browser/ash/system_web_apps/apps/media_app/media_app_integration_browsertest.cc
  • M chrome/browser/ash/system_web_apps/apps/media_app/media_app_ocr_integration_browsertest.cc
  • M chrome/browser/ash/system_web_apps/apps/os_feedback_app_integration_browsertest.cc
  • M chrome/browser/ash/system_web_apps/system_web_app_manager_browsertest.cc
  • M chrome/browser/ash/system_web_apps/test_support/DEPS
  • M chrome/browser/attribution_reporting/DEPS
  • M chrome/browser/background_sync/background_sync_browsertest.cc
  • M chrome/browser/browser_process_impl.cc
  • M chrome/browser/browser_process_platform_part_ash.cc
  • M chrome/browser/browser_process_platform_part_ash_browsertest.cc
  • M chrome/browser/browsing_data/DEPS
  • M chrome/browser/chrome_content_browser_client_navigation_throttles.cc
  • M chrome/browser/chrome_main_process_singleton_browsertest.cc
  • M chrome/browser/chromeos/app_mode/DEPS
  • M chrome/browser/chromeos/extensions/odfs_config_private/DEPS
  • M chrome/browser/chromeos/extensions/odfs_config_private/odfs_config_private_api_browsertest.cc
  • M chrome/browser/chromeos/network/DEPS
  • M chrome/browser/commerce/shopping_service_factory.cc
  • M chrome/browser/contextual_tasks/search_ai_mode_promo_tab_helper.cc
  • M chrome/browser/device_reauth/DEPS
  • M chrome/browser/devtools/chrome_devtools_manager_delegate.cc
  • M chrome/browser/devtools/devtools_connection_dialog.cc
  • M chrome/browser/devtools/devtools_remote_server_infobar_delegate.cc
  • M chrome/browser/devtools/protocol/target_handler.cc
  • M chrome/browser/download/download_commands.cc
  • M chrome/browser/enterprise/data_protection/data_protection_navigation_controller.cc
  • M chrome/browser/enterprise/data_protection/data_protection_ui_controller.cc
  • M chrome/browser/enterprise/idle/idle_service.cc
  • M chrome/browser/enterprise/signin/oidc_authentication_signin_interceptor.cc
  • M chrome/browser/enterprise/signin/oidc_authentication_signin_interceptor_browsertest.cc
  • M chrome/browser/enterprise/signin/profile_token_web_signin_interceptor.cc
  • M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
  • M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc
  • M chrome/browser/extensions/browsertest_util.cc
  • M chrome/browser/extensions/extension_action_runner.cc
  • M chrome/browser/extensions/extension_browsertest.cc
  • M chrome/browser/extensions/extension_install_ui_browsertest.cc
  • M chrome/browser/extensions/extension_tab_util.cc
  • M chrome/browser/extensions/file_handlers/web_file_handlers_permission_handler.cc
  • M chrome/browser/extensions/open_tab_helper.cc
  • M chrome/browser/external_protocol/DEPS
  • M chrome/browser/feedback/show_feedback_page_browsertest.cc
  • M chrome/browser/file_system_access/chrome_file_system_access_permission_context.cc
  • M chrome/browser/glic/fre/glic_fre_controller.cc
  • M chrome/browser/glic/glic_selection_observer.cc
  • M chrome/browser/glic/host/context/glic_focused_browser_manager_impl.cc
  • M chrome/browser/glic/host/context/glic_focused_tab_manager.cc
  • M chrome/browser/glic/host/context/glic_screenshot_capturer.cc
  • M chrome/browser/glic/public/glic_keyed_service.cc
  • M chrome/browser/glic/service/glic_instance_coordinator_impl.cc
  • M chrome/browser/glic/service/glic_invoke_handler.cc
  • M chrome/browser/glic/widget/glic_view.cc
  • M chrome/browser/hid/chrome_hid_delegate.cc
  • M chrome/browser/lifetime/application_lifetime_desktop.cc
  • M chrome/browser/lifetime/smart_restart_manager_browsertest.cc
  • M chrome/browser/net/errorpage_browsertest.cc
  • M chrome/browser/net/profile_network_context_service_test_utils.cc
  • M chrome/browser/password_manager/web_app_profile_switcher.cc
  • M chrome/browser/password_manager/web_app_profile_switcher_interactive_uitest.cc
  • M chrome/browser/policy/cloud/chrome_browser_cloud_management_browsertest.cc
  • M chrome/browser/policy/profile_policy_connector.cc
  • M chrome/browser/policy/test/restore_on_startup_policy_browsertest.cc
  • M chrome/browser/preloading/prerender/prerender_manager.cc
  • M chrome/browser/profiles/avatar_menu.cc
  • M chrome/browser/profiles/profile_manager_browsertest.cc
  • M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
  • M chrome/browser/safe_browsing/safe_browsing_pref_change_handler.cc
  • M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
  • M chrome/browser/safe_browsing/tailored_security/notification_handler_desktop.cc
  • M chrome/browser/sessions/session_restore_browsertest_chromeos.cc
  • M chrome/browser/sessions/session_service_base.h
  • M chrome/browser/signin/signin_util.cc
  • M chrome/browser/ssl/security_state_tab_helper_browsertest.cc
  • M chrome/browser/ssl/ssl_browsertest.cc
  • M chrome/browser/subresource_filter/subresource_filter_browsertest.cc
  • M chrome/browser/sync/sessions/sync_sessions_router_tab_helper_browsertest.cc
  • M chrome/browser/sync/test/integration/sync_test.cc
  • M chrome/browser/ui/android/hats/hats_service_android.cc
  • M chrome/browser/ui/ash/arc/DEPS
  • M chrome/browser/ui/ash/arc/arc_open_url_delegate_impl_browsertest.cc
  • M chrome/browser/ui/ash/boca/DEPS
  • M chrome/browser/ui/ash/boca/chrome_tab_strip_delegate_browsertest.cc
  • M chrome/browser/ui/ash/desks/DEPS
  • M chrome/browser/ui/ash/desks/desks_client_browsertest.cc
  • M chrome/browser/ui/ash/gemini_app/DEPS
  • M chrome/browser/ui/ash/login/DEPS
  • M chrome/browser/ui/ash/multi_user/DEPS
  • M chrome/browser/ui/ash/new_window/DEPS
  • M chrome/browser/ui/ash/new_window/chrome_new_window_client_browsertest.cc
  • M chrome/browser/ui/ash/projector/DEPS
  • M chrome/browser/ui/ash/projector/projector_client_impl_browsertest.cc
  • M chrome/browser/ui/ash/projector/projector_navigation_throttle_browsertest.cc
  • M chrome/browser/ui/ash/shelf/DEPS
  • M chrome/browser/ui/ash/shelf/app_shortcut_shelf_item_controller_browsertest.cc
  • M chrome/browser/ui/ash/shelf/browser_shortcut_shelf_item_controller_browsertest.cc
  • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_browsertest.cc
  • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_unittest.cc
  • M chrome/browser/ui/ash/test/DEPS
  • M chrome/browser/ui/ash/test/accelerator_commands_browsertest.cc
  • M chrome/browser/ui/ash/wm/DEPS
  • M chrome/browser/ui/ash/wm/coral_browsertest.cc
  • M chrome/browser/ui/ash/wm/snap_group_browsertest.cc
  • M chrome/browser/ui/autofill/address_bubbles_controller.cc
  • M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
  • M chrome/browser/ui/browser_finder_unittest.cc
  • M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm
  • M chrome/browser/ui/cocoa/browser_window_command_handler.mm
  • M chrome/browser/ui/cocoa/keystone_infobar_delegate.cc
  • M chrome/browser/ui/extensions/extension_install_ui_android.cc
  • M chrome/browser/ui/extensions/hosted_app_browsertest.cc
  • M chrome/browser/ui/navigator/browser_navigator_browsertest_chromeos.cc
  • M chrome/browser/ui/passwords/password_change_ui_controller.cc
  • M chrome/browser/ui/read_anything/read_anything_side_panel_controller.cc
  • M chrome/browser/ui/read_anything/read_anything_side_panel_navigation_throttle.cc
  • M chrome/browser/ui/send_tab_to_self/send_tab_to_self_context_menu_delegate.cc
  • M chrome/browser/ui/settings_window_manager_browsertest_chromeos.cc
  • M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
  • M chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc
  • M chrome/browser/ui/uma_browsing_activity_observer.cc
  • M chrome/browser/ui/views/autofill/at_memory_promo_bubble_view.cc
  • M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
  • M chrome/browser/ui/views/frame/browser_native_widget_ash.cc
  • M chrome/browser/ui/views/location_bar/cookie_controls/cookie_controls_icon_view.cc
  • M chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc
  • M chrome/browser/ui/views/location_bar/location_bar_view.cc
  • M chrome/browser/ui/views/location_bar/record_replay_page_action_controller.cc
  • M chrome/browser/ui/views/occlusion_visibility_interactive_uitest.cc
  • M chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
  • M chrome/browser/ui/views/passwords/password_change/successful_password_change_view_unittest.cc
  • M chrome/browser/ui/views/passwords/password_save_update_view.cc
  • M chrome/browser/ui/views/profiles/profile_management_flow_controller.cc
  • M chrome/browser/ui/views/profiles/profile_menu_view.cc
  • M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
  • M chrome/browser/ui/views/sad_tab_split_view_browsertest.cc
  • M chrome/browser/ui/views/sad_tab_view.cc
  • M chrome/browser/ui/views/safe_browsing/tailored_security_desktop_dialog_manager.cc
  • M chrome/browser/ui/views/search_engines/dse_reset_dialog.cc
  • M chrome/browser/ui/views/select_audio_output/select_audio_output_views.cc
  • M chrome/browser/ui/views/send_tab_to_self/send_tab_to_self_device_picker_bubble_view.cc
  • M chrome/browser/ui/views/sharing/sharing_dialog_view.cc
  • M chrome/browser/ui/views/side_panel/extensions/extension_side_panel_coordinator.cc
  • M chrome/browser/ui/views/side_panel/extensions/extension_side_panel_manager.cc
  • M chrome/browser/ui/views/side_panel/history_clusters/history_clusters_side_panel_controller_utils.cc
  • M chrome/browser/ui/views/simple_web_view_dialog_browsertest.cc
  • M chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc
  • M chrome/browser/ui/views/tab_sharing/tab_sharing_ui_views_browsertest.cc
  • M chrome/browser/ui/views/toolbar/webui_home_control.cc
  • M chrome/browser/ui/views/toolbar/webui_split_tabs_control.cc
  • M chrome/browser/ui/views/user_education/browser_user_education_service.cc
  • M chrome/browser/ui/views/user_education/custom_webui_help_bubble.h
  • M chrome/browser/ui/views/web_apps/frame_toolbar/web_app_frame_toolbar_browsertest.cc
  • M chrome/browser/ui/views/web_apps/web_app_blocked_migration_infobar_delegate_browsertest.cc
  • M chrome/browser/ui/views/web_apps/web_app_install_dialog_delegate.cc
  • M chrome/browser/ui/views/webid/account_selection_bubble_view.cc
  • M chrome/browser/ui/web_applications/app_browser_controller_browsertest_chromeos.cc
  • M chrome/browser/ui/web_applications/test/web_app_navigation_browsertest.cc
  • M chrome/browser/ui/web_applications/web_app_browsertest.cc
  • M chrome/browser/ui/webui/ai_overlay_dialog/tools/tools.cc
  • M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler.cc
  • M chrome/browser/ui/webui/history/history_login_handler.cc
  • M chrome/browser/ui/webui/new_tab_page/new_tab_page_handler.cc
  • M chrome/browser/ui/webui/new_tab_page/new_tab_page_ui.cc
  • M chrome/browser/ui/webui/omnibox_popup/omnibox_popup_ui.cc
  • M chrome/browser/ui/webui/print_preview/print_preview_handler.cc
  • M chrome/browser/ui/webui/searchbox/realbox_handler.cc
  • M chrome/browser/ui/webui/searchbox/webui_omnibox_handler.cc
  • M chrome/browser/ui/webui/settings/font_handler.cc
  • M chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
  • M chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
  • M chrome/browser/ui/webui/signin/profile_picker_handler.cc
  • M chrome/browser/ui/webui/webui_toolbar/webui_toolbar_ui.cc
  • M chrome/browser/ui/webui/whats_new/whats_new_handler.cc
  • M chrome/browser/ui/window_sizer/window_sizer_chromeos_uitest.cc
  • M chrome/browser/updates/update_metrics_provider.cc
  • M chrome/browser/usb/chrome_usb_delegate.cc
  • M chrome/browser/web_applications/commands/fetch_manifest_and_install_command_browsertest.cc
  • M chrome/browser/web_applications/commands/launch_or_reparent_web_contents_into_app_command_browsertest.cc
  • M chrome/browser/web_applications/isolated_web_apps/window_management/isolated_web_apps_window_open_permission_service_browsertest.cc
  • M chrome/browser/web_applications/web_app_icon_manager_browsertest.cc
  • M chrome/browser/web_applications/web_install_browsertest.cc
  • M chrome/test/fuzzing/kombucha_in_process_fuzzer.cc
  • M chrome/test/media_router/media_router_e2e_browsertest.cc
  • M chrome/test/media_router/media_router_integration_browsertest.cc
Change size: M
Delta: 228 files changed, 2 insertions(+), 229 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Hidehiko Abe, +1 by Thomas Lukaszewicz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5650e304d617f1cecc93c546e74f261c6161608
Gerrit-Change-Number: 7826189
Gerrit-PatchSet: 5
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages