Remove unused code from base::trace_event::TraceEvent [chromium/src : main]
0 views
Skip to first unread message
Eric Seckler (Gerrit)
Nov 17, 2025, 4:54:06 AM (13 days ago) Nov 17
to Lei Zhang, Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Lei Zhang
Eric Seckler voted and added 2 comments![]( "Open in Gerrit")
Votes added by Eric Seckler
| Code-Review | +1 |
2 comments
Patchset-level comments
File base/trace_event/trace_event_impl.h
Line 101, Patchset 2 (Parent):
ThreadTicks thread_timestamp() const { return thread_timestamp_; }Eric Seckler . resolved
Interesting, I hadn't realized we don't store the thread timestamps into the perfetto events. Might be an oversight. But then again, nobody is complaining about the lack of these timestamps and it might be a way to entice more embedders to adopt Perfetto directly.. 😊
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Nov 17, 2025, 12:12:35 PM (13 days ago) Nov 17
to Lei Zhang, Eric Seckler, Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Lei Zhang added 1 comment![]( "Open in Gerrit")
File base/trace_event/trace_event_impl.h
Line 101, Patchset 2 (Parent):
ThreadTicks thread_timestamp() const { return thread_timestamp_; }Eric Seckler . resolved
Interesting, I hadn't realized we don't store the thread timestamps into the perfetto events. Might be an oversight. But then again, nobody is complaining about the lack of these timestamps and it might be a way to entice more embedders to adopt Perfetto directly.. 😊
Lei Zhang
https://crrev.com/1394571 deleted the last caller.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Seckler (Gerrit)
Nov 17, 2025, 12:17:41 PM (13 days ago) Nov 17
to Lei Zhang, Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Lei Zhang
Eric Seckler added 1 comment![]( "Open in Gerrit")
File base/trace_event/trace_event_impl.h
Line 101, Patchset 2 (Parent):
ThreadTicks thread_timestamp() const { return thread_timestamp_; }Eric Seckler . resolved
Lei ZhangInteresting, I hadn't realized we don't store the thread timestamps into the perfetto events. Might be an oversight. But then again, nobody is complaining about the lack of these timestamps and it might be a way to entice more embedders to adopt Perfetto directly.. 😊
https://crrev.com/1394571 deleted the last caller.
Eric Seckler
Makes sense -- Specifically, I was expecting this to be called from https://source.chromium.org/chromium/chromium/src/+/main:base/trace_event/trace_log.cc;drc=0980e70815a5a899d1b799c404efee74c4495a63;l=140 -- but it's not and hasn't been. (In any case, this should only affect embedders like angle)
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Nov 17, 2025, 12:22:47 PM (13 days ago) Nov 17
to Lei Zhang, Daniel Cheng, Eric Seckler, Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Nov 17, 2025, 12:28:29 PM (13 days ago) Nov 17
to Lei Zhang, Daniel Cheng, Eric Seckler, Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Lei Zhang
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Nov 17, 2025, 4:16:51 PM (13 days ago) Nov 17
to Lei Zhang, Daniel Cheng, Eric Seckler, Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Lei Zhang
Daniel Cheng voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Lei Zhang (Gerrit)
Nov 17, 2025, 6:22:47 PM (13 days ago) Nov 17
to Lei Zhang, Daniel Cheng, Eric Seckler, Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 17, 2025, 7:16:23 PM (12 days ago) Nov 17
to Lei Zhang, Daniel Cheng, Eric Seckler, Etienne Pierre-Doray, Mikhail Khokhlov, chromium...@chromium.org, agriev...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove unused code from base::trace_event::TraceEvent
Transitively remove a bunch of unused tracing code.
Change-Id: I6a819a1e9658d9b2d36e583fc2443f29eef903b8
Auto-Submit: Lei Zhang <the...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Eric Seckler <esec...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1546211}
Files:
- M base/android/early_trace_event_binding.cc
- M base/android/java/src/org/chromium/base/EarlyTraceEvent.java
- M base/trace_event/trace_arguments.cc
- M base/trace_event/trace_arguments.h
- M base/trace_event/trace_arguments_unittest.cc
- M base/trace_event/trace_event.h
- M base/trace_event/trace_event_impl.cc
- M base/trace_event/trace_event_impl.h
- M base/trace_event/trace_log.cc
- M content/browser/tracing/tracing_end_to_end_browsertest.cc
- M gpu/command_buffer/service/dawn_platform.cc
- M services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
- M skia/ext/event_tracer_impl.cc
- M ui/gl/angle_platform_impl.cc
Change size: L
Delta: 14 files changed, 57 insertions(+), 418 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng, +1 by Eric Seckler
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages