Implement GlobalBrowserCollection. [chromium/src : main]
0 views
Skip to first unread message
Glenn Hartmann (Gerrit)
Nov 10, 2025, 2:24:30 PMNov 10
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dewitt...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mgiuca...@chromium.org, rginda...@chromium.org, trewin...@google.com, webap...@microsoft.com
Attention needed from Tom Lukaszewicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Nov 10, 2025, 10:18:02 PMNov 10
to Glenn Hartmann, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dewitt...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mgiuca...@chromium.org, rginda...@chromium.org, trewin...@google.com, webap...@microsoft.com
Attention needed from Glenn Hartmann
Tom Lukaszewicz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Code-Review | +1 |
2 comments
Patchset-level comments
File chrome/browser/ui/browser_window/public/global_browser_collection.h
Line 28, Patchset 18 (Latest):
GlobalBrowserCollection(const GlobalBrowserCollection&) = delete;
GlobalBrowserCollection& operator=(const GlobalBrowserCollection&) = delete;Tom Lukaszewicz . unresolved
nit: Could we sandwich this between the constructor and destructor (aligns with style guide)
Related details
Attention is currently required from:
- Glenn Hartmann
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Nov 11, 2025, 9:40:59 AMNov 11
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dewitt...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mgiuca...@chromium.org, rginda...@chromium.org, trewin...@google.com, webap...@microsoft.com
Glenn Hartmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Glenn Hartmann
| Commit-Queue | +2 |
1 comment
File chrome/browser/ui/browser_window/public/global_browser_collection.h
Line 28, Patchset 18:
GlobalBrowserCollection(const GlobalBrowserCollection&) = delete;
GlobalBrowserCollection& operator=(const GlobalBrowserCollection&) = delete;Tom Lukaszewicz . resolved
nit: Could we sandwich this between the constructor and destructor (aligns with style guide)
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 11, 2025, 10:31:51 AMNov 11
to Glenn Hartmann, Tom Lukaszewicz, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dewitt...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mgiuca...@chromium.org, rginda...@chromium.org, trewin...@google.com, webap...@microsoft.com
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
18 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/ui/browser_window/public/global_browser_collection.h
Insertions: 1, Deletions: 2.
@@ -23,10 +23,9 @@
static GlobalBrowserCollection* GetInstance();
GlobalBrowserCollection();
- ~GlobalBrowserCollection() override;
-
GlobalBrowserCollection(const GlobalBrowserCollection&) = delete;
GlobalBrowserCollection& operator=(const GlobalBrowserCollection&) = delete;
+ ~GlobalBrowserCollection() override;
// BrowserCollectionObserver:
void OnBrowserCreated(BrowserWindowInterface* browser) override;
```
Change information
Commit message:
Implement GlobalBrowserCollection.
`GlobalBrowserCollection` is a GlobalFeature that represents an
observable collection of all BrowserWindowInterface objects globally.
See
https://docs.google.com/document/d/1aQRPDX9RjWHE48rAHntsV64VU1-4uZO_nkL6A7ohr2k/edit?tab=t.5u9lkywxkk2n
for design details.
Bug: 458021720
Change-Id: Ib9716834f2c8dda72fca05d4749bbfb86a6a6964
Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
Commit-Queue: Glenn Hartmann <hart...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1543125}
Files:
- M chrome/browser/global_features.cc
- M chrome/browser/global_features.h
- M chrome/browser/ui/browser_manager_service.cc
- M chrome/browser/ui/browser_window/BUILD.gn
- M chrome/browser/ui/browser_window/internal/BUILD.gn
- A chrome/browser/ui/browser_window/internal/global_browser_collection.cc
- A chrome/browser/ui/browser_window/internal/global_browser_collection_browsertest.cc
- A chrome/browser/ui/browser_window/public/global_browser_collection.h
- M chrome/browser/ui/browser_window/public/profile_browser_collection.h
Change size: L
Delta: 9 files changed, 256 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages