Rename MemoryPressureListener -> MemoryPressureListenerRegistration [chromium/src : main]

2 views
Skip to first unread message

Patrick Monette (Gerrit)

unread,
Oct 7, 2025, 11:38:17 PM (4 days ago) Oct 7
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, Peter Beverloo, prerendering-reviews, Stephen Chenney, James Su, Zijie He, odejesu...@chromium.org, mattreyno...@chromium.org, agriev...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, creis...@chromium.org, ddrone...@google.com, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, drott+bl...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, thiabaud+watch-d...@google.com, torne...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org
Attention needed from Francois Pierre Doray

Patrick Monette added 1 comment

Patchset-level comments
File-level comment, Patchset 18 (Latest):
Patrick Monette . resolved

Hi Francois. Another mechanical change, with some comments fixes.

PTAL and OO please!

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I734542aaa5327258a60ceaeacd76426cb272552e
Gerrit-Change-Number: 7013568
Gerrit-PatchSet: 18
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Oct 2025 03:38:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Oct 8, 2025, 4:18:39 PM (3 days ago) Oct 8
to Patrick Monette, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, Peter Beverloo, prerendering-reviews, Stephen Chenney, James Su, Zijie He, odejesu...@chromium.org, mattreyno...@chromium.org, agriev...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, creis...@chromium.org, ddrone...@google.com, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, drott+bl...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, thiabaud+watch-d...@google.com, torne...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org
Attention needed from Patrick Monette

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 21 (Latest):
Francois Pierre Doray . resolved

CR+1
OO+1 for mechanical changes to adapt to a change in //base API

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Monette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I734542aaa5327258a60ceaeacd76426cb272552e
Gerrit-Change-Number: 7013568
Gerrit-PatchSet: 21
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Oct 2025 20:18:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 8, 2025, 4:22:50 PM (3 days ago) Oct 8
to Patrick Monette, Francois Pierre Doray, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, Peter Beverloo, prerendering-reviews, Stephen Chenney, James Su, Zijie He, odejesu...@chromium.org, mattreyno...@chromium.org, agriev...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, creis...@chromium.org, ddrone...@google.com, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, drott+bl...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, iwells...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, thiabaud+watch-d...@google.com, torne...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Rename MemoryPressureListener -> MemoryPressureListenerRegistration

This is in preparation of making MemoryPressureListener a pure virtual
interface, instead of registering with a callback.

The MemoryPressureListener name is going to be reused for the pure
virtual interface.

Note that an alias for previous types exists to reduce the chances of
revert.
Bug: 436324601
Change-Id: I734542aaa5327258a60ceaeacd76426cb272552e
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1527122}
Files:
  • M base/memory/memory_pressure_listener.cc
  • M base/memory/memory_pressure_listener.h
  • M base/memory/memory_pressure_listener_registry.cc
  • M base/memory/memory_pressure_listener_registry.h
  • M base/memory/memory_pressure_listener_unittest.cc
  • M base/threading/hang_watcher.cc
  • M base/threading/hang_watcher.h
  • M cc/layers/texture_layer_unittest.cc
  • M cc/raster/staging_buffer_pool.cc
  • M cc/raster/staging_buffer_pool.h
  • M cc/resources/resource_pool.cc
  • M cc/resources/resource_pool.h
  • M cc/tiles/gpu_image_decode_cache.cc
  • M cc/tiles/gpu_image_decode_cache.h
  • M cc/trees/layer_tree_host_impl.cc
  • M cc/trees/layer_tree_host_impl.h
  • M chrome/browser/glic/public/glic_keyed_service.cc
  • M chrome/browser/glic/public/glic_keyed_service.h
  • M chrome/browser/performance_manager/policies/background_tab_loading_policy.cc
  • M chrome/browser/performance_manager/policies/background_tab_loading_policy.h
  • M chrome/browser/performance_manager/policies/urgent_page_discarding_policy.cc
  • M chrome/browser/performance_manager/policies/urgent_page_discarding_policy.h
  • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos.cc
  • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos.h
  • M chrome/browser/performance_manager/policies/working_set_trimmer_policy_chromeos.cc
  • M chrome/browser/performance_manager/policies/working_set_trimmer_policy_chromeos.h
  • M chrome/browser/resource_coordinator/tab_manager.h
  • M chrome/browser/sessions/tab_loader.cc
  • M chrome/browser/sessions/tab_loader.h
  • M chrome/browser/thumbnail/cc/thumbnail_cache.cc
  • M chrome/browser/thumbnail/cc/thumbnail_cache.h
  • M chromecast/browser/lru_renderer_cache.cc
  • M chromecast/browser/lru_renderer_cache.h
  • M chromecast/browser/memory_pressure_controller_impl.cc
  • M chromecast/browser/memory_pressure_controller_impl.h
  • M chromeos/ash/components/memory/pressure/system_memory_pressure_evaluator_unittest.cc
  • M components/breadcrumbs/core/application_breadcrumbs_logger.cc
  • M components/breadcrumbs/core/application_breadcrumbs_logger.h
  • M components/discardable_memory/service/discardable_shared_memory_manager.cc
  • M components/discardable_memory/service/discardable_shared_memory_manager.h
  • M components/history/core/browser/history_backend.cc
  • M components/history/core/browser/history_backend.h
  • M components/memory_pressure/system_memory_pressure_evaluator_fuchsia_unittest.cc
  • M components/memory_pressure/system_memory_pressure_evaluator_win_unittest.cc
  • M components/omnibox/browser/on_device_tail_model_service.cc
  • M components/omnibox/browser/on_device_tail_model_service.h
  • M components/paint_preview/player/player_compositor_delegate.cc
  • M components/paint_preview/player/player_compositor_delegate.h
  • M components/performance_manager/graph/policies/bfcache_policy.cc
  • M components/performance_manager/graph/policies/bfcache_policy.h
  • M components/services/storage/shared_storage/shared_storage_manager.cc
  • M components/services/storage/shared_storage/shared_storage_manager.h
  • M components/viz/client/frame_eviction_manager.cc
  • M components/viz/client/frame_eviction_manager.h
  • M components/viz/common/gpu/vulkan_in_process_context_provider.cc
  • M components/viz/common/gpu/vulkan_in_process_context_provider.h
  • M components/viz/service/display_embedder/compositor_gpu_thread.cc
  • M components/viz/service/display_embedder/compositor_gpu_thread.h
  • M components/viz/service/display_embedder/skia_output_surface_impl.cc
  • M content/browser/cache_storage/cache_storage_manager.cc
  • M content/browser/cache_storage/cache_storage_manager.h
  • M content/browser/dom_storage/dom_storage_context_wrapper.cc
  • M content/browser/dom_storage/dom_storage_context_wrapper.h
  • M content/browser/gpu/gpu_process_host.cc
  • M content/browser/gpu/gpu_process_host.h
  • M content/browser/network_service_client.cc
  • M content/browser/network_service_client.h
  • M content/browser/preloading/prerender/prerender_host_registry.cc
  • M content/browser/preloading/prerender/prerender_host_registry.h
  • M content/browser/renderer_host/navigation_transitions/navigation_entry_screenshot_manager.cc
  • M content/browser/renderer_host/navigation_transitions/navigation_entry_screenshot_manager.h
  • M content/browser/renderer_host/spare_render_process_host_manager_impl.cc
  • M content/browser/renderer_host/spare_render_process_host_manager_impl.h
  • M content/gpu/gpu_child_thread.cc
  • M content/gpu/gpu_child_thread.h
  • M content/public/test/network_service_test_helper.cc
  • M content/renderer/render_thread_impl.cc
  • M content/renderer/render_thread_impl.h
  • M gpu/ipc/service/gpu_channel_manager.cc
  • M gpu/ipc/service/gpu_channel_manager.h
  • M ios/chrome/app/application_delegate/memory_warning_helper_unittest.mm
  • M net/disk_cache/memory/mem_backend_impl.cc
  • M net/disk_cache/memory/mem_backend_impl.h
  • M net/http/http_network_session.cc
  • M net/http/http_network_session.h
  • M net/quic/quic_session_pool.cc
  • M net/quic/quic_session_pool.h
  • M net/ssl/ssl_client_session_cache.cc
  • M net/ssl/ssl_client_session_cache.h
  • M services/network/shared_dictionary/shared_dictionary_manager.cc
  • M services/network/shared_dictionary/shared_dictionary_manager.h
  • M services/network/shared_dictionary/shared_dictionary_manager_on_disk.cc
  • M services/network/shared_dictionary/shared_dictionary_manager_on_disk.h
  • M services/network/shared_dictionary/shared_dictionary_storage_on_disk.cc
  • M services/network/shared_dictionary/shared_dictionary_storage_on_disk.h
  • M services/network/slop_bucket.cc
  • M storage/browser/blob/blob_memory_controller.cc
  • M storage/browser/blob/blob_memory_controller.h
  • M third_party/blink/renderer/controller/user_level_memory_pressure_signal_generator_test.cc
  • M third_party/blink/renderer/platform/graphics/image_decoding_store.cc
  • M third_party/blink/renderer/platform/graphics/image_decoding_store.h
  • M third_party/blink/renderer/platform/media/url_index.cc
  • M third_party/blink/renderer/platform/media/url_index.h
  • M third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager_unittest.cc
  • M third_party/leveldatabase/leveldb_chrome.cc
Change size: L
Delta: 105 files changed, 371 insertions(+), 294 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I734542aaa5327258a60ceaeacd76426cb272552e
Gerrit-Change-Number: 7013568
Gerrit-PatchSet: 22
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages