[bedrock] Remove BrowserList [chromium/src : main]

0 views
Skip to first unread message

Thomas Lukaszewicz (Gerrit)

unread,
Apr 22, 2026, 1:17:24 AM (3 days ago) Apr 22
to Qikai Zhong, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, aixba+wat...@chromium.org, armalhotra+a...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, philli...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Qikai Zhong

Thomas Lukaszewicz voted and added 2 comments

Votes added by Thomas Lukaszewicz

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Thomas Lukaszewicz . resolved

Just needs a restamp for the buildfile fix

Commit Message
Line 7, Patchset 6:[bedrock] Remove BrowserList
Qikai Zhong . resolved

Hi, Tom, please hold this CL for some days, thanks~

Qikai Zhong

Done

Thomas Lukaszewicz

Dope - thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie61bbd3f8371cd5777d179d08ac4f47b9e29dd01
Gerrit-Change-Number: 7744394
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 05:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Qikai Zhong (Gerrit)

unread,
Apr 22, 2026, 1:50:07 AM (3 days ago) Apr 22
to Thomas Lukaszewicz, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, aixba+wat...@chromium.org, armalhotra+a...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, philli...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Thomas Lukaszewicz

Qikai Zhong voted and added 1 comment

Votes added by Qikai Zhong

Code-Review+1

1 comment

Patchset-level comments
Qikai Zhong . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie61bbd3f8371cd5777d179d08ac4f47b9e29dd01
    Gerrit-Change-Number: 7744394
    Gerrit-PatchSet: 7
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Apr 2026 05:49:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Lukaszewicz (Gerrit)

    unread,
    Apr 22, 2026, 2:14:07 PM (3 days ago) Apr 22
    to Qikai Zhong, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, aixba+wat...@chromium.org, armalhotra+a...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, philli...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org

    Thomas Lukaszewicz voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie61bbd3f8371cd5777d179d08ac4f47b9e29dd01
    Gerrit-Change-Number: 7744394
    Gerrit-PatchSet: 7
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Apr 2026 18:13:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 22, 2026, 2:19:27 PM (3 days ago) Apr 22
    to Thomas Lukaszewicz, Qikai Zhong, Peter Beverloo, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-gr...@chromium.org, aixba+wat...@chromium.org, armalhotra+a...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dullweb...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, philli...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, ydago...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bedrock] Remove BrowserList

    There are no remaining clients of BrowserList and no behavior changes
    in this CL.

    The changes involve removing the files and cleaning up any remaining
    includes / comments.
    Bug: 431671320
    Change-Id: Ie61bbd3f8371cd5777d179d08ac4f47b9e29dd01
    Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>
    Reviewed-by: Qikai Zhong <qikai...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1618978}
    Files:
    • M chrome/browser/BUILD.gn
    • M chrome/browser/app_controller_mac.mm
    • M chrome/browser/browsing_data/DEPS
    • M chrome/browser/contextual_tasks/search_ai_mode_promo_tab_helper.cc
    • M chrome/browser/device_notifications/device_connection_tracker_test_base.cc
    • M chrome/browser/glic/BUILD.gn
    • M chrome/browser/glic/service/glic_instance_coordinator_impl.cc
    • M chrome/browser/glic/widget/application_hotkey_delegate_browsertest.cc
    • M chrome/browser/performance_manager/decorators/helpers/page_live_state_decorator_helper.cc
    • M chrome/browser/push_messaging/BUILD.gn
    • M chrome/browser/resource_coordinator/BUILD.gn
    • M chrome/browser/sessions/session_service_base.cc
    • M chrome/browser/tracing/BUILD.gn
    • M chrome/browser/ui/BUILD.gn
    • M chrome/browser/ui/ash/multi_user/BUILD.gn
    • M chrome/browser/ui/autofill/payments/BUILD.gn
    • M chrome/browser/ui/autofill/payments/desktop_payments_window_manager_interactive_uitest.cc
    • M chrome/browser/ui/browser.cc
    • D chrome/browser/ui/browser_list.cc
    • D chrome/browser/ui/browser_list.h
    • M chrome/browser/ui/signin/promos/bubble_sign_in_promo_delegate_browsertest.cc
    • M chrome/browser/ui/startup/BUILD.gn
    • M chrome/browser/ui/views/frame/browser_view.cc
    • M chrome/browser/ui/views/web_apps/web_app_integration_test_driver.cc
    • M chrome/browser/ui/web_applications/test/system_web_app_interactive_uitest.cc
    • M chrome/browser/ui/webui/profile_helper_browsertest.cc
    • M chrome/browser/ui/webui/tab_strip_internals/BUILD.gn
    • M chrome/browser/ui/webui/util/BUILD.gn
    Change size: L
    Delta: 28 files changed, 13 insertions(+), 246 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Qikai Zhong
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie61bbd3f8371cd5777d179d08ac4f47b9e29dd01
    Gerrit-Change-Number: 7744394
    Gerrit-PatchSet: 8
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages