Min Qin (Gerrit)

unread,

Nov 18, 2025, 11:34:13 AM (11 days ago) Nov 18

to Viacheslav Poliudin, Lei Zhang, Gabriel Charette, Matthew Denton, Chris Hamilton, Chromium Sync Reviews, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Chromium Sync Reviews, Frank Liberato, Gabriel Charette, Lei Zhang, Matthew Denton, Olivia Saul and Viacheslav Poliudin

Min Qin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Chromium Sync Reviews
Frank Liberato
Gabriel Charette
Lei Zhang
Matthew Denton
Olivia Saul
Viacheslav Poliudin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Frank Liberato (Gerrit)

unread,

Nov 18, 2025, 11:36:20 AM (11 days ago) Nov 18

to Viacheslav Poliudin, Min Qin, Lei Zhang, Gabriel Charette, Matthew Denton, Chris Hamilton, Chromium Sync Reviews, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Chromium Sync Reviews, Gabriel Charette, Lei Zhang, Matthew Denton, Olivia Saul and Viacheslav Poliudin

Frank Liberato added 1 comment

File media/base/BUILD.gn

Line 499, Patchset 2 (Latest):

  }

  if (is_android) {

Frank Liberato . unresolved

if i've counted {} correctly, these can be merged.

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Chromium Sync Reviews

Gabriel Charette
Lei Zhang
Matthew Denton
Olivia Saul
Viacheslav Poliudin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 18, 2025, 12:19:10 PM (11 days ago) Nov 18

to Viacheslav Poliudin, Lei Zhang, Min Qin, Gabriel Charette, Matthew Denton, Chris Hamilton, Chromium Sync Reviews, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Chromium Sync Reviews, Gabriel Charette, Matthew Denton, Olivia Saul and Viacheslav Poliudin

Lei Zhang voted and added 3 comments

Votes added by Lei Zhang

Code-Review

+1

3 comments

Commit Message

Line 9, Patchset 2 (Latest):

When building a project on multiple platforms, the use of multiple files was detected that should only be used in the android build.

Lei Zhang . unresolved

Please wrap at 72 columns.

Line 11, Patchset 2 (Latest):Change-Id: I0495e478d8eb06286a823ad9297a280d7d239749

Lei Zhang . unresolved

Please add a newline with `Bug: 40217123`

File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc

Line 5, Patchset 2 (Latest):#include "base/synchronization/lock_impl.h"

Lei Zhang . unresolved

If you could move this down to line ~35, that would be great.

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Chromium Sync Reviews
Gabriel Charette

Matthew Denton
Olivia Saul
Viacheslav Poliudin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Nov 18, 2025, 1:30:41 PM (11 days ago) Nov 18

to Viacheslav Poliudin, Chromium Sync Reviews, Marc Treib, Lei Zhang, Min Qin, Gabriel Charette, Matthew Denton, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Gabriel Charette, Marc Treib, Matthew Denton, Olivia Saul and Viacheslav Poliudin

Message from gwsq

Reviewer source(s):
tr...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Gabriel Charette
Marc Treib

Matthew Denton
Olivia Saul
Viacheslav Poliudin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matthew Denton (Gerrit)

unread,

Nov 18, 2025, 5:19:01 PM (11 days ago) Nov 18

to Viacheslav Poliudin, Chromium Sync Reviews, Marc Treib, Lei Zhang, Min Qin, Gabriel Charette, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Gabriel Charette, Marc Treib, Olivia Saul and Viacheslav Poliudin

Matthew Denton voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Gabriel Charette
Marc Treib

Olivia Saul
Viacheslav Poliudin

satisfied_requirement

unsatisfied_requirement

open

diffy

Gabriel Charette (Gerrit)

unread,

Nov 18, 2025, 7:08:46 PM (11 days ago) Nov 18

to Viacheslav Poliudin, Gabriel Charette, Matthew Denton, Chromium Sync Reviews, Marc Treib, Lei Zhang, Min Qin, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Marc Treib, Olivia Saul and Viacheslav Poliudin

Gabriel Charette voted and added 1 comment

Votes added by Gabriel Charette

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Gabriel Charette . resolved

Happy to owners-override once other comments are addressed, we shouldn't need 7 reviewers for this. Just add me or any //base owners back on the attention-set when rdy.

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton

satisfied_requirement

unsatisfied_requirement

open

diffy

Viacheslav Poliudin (Gerrit)

unread,

Nov 19, 2025, 2:27:23 AM (11 days ago) Nov 19

to Gabriel Charette, Matthew Denton, Chromium Sync Reviews, Marc Treib, Lei Zhang, Min Qin, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Frank Liberato, Gabriel Charette, Lei Zhang, Marc Treib, Matthew Denton, Min Qin and Olivia Saul

Viacheslav Poliudin added 4 comments

Commit Message

Line 9, Patchset 2:

When building a project on multiple platforms, the use of multiple files was detected that should only be used in the android build.

Lei Zhang . resolved

Please wrap at 72 columns.

Viacheslav Poliudin

Done

Line 11, Patchset 2:Change-Id: I0495e478d8eb06286a823ad9297a280d7d239749

Lei Zhang . resolved

Please add a newline with `Bug: 40217123`

Viacheslav Poliudin

Done

File media/base/BUILD.gn

Line 499, Patchset 2:

  }

  if (is_android) {

Frank Liberato . resolved

if i've counted {} correctly, these can be merged.

Viacheslav Poliudin

Yeah, with '{}' ok
I didn't move lines to group with demuxer_memory_limit, and create new is_android

File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc

Line 5, Patchset 2:#include "base/synchronization/lock_impl.h"

Lei Zhang . resolved

If you could move this down to line ~35, that would be great.

Viacheslav Poliudin

I moved this header, and 'git cl format' asked me to move 'sandbox/linux/seccomp-bpf-helpers/baseline_policy.h' at start

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton

Frank Liberato
Gabriel Charette
Lei Zhang

Marc Treib
Matthew Denton
Min Qin
Olivia Saul

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 19, 2025, 2:33:04 AM (11 days ago) Nov 19

to Viacheslav Poliudin, Lei Zhang, Gabriel Charette, Matthew Denton, Chromium Sync Reviews, Marc Treib, Min Qin, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Frank Liberato, Gabriel Charette, Marc Treib, Matthew Denton, Min Qin, Olivia Saul and Viacheslav Poliudin

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review	+1
Owners-Override	+1

1 comment

File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc

Line 5, Patchset 2:#include "base/synchronization/lock_impl.h"

Lei Zhang . resolved

If you could move this down to line ~35, that would be great.

Viacheslav Poliudin

I moved this header, and 'git cl format' asked me to move 'sandbox/linux/seccomp-bpf-helpers/baseline_policy.h' at start

Lei Zhang

That's fine. foo_unittest.cc should include foo.h first.

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Frank Liberato
Gabriel Charette

Marc Treib
Matthew Denton
Min Qin
Olivia Saul

Viacheslav Poliudin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matthew Denton (Gerrit)

unread,

Nov 19, 2025, 3:46:35 AM (11 days ago) Nov 19

to Viacheslav Poliudin, Chromium LUCI CQ, Alexander Yashkin, Lei Zhang, Gabriel Charette, Chromium Sync Reviews, Marc Treib, Min Qin, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Frank Liberato, Gabriel Charette, Marc Treib, Min Qin, Olivia Saul and Viacheslav Poliudin

Matthew Denton voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Frank Liberato
Gabriel Charette
Marc Treib

Min Qin
Olivia Saul
Viacheslav Poliudin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Marc Treib (Gerrit)

unread,

Nov 19, 2025, 4:51:07 AM (11 days ago) Nov 19

to Viacheslav Poliudin, Marc Treib, Matthew Denton, Chromium LUCI CQ, Alexander Yashkin, Lei Zhang, Gabriel Charette, Chromium Sync Reviews, Min Qin, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Frank Liberato, Gabriel Charette, Min Qin, Olivia Saul and Viacheslav Poliudin

Marc Treib voted and added 1 comment

Votes added by Marc Treib

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Marc Treib . resolved

rslgtm, though it's not relevant anymore since you got owners-override

Open in Gerrit

Related details

Attention is currently required from:

Chris Hamilton
Frank Liberato
Gabriel Charette

satisfied_requirement

open

diffy

Alexander Yashkin (Gerrit)

unread,

Nov 19, 2025, 5:07:26 AM (11 days ago) Nov 19

to Viacheslav Poliudin, Marc Treib, Matthew Denton, Chromium LUCI CQ, Lei Zhang, Gabriel Charette, Chromium Sync Reviews, Min Qin, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Chris Hamilton, Frank Liberato, Gabriel Charette, Min Qin, Olivia Saul and Viacheslav Poliudin

Alexander Yashkin voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 19, 2025, 5:20:29 AM (11 days ago) Nov 19

to Viacheslav Poliudin, Marc Treib, Matthew Denton, Alexander Yashkin, Lei Zhang, Gabriel Charette, Chromium Sync Reviews, Min Qin, Chris Hamilton, Olivia Saul, chromium...@chromium.org, armalhotra+a...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, feature-me...@chromium.org, mpdento...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Fix android-only deps



When building a project on multiple platforms, the use of multiple files
was detected that should only be used in the android build.

Bug: 40217123

Change-Id: I0495e478d8eb06286a823ad9297a280d7d239749

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7167230

Reviewed-by: Matthew Denton <mpde...@chromium.org>

Reviewed-by: Lei Zhang <the...@chromium.org>

Owners-Override: Lei Zhang <the...@chromium.org>

Reviewed-by: Marc Treib <tr...@chromium.org>

Commit-Queue: Alexander Yashkin <a-...@yandex-team.ru>

Cr-Commit-Position: refs/heads/main@{#1547059}

Files:

M base/synchronization/lock_unittest.cc
M chrome/browser/sync/sync_service_factory.cc
M chrome/browser/ui/autofill/payments/chrome_payments_autofill_client.cc
M components/data_sharing/internal/BUILD.gn
M content/app/content_main_runner_impl.cc
M media/base/BUILD.gn
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc
M services/resource_coordinator/memory_instrumentation/aggregate_metrics_processor.cc
M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_linux.cc

Change size: M

Delta: 10 files changed, 35 insertions(+), 18 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Matthew Denton, +1 by Lei Zhang, +1 by Marc Treib

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Fix android-only deps [chromium/src : main]

Min Qin (Gerrit)

Min Qin voted Code-Review+1

Related details

Frank Liberato (Gerrit)

Frank Liberato added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 3 comments

Votes added by Lei Zhang

3 comments

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Matthew Denton (Gerrit)

Matthew Denton voted Code-Review+1

Related details

Gabriel Charette (Gerrit)

Gabriel Charette voted and added 1 comment

Votes added by Gabriel Charette

1 comment

Related details

Viacheslav Poliudin (Gerrit)

Viacheslav Poliudin added 4 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

Matthew Denton (Gerrit)

Matthew Denton voted Code-Review+1

Related details

Marc Treib (Gerrit)

Marc Treib voted and added 1 comment

Votes added by Marc Treib

1 comment

Related details

Alexander Yashkin (Gerrit)

Alexander Yashkin voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information