[bedrock] Migrate read_anything_service.cc away from BrowserListObserver. [chromium/src : main]

0 views
Skip to first unread message

Glenn Hartmann (Gerrit)

unread,
Nov 10, 2025, 3:26:55 PMNov 10
to Lauren Winston, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, jatapiaro+wat...@google.com, lwinston+watc...@google.com, rginda...@chromium.org, trewin...@google.com
Attention needed from Lauren Winston

Glenn Hartmann voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lauren Winston
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifecb8278b83b8f9ae914a6f240b78d256a6a6964
Gerrit-Change-Number: 7088446
Gerrit-PatchSet: 22
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Lauren Winston <lwin...@google.com>
Gerrit-Attention: Lauren Winston <lwin...@google.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 20:26:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lauren Winston (Gerrit)

unread,
Nov 10, 2025, 3:32:14 PMNov 10
to Glenn Hartmann, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, jatapiaro+wat...@google.com, lwinston+watc...@google.com, rginda...@chromium.org, trewin...@google.com
Attention needed from Glenn Hartmann

Lauren Winston voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Glenn Hartmann
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifecb8278b83b8f9ae914a6f240b78d256a6a6964
Gerrit-Change-Number: 7088446
Gerrit-PatchSet: 22
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Lauren Winston <lwin...@google.com>
Gerrit-Attention: Glenn Hartmann <hart...@chromium.org>
Gerrit-Comment-Date: Mon, 10 Nov 2025 20:32:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Glenn Hartmann (Gerrit)

unread,
Nov 10, 2025, 3:34:05 PMNov 10
to Lauren Winston, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, jatapiaro+wat...@google.com, lwinston+watc...@google.com, rginda...@chromium.org, trewin...@google.com

Glenn Hartmann voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifecb8278b83b8f9ae914a6f240b78d256a6a6964
Gerrit-Change-Number: 7088446
Gerrit-PatchSet: 22
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Lauren Winston <lwin...@google.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 20:33:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 10, 2025, 3:37:23 PMNov 10
to Glenn Hartmann, Lauren Winston, chromium...@chromium.org, dewitt...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, grt+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, jatapiaro+wat...@google.com, lwinston+watc...@google.com, rginda...@chromium.org, trewin...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
[bedrock] Migrate read_anything_service.cc away from BrowserListObserver.

Note that this changes the existing observer from listening to all
browsers globally to just listening to browsers within the relevant
Profile.

This migration is part of project bedrock to reduce the dependencies on
Browser and BrowserList. See https://crbug.com/431671320 for more info.
Bug: 459505408
Change-Id: Ifecb8278b83b8f9ae914a6f240b78d256a6a6964
Reviewed-by: Lauren Winston <lwin...@google.com>
Commit-Queue: Glenn Hartmann <hart...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1542723}
Files:
  • M chrome/browser/ui/read_anything/read_anything_service.cc
  • M chrome/browser/ui/read_anything/read_anything_service.h
Change size: S
Delta: 2 files changed, 15 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lauren Winston
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifecb8278b83b8f9ae914a6f240b78d256a6a6964
Gerrit-Change-Number: 7088446
Gerrit-PatchSet: 23
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Lauren Winston <lwin...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages