Use mojo Time for chrome://discards state_change_time [chromium/src : main]
Helmut Januschka (Gerrit)
Helmut Januschka has uploaded the change for review![]( "Open in Gerrit")
Commit message
Use mojo Time for chrome://discards state_change_time
Stamp a wall-clock alongside TimeTicks in LifecycleUnitBase::SetState
and ship it via the mojom Time field so the display is an actual wall
clock instead of a TimeTicks::UnixEpoch-relative TimeDelta.
Change diff
Change information
- M chrome/browser/resource_coordinator/lifecycle_unit.h
- M chrome/browser/resource_coordinator/lifecycle_unit_base.cc
- M chrome/browser/resource_coordinator/lifecycle_unit_base.h
- M chrome/browser/resource_coordinator/lifecycle_unit_base_unittest.cc
- M chrome/browser/resources/discards/discards_tab.ts
- M chrome/browser/ui/webui/discards/discards.mojom
- M chrome/browser/ui/webui/discards/discards_ui.cc
- M chrome/test/data/webui/discards/discards_test.ts
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
CL is part of the effort to get rid of TimeTicks::UnixEpoch()
Related details
- Chromium IPC Reviews
- Joe Mason
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mk...@chromium.org
Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Joe Mason
- Mike West
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Joe Mason voted and added 3 comments![]( "Open in Gerrit")
Votes added by Joe Mason
| Code-Review | +1 |
3 comments
Nice improvement, thanks! LGTM with nits
function mojoTimeToDate(mojoTime: Time): Date {There's a mojo_base.mojom.JSTime that will do this conversion automatically.
mojo_base.mojom.Time state_change_time;Nit: prefer JSTime here.
Related details
- Helmut Januschka
- Mike West
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Mike West voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mike West
| Code-Review | +1 |
1 comment
LGTM2 % Joe's comments. :)
Related details
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |