Rewrite --force unsafe buffers pragmas in services/ [chromium/src : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Aug 11, 2025, 2:45:49 PMAug 11
to Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, ningxin hu, Jiewei Qian, chrome-gr...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, mbarowsky+watc...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, rhalava...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7176be59e47d16ebce2acf33a7013809ba02f248
Gerrit-Change-Number: 6833115
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: ningxin hu <ningx...@intel.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Mon, 11 Aug 2025 18:45:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Aug 12, 2025, 12:31:58 PMAug 12
to Tom Sepez, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, ningxin hu, Jiewei Qian, chrome-gr...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, mbarowsky+watc...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, rhalava...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Tom Sepez

Nico Weber voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7176be59e47d16ebce2acf33a7013809ba02f248
Gerrit-Change-Number: 6833115
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: ningxin hu <ningx...@intel.com>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Tue, 12 Aug 2025 16:31:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Aug 12, 2025, 12:36:01 PMAug 12
to Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, ningxin hu, Jiewei Qian, chrome-gr...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, mbarowsky+watc...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, rhalava...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Tom Sepez voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7176be59e47d16ebce2acf33a7013809ba02f248
Gerrit-Change-Number: 6833115
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: ningxin hu <ningx...@intel.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 16:35:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 12, 2025, 1:31:50 PMAug 12
to Tom Sepez, Nico Weber, chromium...@chromium.org, ningxin hu, Jiewei Qian, chrome-gr...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, mbarowsky+watc...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, rhalava...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Rewrite --force unsafe buffers pragmas in services/
Change-Id: I7176be59e47d16ebce2acf33a7013809ba02f248
Owners-Override: Nico Weber <tha...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1500260}
Files:
  • M services/audio/input_controller.cc
  • M services/audio/input_sync_writer.cc
  • M services/audio/input_sync_writer_unittest.cc
  • M services/audio/public/cpp/output_device_unittest.cc
  • M services/audio/snooper_node_unittest.cc
  • M services/data_decoder/image_decoder_impl_unittest.cc
  • M services/device/geolocation/location_provider_manager_unittest.cc
  • M services/device/hid/hid_connection_linux.cc
  • M services/device/hid/hid_service_linux.cc
  • M services/device/serial/serial_io_handler_posix.cc
  • M services/device/usb/usb_device_handle_usbfs.cc
  • M services/proxy_resolver/proxy_resolver_v8.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_linux.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_unittest.cc
  • M services/screen_ai/screen_ai_library_wrapper_impl.cc
  • M services/tracing/perfetto/consumer_host.cc
  • M services/tracing/perfetto/perfetto_service.cc
  • M services/tracing/perfetto/privacy_filtering_check.cc
  • M services/tracing/public/cpp/perfetto/perfetto_config.cc
  • M services/webnn/webnn_graph_impl_backend_test.cc
Change size: L
Delta: 20 files changed, 107 insertions(+), 171 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Weber
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7176be59e47d16ebce2acf33a7013809ba02f248
Gerrit-Change-Number: 6833115
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages