Remove the old locataion of split tab id/visual data [chromium/src : main]

0 views
Skip to first unread message

David Pennington (Gerrit)

unread,
Jan 27, 2026, 5:15:51 PMJan 27
to Alison Gale, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, performance-m...@chromium.org
Attention needed from Alison Gale

David Pennington voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5e2592b40aa401d1b9e81a9a1bedab09f59cbd4e
Gerrit-Change-Number: 7520512
Gerrit-PatchSet: 3
Gerrit-Owner: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Attention: Alison Gale <ag...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 22:15:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alison Gale (Gerrit)

unread,
Jan 27, 2026, 5:16:37 PMJan 27
to David Pennington, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, performance-m...@chromium.org

Alison Gale voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5e2592b40aa401d1b9e81a9a1bedab09f59cbd4e
Gerrit-Change-Number: 7520512
Gerrit-PatchSet: 3
Gerrit-Owner: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 22:16:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 27, 2026, 5:23:17 PMJan 27
to Alison Gale, David Pennington, chromium...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, performance-m...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove the old locataion of split tab id/visual data
Bug: 443780638
Change-Id: I5e2592b40aa401d1b9e81a9a1bedab09f59cbd4e
Reviewed-by: David Pennington <dpen...@chromium.org>
Commit-Queue: Alison Gale <ag...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1575512}
Files:
  • M components/browser_apis/tab_strip/BUILD.gn
  • M components/browser_apis/tab_strip/types/BUILD.gn
  • M components/tabs/BUILD.gn
  • M components/tabs/impl/split_tab_collection.cc
  • M components/tabs/impl/split_tab_data.cc
  • M components/tabs/impl/tab_strip_collection.cc
  • M components/tabs/public/mock_tab_interface.h
  • M components/tabs/public/split_tab_collection.h
  • M components/tabs/public/split_tab_data.h
  • D components/tabs/public/split_tab_id.h
  • D components/tabs/public/split_tab_visual_data.h
  • M components/tabs/public/tab_strip_collection.h
Change size: M
Delta: 12 files changed, 14 insertions(+), 63 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Pennington
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5e2592b40aa401d1b9e81a9a1bedab09f59cbd4e
Gerrit-Change-Number: 7520512
Gerrit-PatchSet: 4
Gerrit-Owner: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages