[bedrock] Update TestBrowserWindow ownership [chromium/src : main]
0 views
Skip to first unread message
Tom Lukaszewicz (Gerrit)
Aug 11, 2025, 4:39:55 AMAug 11
to Dana Fried, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cwp-review...@google.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jdonnel...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
Attention needed from Dana Fried
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Aug 11, 2025, 11:37:59 AMAug 11
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cwp-review...@google.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jdonnel...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
Attention needed from Tom Lukaszewicz
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Aug 11, 2025, 3:36:36 PMAug 11
to Dana Fried, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cwp-review...@google.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jdonnel...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
Tom Lukaszewicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 11, 2025, 4:10:07 PMAug 11
to Tom Lukaszewicz, Dana Fried, chromium...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, cwp-review...@google.com, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jdonnel...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mdjone...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[bedrock] Update TestBrowserWindow ownership
This is a mechanical change with no intended behavioral differences.
This CL updates Browser::CreateParams::window to be an owned
BrowserWindow instance, that the Browser owns and is responsible
for destroying. Note: This is explicitly a test-only param.
This is a necessary first step in the Browser ownership rework where
the Browser will own its BrowserWindow.
Currently all unit tests that instantiate a TestBrowserWindow also
instantiate an owned Browser instance (vs production code where
the Browser instance is owned by its NativeWidget).
This results in a lot of unnecessary code (manual instantiation of
TestBrowserWindow and utilities such as class
TestBrowserWindowOwner).
This CL dramatically simplifies existing unit tests (eliminating a
ton of unnecessary BrowserWindow management) and also simplifies
the transition to the new ownership model where Browser owns
BrowserWindow.
The follow up will transition production code to have the Browser
own its BrowserWindow, and Browser::window_for_testing_ will be
consolidated with Browser::window_.
Note: Updating Browser::CreateParams to hold a unique_ptr for
CreateParams::window requires updating CreateParams to be move-only.
Currently there are over 400 instances of CreateParams and many
call sites assume CreateParams are copyable. A follow up change will
make CreateParams move-only (or remove the param completely as
Browser unit-tests are otherwise deprecated).
Bug: 413168662
Change-Id: I7fd6d5b526e991dcfa45713f52da386da0cac8af
Reviewed-by: Dana Fried <dfr...@chromium.org>
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1499773}
Files:
- M chrome/browser/apps/app_service/metrics/app_platform_metrics_service_unittest.cc
- M chrome/browser/apps/app_shim/app_shim_manager_mac_unittest.cc
- M chrome/browser/ash/child_accounts/family_user_chrome_activity_metrics_unittest.cc
- M chrome/browser/chromeos/app_mode/kiosk_browser_logs_collector_unittest.cc
- M chrome/browser/chromeos/app_mode/kiosk_browser_session_unittest.cc
- M chrome/browser/chromeos/extensions/telemetry/api/events/event_manager_unittest.cc
- M chrome/browser/download/bubble/download_bubble_ui_controller_unittest.cc
- M chrome/browser/download/bubble/download_display_controller_unittest.cc
- M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api_unittest.cc
- M chrome/browser/extensions/api/management/management_api_unittest.cc
- M chrome/browser/extensions/api/page_capture/page_capture_api_unittest.cc
- M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc
- M chrome/browser/extensions/api/permissions/permissions_api_unittest.cc
- M chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_api_unittest.cc
- M chrome/browser/extensions/api/search/search_api_unittest.cc
- M chrome/browser/extensions/api/tab_groups/tab_groups_api_unittest.cc
- M chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
- M chrome/browser/extensions/app_tab_helper_unittest.cc
- M chrome/browser/extensions/extension_context_menu_model_unittest.cc
- M chrome/browser/extensions/permissions/host_access_requests_helper_unittest.cc
- M chrome/browser/metrics/perf/windowed_incognito_observer_unittest.cc
- M chrome/browser/optimization_guide/optimization_guide_tab_url_provider_unittest.cc
- M chrome/browser/performance_manager/user_tuning/cpu_health_tracker_unittest.cc
- M chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
- M chrome/browser/resource_coordinator/tab_manager_unittest.cc
- M chrome/browser/safe_browsing/tailored_security/chrome_tailored_security_service_unittest.cc
- M chrome/browser/segmentation_platform/client_util/local_tab_handler_unittest.cc
- M chrome/browser/sessions/session_data_service_unittest.cc
- M chrome/browser/sync/sessions/browser_list_router_helper_unittest.cc
- M chrome/browser/ui/ash/media_client/media_client_impl_unittest.cc
- M chrome/browser/ui/ash/shelf/chrome_shelf_controller_unittest.cc
- M chrome/browser/ui/browser.cc
- M chrome/browser/ui/browser.h
- M chrome/browser/ui/browser_close_unittest.cc
- M chrome/browser/ui/browser_command_controller_unittest.cc
- M chrome/browser/ui/browser_finder_chromeos_unittest.cc
- M chrome/browser/ui/browser_unittest.cc
- M chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm
- M chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
- M chrome/browser/ui/extensions/extension_installed_waiter_unittest.cc
- M chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc
- M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
- M chrome/browser/ui/views/commerce/product_specifications_button_unittest.cc
- M chrome/browser/ui/views/download/bubble/download_bubble_contents_view_unittest.cc
- M chrome/browser/ui/views/download/bubble/download_bubble_security_view_unittest.cc
- M chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
- M chrome/browser/ui/views/permissions/permission_prompt_base_view_unittest.cc
- M chrome/browser/ui/views/permissions/permission_prompt_bubble_two_origins_view_unittest.cc
- M chrome/browser/ui/views/profiles/profile_customization_bubble_sync_controller_unittest.cc
- M chrome/browser/ui/views/tabs/tab_strip_action_container_unittest.cc
- M chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler_unittest.cc
- M chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
- M chrome/browser/ui/webui/side_panel/customize_chrome/customize_chrome_page_handler_unittest.cc
- M chrome/browser/ui/webui/side_panel/customize_chrome/customize_toolbar/customize_toolbar_handler_unittest.cc
- M chrome/browser/ui/webui/tab_search/tab_search_page_handler_unittest.cc
- M chrome/browser/ui/webui/tab_strip/tab_strip_page_handler_unittest.cc
- M chrome/test/base/browser_with_test_window_test.cc
- M chrome/test/base/browser_with_test_window_test.h
- M chrome/test/base/test_browser_window.cc
- M chrome/test/base/test_browser_window.h
- M chrome/test/base/test_browser_window_aura.cc
Change size: L
Delta: 61 files changed, 263 insertions(+), 371 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dana Fried
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages