Tom Lukaszewicz (Gerrit)

unread,

Mar 4, 2026, 5:05:09 PM (8 days ago) Mar 4

to Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org

Attention needed from Keren Zhu

Tom Lukaszewicz voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Keren Zhu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Keren Zhu (Gerrit)

unread,

Mar 4, 2026, 9:40:08 PM (8 days ago) Mar 4

to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Attention needed from Tom Lukaszewicz

Keren Zhu added 2 comments

File chrome/browser/resource_coordinator/utils.cc

Line 50, Patchset 2 (Latest):

      /*use_outermost_main_frame_check=*/web_contents_discard_enabled);
  AttemptFastKillForDiscardResult result =

Keren Zhu . unresolved

Please fix this WARNING reported by ClangTidy: check: bugprone-argument-comment

argument name 'use_outermost_main_frame_check'...

check: bugprone-argument-comment

argument name 'use_outermost_main_frame_check' in comment does not match parameter name 'ignore_pending_reuse' (https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)

(Note: You can add `Skip-Clang-Tidy-Checks: bugprone-argument-comment` footer to the CL description to skip the check)

(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)

Line 69, Patchset 2 (Latest): /*use_outermost_main_frame_check=*/web_contents_discard_enabled)) {

Keren Zhu . unresolved

ditto.

Open in Gerrit

Related details

Attention is currently required from:

Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Lukaszewicz (Gerrit)

unread,

Mar 5, 2026, 2:07:31 PM (7 days ago) Mar 5

to Chromium LUCI CQ, Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org

Attention needed from Keren Zhu

Tom Lukaszewicz voted and added 2 comments

Votes added by Tom Lukaszewicz

Commit-Queue

+1

2 comments

File chrome/browser/resource_coordinator/utils.cc

Line 50, Patchset 2:

      /*use_outermost_main_frame_check=*/web_contents_discard_enabled);
  AttemptFastKillForDiscardResult result =

Keren Zhu . resolved

Please fix this WARNING reported by ClangTidy: check: bugprone-argument-comment
argument name 'use_outermost_main_frame_check'...
check: bugprone-argument-comment
argument name 'use_outermost_main_frame_check' in comment does not match parameter name 'ignore_pending_reuse' (https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)
(Note: You can add `Skip-Clang-Tidy-Checks: bugprone-argument-comment` footer to the CL description to skip the check)
(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)

Tom Lukaszewicz

Done

Line 69, Patchset 2: /*use_outermost_main_frame_check=*/web_contents_discard_enabled)) {

Keren Zhu . resolved

ditto.

Tom Lukaszewicz

Forgot to update this for the new param that was added - thanks for the catch.

Open in Gerrit

Related details

Attention is currently required from:

Keren Zhu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Keren Zhu (Gerrit)

unread,

Mar 5, 2026, 2:08:23 PM (7 days ago) Mar 5

to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Attention needed from Tom Lukaszewicz

Keren Zhu voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Tom Lukaszewicz (Gerrit)

unread,

Mar 8, 2026, 4:24:25 PM (4 days ago) Mar 8

to Keren Zhu, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Tom Lukaszewicz voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 8, 2026, 5:16:46 PM (4 days ago) Mar 8

to Tom Lukaszewicz, Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/resource_coordinator/utils.cc
Insertions: 3, Deletions: 3.

@@ -47,7 +47,7 @@
       /*skip_unload_handlers=*/false,
       /*ignore_workers=*/false,
       /*ignore_keep_alive=*/false,
-      /*ignore_pending_reuse=*/false);
+      /*ignore_pending_reuse=*/false,
       /*use_outermost_main_frame_check=*/web_contents_discard_enabled);
   AttemptFastKillForDiscardResult result =
       succeed ? AttemptFastKillForDiscardResult::kKilled
@@ -67,15 +67,15 @@
             1u, /*skip_unload_handlers=*/true,
             /*ignore_workers=*/should_ignore_workers,
             /*ignore_keep_alive=*/false,
-            /*ignore_pending_reuse=*/false)) {
+            /*ignore_pending_reuse=*/false,
             /*use_outermost_main_frame_check=*/web_contents_discard_enabled)) {
       result =
           should_ignore_workers
               ? AttemptFastKillForDiscardResult::
                     kKilledWithoutUnloadHandlersAndWorkers
               : AttemptFastKillForDiscardResult::kKilledWithoutUnloadHandlers;
-            }
     }
+  }
 #endif
   base::UmaHistogramEnumeration("Discarding.AttemptFastKillForDiscardResult",
                                 result);
```

Change information

Commit message:

[discard] Set single_outermost_main_frame for WebContentsDiscard

Reland of crrev.com/c/7205447 - no changes.

This CL updates AttemptFastKillForDiscard() to set the
single_outermost_main_frame param for FastShutdownIfPossible() when
running the WebContentsDiscard experiment.

This param allows fast-kills in the case where all frames resident
in a process belong to a single WebContents, vs page_count which
checks for RenderWidgetHost counts (all of which may belong to
a single tab but add to a count greater than 0).

This CL affects behavior only when running WebContentsDiscard
(behavior is unchanged otherwise).

Bug: 463735439

Change-Id: Iaae95c88a27efb92438d7eeb269e46129a1fb392

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7632650

Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>

Reviewed-by: Keren Zhu <kere...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1596089}

Files:

M chrome/browser/resource_coordinator/utils.cc

Change size: S

Delta: 1 file changed, 14 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Keren Zhu

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[discard] Set single_outermost_main_frame for WebContentsDiscard [chromium/src : main]

Tom Lukaszewicz (Gerrit)

Tom Lukaszewicz voted Commit-Queue+1

Related details

Keren Zhu (Gerrit)

Keren Zhu added 2 comments

Related details

Tom Lukaszewicz (Gerrit)

Tom Lukaszewicz voted and added 2 comments

Votes added by Tom Lukaszewicz

2 comments

Related details

Keren Zhu (Gerrit)

Keren Zhu voted Code-Review+1

Related details

Tom Lukaszewicz (Gerrit)

Tom Lukaszewicz voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information