Require AccessibilityApi on all mode-enabling methods [chromium/src : main]
0 views
Skip to first unread message
Benjamin Beaudry (Gerrit)
Apr 14, 2026, 9:45:16 AM (11 days ago) Apr 14
to Mark Schillaci, Hu, Ningxin, Hans Wennborg, Menard, Alexis, Khushal Sagar, Mirko Bonadei, Olga Gerchikov, Avi Drissman, Daniel Andersson, Peter Williamson, Michael Moss, Yao Xiao, Henrique Ferreiro, Stephen Chenney, James Su, Josh Karlin, Victor Tan, Hongchan Choi, Kenneth R Christiansen, Tommy Li, Jerome Jiang, Raphael Kubo da Costa, Kentaro Hara, Simon Hangl, Daniel Cheng, Yoav Weiss (@Shopify), Sarah Krakowiak, Zijie He, Nate Chapin, Hirokazu Honda, Nikhil Nayunigari, Ian Vollick, Enterprise Policy Reviews, Lin, Wanming, Thorsten Kober, Mangesh Ghiware, Sadrul Chowdhury, Arnaud Mandy, Andrew Rayskiy, Xida Chen, Rijubrata Bhaumik, Hiroki Nakagawa, Kenneth Rohde Christiansen, Mathias Bynens, Heron Yang, Fredrik Söderquist, Christian Biesinger, Dirk Schulze, srirama chandra sekhar, Kevin Babbitt, Jiewei Qian, Peter Beverloo, Lei Zhang, Wang, Wei4, AJITH KUMAR V, Kevin McNee, James Maclean, CJ DiMeglio, Javier Fernandez, Anurag Simgeker, Mike Taylor, Zewen Li, AyeAye Python Dispatcher, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, (Julie)Jeongeun Kim, headless...@chromium.org, jbroma...@chromium.org, jackshira+w...@google.com, chasej...@chromium.org, jatapiaro+wat...@google.com, crostin...@chromium.org, jackshira+wa...@google.com, danakj...@chromium.org, bici...@google.com, bling-ai-foundatio...@google.com, mickeybu...@chromium.org, wychen...@chromium.org, scheduler...@chromium.org, webapks-...@chromium.org, ashleynewson+w...@chromium.org, dibyapal+wa...@chromium.org, hidehik...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, erickun...@chromium.org, mtomas...@chromium.org, mek+w...@chromium.org, jimmyxgong+f...@chromium.org, dfried...@chromium.org, lens-chrome...@google.com, japhet+...@chromium.org, jackshira+w...@google.com, mfoltz+wa...@chromium.org, fenced-fra...@chromium.org, chrstn...@google.com, edgesto...@microsoft.com, dmurph+wa...@chromium.org, jeffreycohen+watc...@chromium.org, network-ser...@chromium.org, jkeitel+watch-...@google.com, pdf-r...@chromium.org, jonmann+wat...@chromium.org, ramyagopa...@google.com, jackshira+wa...@google.com, ender...@chromium.org, arc-review...@google.com, crisrael+w...@google.com, alandin...@chromium.org, translat...@chromium.org, petewi...@chromium.org, csharrison+...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, msrame...@chromium.org, loading-rev...@chromium.org, gavinp+p...@chromium.org, loading-rev...@chromium.org, njeunje+...@chromium.org, storage...@chromium.org, menghua...@google.com, performance-m...@chromium.org, odejesu...@chromium.org, loading...@chromium.org, phshah...@chromium.org, spang...@chromium.org, chungshe...@google.com, tranbaod...@chromium.org, penghuan...@chromium.org, crost...@chromium.org, yuezhang...@chromium.org, siashah+au...@chromium.org, hansberry+wa...@chromium.org, kinuko...@chromium.org, glazuno...@chromium.org, tbarzi...@chromium.org, amaliev+...@chromium.org, pushi+watc...@google.com, aashna...@google.com, bartek...@chromium.org, csharris...@chromium.org, jz...@chromium.org, crisrael+wa...@google.com, chrome-regionalc...@google.com, mar...@chromium.org, donnd...@chromium.org, iwells...@chromium.org, yfriedm...@chromium.org, yhanada+...@chromium.org, devtools-re...@chromium.org, webauthn...@chromium.org, jbauma...@chromium.org, ios-revie...@chromium.org, toshikikikuch...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, scheduler-b...@chromium.org, pkotwic...@chromium.org, michaelchec...@google.com, dmurph+watch...@chromium.org, dclasson+w...@google.com, harringt...@chromium.org, jimmyxgong+wat...@chromium.org, hais+wat...@google.com, julietlevesque...@google.com, dennyh...@google.com, speed-metrics...@chromium.org, ajayramamurth...@google.com, michaelcheco+watch-i...@google.com, kinuko...@chromium.org, rrsilva+wat...@google.com, cros-report...@google.com, tote-eng...@google.com, fserb...@chromium.org, chromotin...@chromium.org, arthursonzog...@chromium.org, feature-v...@chromium.org, michaelcheco+wa...@google.com, dtseng+c...@chromium.org, agriev...@chromium.org, dmurph+wat...@chromium.org, aixba+wat...@chromium.org, dtapuska+...@chromium.org, security-...@chromium.org, rsesek...@chromium.org, trewin...@google.com, jimmyxgong+w...@chromium.org, kuragin+web-ap...@chromium.org, niharm...@google.com, zol...@webkit.org, derinel+wat...@google.com, browser-comp...@chromium.org, grt+...@chromium.org, geoffla...@chromium.org, omnibox-...@chromium.org, cwalle...@chromium.org, mreichhoff+watc...@chromium.org, lizeb...@chromium.org, michaelcheco+...@google.com, andysjl...@chromium.org, extension...@chromium.org, pdr+svgw...@chromium.org, mkwst+w...@chromium.org, tluk+...@chromium.org, web-schedulin...@chromium.org, loading-re...@chromium.org, halliwe...@chromium.org, horo+...@chromium.org, liu+wa...@chromium.org, suetfei+wa...@google.com, gavinp...@chromium.org, android-web...@chromium.org, dmurph+watching...@chromium.org, ajayramamu...@google.com, cblume+im...@chromium.org, yusufo...@chromium.org, accessibility-a...@google.com, chrome-tab-group-en...@google.com, byronle...@chromium.org, eme-r...@chromium.org, gavin...@chromium.org, vinnypersky+...@google.com, tburkar...@chromium.org, ortuno...@chromium.org, devtools...@chromium.org, ejcaruso+wa...@chromium.org, print-rev...@chromium.org, cros-setti...@google.com, chromium-a...@chromium.org, apavlo...@chromium.org, jbrom...@chromium.org, penghu...@chromium.org, antoniosarto...@chromium.org, video-networking...@google.com, npm+...@chromium.org, nwoked...@chromium.org, jshin...@chromium.org, nyquis...@chromium.org, shannc...@chromium.org, mbarowsky+watc...@chromium.org, shend...@chromium.org, mdjone...@chromium.org, dmurph+watchin...@chromium.org, ozone-...@chromium.org, drott+bl...@chromium.org, thiabaud+watch-d...@google.com, osaul+aut...@google.com, nickdiego+wa...@igalia.com, rkgibso...@chromium.org, akingsb+wat...@google.com, yhanada...@chromium.org, dtapuska+ch...@chromium.org, eric.c...@apple.com, aji...@samsung.com, chromeos-ca...@google.com, xinghui...@chromium.org, chrome-gr...@chromium.org, dmurph+watch...@chromium.org, media-cro...@chromium.org, cwp-review...@google.com, kinuko+...@chromium.org, vasilii+watchlis...@chromium.org, jasonrobe...@google.com, shgar+aut...@google.com, jmedle...@chromium.org, dmurph+watchi...@chromium.org, bnc+...@chromium.org, lighthouse-eng-extern...@google.com, nicolas...@chromium.org, vakh+safe_br...@chromium.org, jonmann+wa...@chromium.org, hashimo...@chromium.org, johnche...@chromium.org, jackshira+wat...@google.com, katie...@chromium.org, cros-enterpris...@chromium.org, mac-r...@chromium.org, sloboda...@chromium.org, iclella...@chromium.org, kainin...@chromium.org, knollr+wat...@chromium.org, vsavu...@google.com, boujan...@google.com, cros-essential...@chromium.org, stanfie...@google.com, titoua...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, crmulli...@chromium.org, loyso...@chromium.org, croissant-...@chromium.org, rmcelra...@chromium.org, hansberry+w...@chromium.org, moqati-team+chr...@google.com, peilinwa...@google.com, nator...@chromium.org, dominicc+...@chromium.org, rhalava...@chromium.org, ajayramamurthy...@google.com, filesapp...@chromium.org, mfoltz+wa...@chromium.org, anastas...@google.com, chfreme...@chromium.org, ajayramamurthy...@google.com, andreaor...@chromium.org, droger+w...@chromium.org, khmel...@chromium.org, pushi+wat...@google.com, lucasrada...@google.com, aleventh...@chromium.org, jdonnel...@chromium.org, ffred...@chromium.org, jimmyxgong+watch...@chromium.org, keithle...@chromium.org, hansberry+wa...@chromium.org, ayman...@chromium.org, jiajunz+wa...@google.com, shimazu+se...@chromium.org, feature-me...@chromium.org, djacob...@chromium.org, tgupta...@chromium.org, torne...@chromium.org, lize...@chromium.org, enne...@chromium.org, ios-r...@chromium.org, armalhotra+a...@google.com, khorimoto+w...@chromium.org, jorgel...@chromium.org, oshima...@chromium.org, longbowei+watc...@google.com, servicewor...@chromium.org, ydago...@chromium.org, dullweb...@chromium.org, yongshun+...@google.com, gavinwill+watch-...@chromium.org, michaelcheco+...@google.com, kinuko+ser...@chromium.org, shimazu...@chromium.org, chlily...@chromium.org, srahim...@chromium.org, ddrone...@google.com, gangwu...@chromium.org, cros-print...@google.com, wnwen...@chromium.org, cc-...@chromium.org, toyosh...@chromium.org, dtraino...@chromium.org, twelling...@chromium.org, chromeos-gfx-...@google.com, bmcquad...@chromium.org, fmalit...@chromium.org, ajwong...@chromium.org, mgiuca...@chromium.org, gavin...@chromium.org, mpdento...@chromium.org, webap...@microsoft.com, jophba...@chromium.org, nona+...@chromium.org, wangdanny+watch-in...@google.com, max+watc...@igalia.com, crisrael+wa...@google.com, jimmyxgong+watch-shor...@chromium.org, weiluanw...@google.com, dmurph+watc...@chromium.org, yhanad...@chromium.org, hayato...@chromium.org, christia...@chromium.org, martijn...@martijnc.be, net-r...@chromium.org, steimel+...@chromium.org, telemetr...@chromium.org, dewitt...@chromium.org, chadduffin+w...@chromium.org, rsleev...@chromium.org, gbb-cct...@google.com, yigu+...@chromium.org, zackha...@chromium.org, jonman...@chromium.org, kouhe...@chromium.org, thefro...@chromium.org, ricea...@chromium.org, mfoltz+wa...@chromium.org, media-wi...@chromium.org, hsuregan+wa...@chromium.org, xlythe+wa...@google.com, lizeb+watch...@chromium.org, chromeos-kio...@google.com, hansenmichael...@google.com, gavinp...@chromium.org, ortuno+w...@chromium.org, jessemcke...@google.com, tommyw+w...@chromium.org, mattsimm...@chromium.org, core-timi...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, rayanka...@chromium.org, marinacio...@chromium.org, longbowei+watch-shor...@google.com, cbe-cep-eng...@google.com, hanxi...@chromium.org, yhanada+...@chromium.org, speed-metr...@chromium.org, kenjibah...@chromium.org, olka+...@chromium.org, jackshira+wa...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, bling-alchemy-eng+...@google.com, pasko...@chromium.org, chrome-intelligence-te...@google.com, permissio...@chromium.org, siyua+aut...@chromium.org, stevenj...@chromium.org, thegreenf...@chromium.org, mbarowsky+watc...@chromium.org, joeantonetti+...@google.com, subresource-f...@chromium.org, eic+...@google.com, gogeral...@chromium.org, mattreyno...@chromium.org, ananyasee...@google.com, ios-rev...@chromium.org, jdh+wa...@chromium.org, estali...@chromium.org, cblume...@chromium.org, stevenjb+wa...@chromium.org, shuche...@chromium.org, mercer...@google.com, fgal...@chromium.org, yyhyyh+watch-inpu...@google.com, cros-ed...@google.com, marq+...@chromium.org, print-revi...@chromium.org, gavinwill+sc...@chromium.org, dcheng+c...@chromium.org, lwinston+watc...@google.com, estaab...@chromium.org, vaapi-...@chromium.org, kmg+...@google.com, hirokisa...@chromium.org, tmartino+tran...@chromium.org, svend+w...@chromium.org, prerenderi...@chromium.org, davidj...@chromium.org, chrome-intell...@chromium.org, fuchsia...@chromium.org, twifka...@chromium.org, language...@chromium.org, sky+...@chromium.org, roblia...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, navigation...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org
Benjamin Beaudry added 6 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 18 (Latest):
Benjamin Beaudry . resolved
Moving back to WIP while I am addressing feedback.
File chrome/browser/metrics/accessibility_state_provider.h
Line 17, Patchset 16:
kUIAOnly = 0,Greg Thompson . resolved
Benjamin Beaudrynit: `kUiaOnly` as per https://google.github.io/styleguide/cppguide.html#General_Naming_Rules
Done
File chrome/browser/metrics/accessibility_state_provider_win_unittest.cc
Line 31, Patchset 16:
ui::AXPlatform::GetInstance().SetUiaClientServiced(false);
ui::AXPlatform::GetInstance().SetMsaaClientServiced(false);Greg Thompson . resolved
Benjamin Beaudrywhile clearing global state like this is generally good practice, it's not needed here since each unit test runs with a fresh `AXPlatform` (and `BrowserAccessibilityStateImpl`) instance; see https://source.chromium.org/chromium/chromium/src/+/main:content/public/test/unittest_test_suite.cc;drc=312782439223982369c690ecc3adab04453e6009;l=84
Done
Line 42, Patchset 16:
std::unique_ptr<AccessibilityStateProvider> provider_;Greg Thompson . resolved
Benjamin Beaudrydo we need `unique_ptr`, or can we just have `AccessibilityStateProvider provider_;` here? then we can remove `SetUp`.
Done
File tools/metrics/histograms/metadata/accessibility/histograms.xml
Line 3984, Patchset 16:
<histogram name="Accessibility.Win.ActiveClientAPIs.NativeAPIsOnly"Jonathan Ross . resolved
Benjamin BeaudryI'd recommend Patterned histograms for these two. https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#Patterned-Histograms
Good point! Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages