[resource coordinator] Remove LifecycleUnitStateChangeReason [chromium/src : main]

8 views
Skip to first unread message

Vovo Yang (Gerrit)

unread,
Oct 29, 2025, 11:42:56 PM (7 days ago) Oct 29
to Francois Pierre Doray, Chromium IPC Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromiumme...@microsoft.com, ipc-securi...@chromium.org
Attention needed from Chromium IPC Reviews and Francois Pierre Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Chromium IPC Reviews
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
Gerrit-Change-Number: 7099698
Gerrit-PatchSet: 1
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 03:42:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Oct 29, 2025, 11:47:32 PM (7 days ago) Oct 29
to Vovo Yang, Chromium IPC Reviews, Takashi Toyoshima, Francois Pierre Doray, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromiumme...@microsoft.com, ipc-securi...@chromium.org
Attention needed from Francois Pierre Doray and Takashi Toyoshima

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: toyo...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): toyo...@chromium.org


Reviewer source(s):
toyo...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
Gerrit-Change-Number: 7099698
Gerrit-PatchSet: 1
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 03:47:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Oct 30, 2025, 9:14:10 PM (6 days ago) Oct 30
to Vovo Yang, Chromium IPC Reviews, Takashi Toyoshima, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromiumme...@microsoft.com, ipc-securi...@chromium.org
Attention needed from Takashi Toyoshima and Vovo Yang

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

Code-Review+1

1 comment

File chrome/browser/resource_coordinator/lifecycle_unit_base.h
Line 48, Patchset 1 (Latest): // |reason| indicates what caused the state change.
Francois Pierre Doray . unresolved

remove this comment

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
  • Vovo Yang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
    Gerrit-Change-Number: 7099698
    Gerrit-PatchSet: 1
    Gerrit-Owner: Vovo Yang <vo...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Vovo Yang <vo...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Oct 2025 01:14:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vovo Yang (Gerrit)

    unread,
    Oct 30, 2025, 10:28:40 PM (6 days ago) Oct 30
    to Francois Pierre Doray, Chromium IPC Reviews, Takashi Toyoshima, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromiumme...@microsoft.com, ipc-securi...@chromium.org
    Attention needed from Takashi Toyoshima

    Vovo Yang voted and added 1 comment

    Votes added by Vovo Yang

    Commit-Queue+1

    1 comment

    File chrome/browser/resource_coordinator/lifecycle_unit_base.h
    Line 48, Patchset 1: // |reason| indicates what caused the state change.
    Francois Pierre Doray . resolved

    remove this comment

    Vovo Yang

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Takashi Toyoshima
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
      Gerrit-Change-Number: 7099698
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vovo Yang <vo...@chromium.org>
      Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Comment-Date: Fri, 31 Oct 2025 02:28:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Francois Pierre Doray <fdo...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Takashi Toyoshima (Gerrit)

      unread,
      Oct 31, 2025, 2:23:47 AM (6 days ago) Oct 31
      to Vovo Yang, Francois Pierre Doray, Chromium IPC Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromiumme...@microsoft.com, ipc-securi...@chromium.org
      Attention needed from Vovo Yang

      Takashi Toyoshima voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Vovo Yang
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
      Gerrit-Change-Number: 7099698
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vovo Yang <vo...@chromium.org>
      Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Vovo Yang <vo...@chromium.org>
      Gerrit-Comment-Date: Fri, 31 Oct 2025 06:23:12 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Vovo Yang (Gerrit)

      unread,
      Oct 31, 2025, 2:23:58 AM (6 days ago) Oct 31
      to Takashi Toyoshima, Francois Pierre Doray, Chromium IPC Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromiumme...@microsoft.com, ipc-securi...@chromium.org

      Vovo Yang voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
      Gerrit-Change-Number: 7099698
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vovo Yang <vo...@chromium.org>
      Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Comment-Date: Fri, 31 Oct 2025 06:23:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Oct 31, 2025, 2:28:03 AM (6 days ago) Oct 31
      to Vovo Yang, Takashi Toyoshima, Francois Pierre Doray, Chromium IPC Reviews, AyeAye, chromium...@chromium.org, asvitki...@chromium.org, chrome-gr...@chromium.org, chromiumme...@microsoft.com, ipc-securi...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [resource coordinator] Remove LifecycleUnitStateChangeReason
      Bug: 394889323
      Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
      Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
      Commit-Queue: Vovo Yang <vo...@chromium.org>
      Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1538394}
      Files:
      • M chrome/browser/metrics/tab_stats/tab_stats_tracker_unittest.cc
      • M chrome/browser/resource_coordinator/discard_metrics_lifecycle_unit_observer_unittest.cc
      • M chrome/browser/resource_coordinator/lifecycle_unit_base.cc
      • M chrome/browser/resource_coordinator/lifecycle_unit_base.h
      • M chrome/browser/resource_coordinator/lifecycle_unit_base_unittest.cc
      • M chrome/browser/resource_coordinator/lifecycle_unit_observer.h
      • M chrome/browser/resource_coordinator/lifecycle_unit_state.mojom
      • M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
      • M chrome/browser/resource_coordinator/tab_lifecycle_unit.h
      Change size: M
      Delta: 9 files changed, 27 insertions(+), 92 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Takashi Toyoshima, +1 by Francois Pierre Doray
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If06bcd10ef55a4553da52f1f0672e547474ca88b
      Gerrit-Change-Number: 7099698
      Gerrit-PatchSet: 3
      Gerrit-Owner: Vovo Yang <vo...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages