Reformat browser_process.h and browser_process_impl.cc. [chromium/src : main]

0 views
Skip to first unread message

Glenn Hartmann (Gerrit)

unread,
Dec 11, 2025, 11:32:25 AMDec 11
to Tom Lukaszewicz, AyeAye, chromium...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Attention needed from Tom Lukaszewicz

Glenn Hartmann voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83f77f0009ca8da786a812d086fefaa96a6a6964
Gerrit-Change-Number: 7238774
Gerrit-PatchSet: 5
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 16:32:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Lukaszewicz (Gerrit)

unread,
Dec 11, 2025, 12:26:45 PMDec 11
to Glenn Hartmann, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org
Attention needed from Glenn Hartmann

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Tom Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Glenn Hartmann
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83f77f0009ca8da786a812d086fefaa96a6a6964
Gerrit-Change-Number: 7238774
Gerrit-PatchSet: 5
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Glenn Hartmann <hart...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 17:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Glenn Hartmann (Gerrit)

unread,
Dec 11, 2025, 1:04:03 PMDec 11
to Tom Lukaszewicz, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org

Glenn Hartmann voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83f77f0009ca8da786a812d086fefaa96a6a6964
Gerrit-Change-Number: 7238774
Gerrit-PatchSet: 5
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 18:03:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 11, 2025, 1:06:57 PMDec 11
to Glenn Hartmann, Tom Lukaszewicz, AyeAye, chromium...@chromium.org, chrome-gr...@chromium.org, rginda...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Reformat browser_process.h and browser_process_impl.cc.

This is just to make
https://chromium-review.googlesource.com/c/chromium/src/+/7238775 nicer.
Bug: 467395900
Change-Id: I83f77f0009ca8da786a812d086fefaa96a6a6964
Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
Commit-Queue: Glenn Hartmann <hart...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557504}
Files:
  • M chrome/browser/browser_process.h
  • M chrome/browser/browser_process_impl.cc
Change size: M
Delta: 2 files changed, 75 insertions(+), 47 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tom Lukaszewicz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83f77f0009ca8da786a812d086fefaa96a6a6964
Gerrit-Change-Number: 7238774
Gerrit-PatchSet: 6
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages