[bedrock] Eliminate BrowserList from SessionRestorePolicy [chromium/src : main]

0 views
Skip to first unread message

Tom Lukaszewicz (Gerrit)

unread,
Sep 4, 2025, 9:24:57 PMSep 4
to Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Patrick Monette

Tom Lukaszewicz added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tom Lukaszewicz . resolved

Patrick ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Monette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fdce977a3c4b7e62372ae8452fabe47cfca7fc9
Gerrit-Change-Number: 6916641
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 01:24:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Monette (Gerrit)

unread,
Sep 5, 2025, 12:03:04 PMSep 5
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Tom Lukaszewicz

Patrick Monette voted and added 1 comment

Votes added by Patrick Monette

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Patrick Monette . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fdce977a3c4b7e62372ae8452fabe47cfca7fc9
Gerrit-Change-Number: 6916641
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 16:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Lukaszewicz (Gerrit)

unread,
Sep 7, 2025, 2:34:26 PMSep 7
to Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Tom Lukaszewicz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fdce977a3c4b7e62372ae8452fabe47cfca7fc9
Gerrit-Change-Number: 6916641
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Sun, 07 Sep 2025 18:33:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 7, 2025, 3:11:29 PMSep 7
to Tom Lukaszewicz, Patrick Monette, chromium...@chromium.org, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[bedrock] Eliminate BrowserList from SessionRestorePolicy

Eliminates use of the deprecated BrowserList API and migrates code
to the approprirate browser_window_interface_iterator API
ForEachCurrentBrowserWindowInterfaceOrderedByActivation().
Bug: 431672609
Change-Id: I3fdce977a3c4b7e62372ae8452fabe47cfca7fc9
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Reviewed-by: Patrick Monette <pmon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1512175}
Files:
  • M chrome/browser/resource_coordinator/session_restore_policy.cc
Change size: S
Delta: 1 file changed, 13 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Patrick Monette
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fdce977a3c4b7e62372ae8452fabe47cfca7fc9
Gerrit-Change-Number: 6916641
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages