Switch performance_manager to use ByteCount [chromium/src : main]

2 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
Aug 16, 2025, 5:45:46 PMAug 16
to Avi Drissman, Katie Dektar, Eshwar Stalin, Ryan Sturm, Chromium IPC Reviews, Michal Mocny, Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Chromium IPC Reviews, Eshwar Stalin, Francois Pierre Doray, Katie Dektar, Michal Mocny and Ryan Sturm

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Avi Drissman . resolved

fdoray: overall
katie: chrome/browser/screen_ai
eshwar: performance_controls
ryan: page_load_metrics
IPC reviewer: mojom
michal: blink

Open in Gerrit

Related details

Attention is currently required from:
  • Chromium IPC Reviews
  • Eshwar Stalin
  • Francois Pierre Doray
  • Katie Dektar
  • Michal Mocny
  • Ryan Sturm
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I36b6f9c35ad17ac1081f2393de0fa477073a04b9
Gerrit-Change-Number: 6855040
Gerrit-PatchSet: 8
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Katie Dektar <ka...@chromium.org>
Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
Gerrit-Attention: Ryan Sturm <ryan...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Attention: Katie Dektar <ka...@chromium.org>
Gerrit-Comment-Date: Sat, 16 Aug 2025 21:45:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Aug 16, 2025, 5:49:43 PMAug 16
to Avi Drissman, Chromium IPC Reviews, Dominic Farolino, Katie Dektar, Eshwar Stalin, Ryan Sturm, Michal Mocny, Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Dominic Farolino, Eshwar Stalin, Francois Pierre Doray, Katie Dektar, Michal Mocny and Ryan Sturm

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: d...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): d...@chromium.org


Reviewer source(s):
d...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Eshwar Stalin
  • Francois Pierre Doray
  • Katie Dektar
  • Michal Mocny
  • Ryan Sturm
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I36b6f9c35ad17ac1081f2393de0fa477073a04b9
Gerrit-Change-Number: 6855040
Gerrit-PatchSet: 8
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Katie Dektar <ka...@chromium.org>
Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
Gerrit-Attention: Ryan Sturm <ryan...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Katie Dektar <ka...@chromium.org>
Gerrit-Comment-Date: Sat, 16 Aug 2025 21:49:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Katie Dektar (Gerrit)

unread,
Aug 18, 2025, 12:40:59 PMAug 18
to Avi Drissman, Chromium IPC Reviews, Dominic Farolino, Eshwar Stalin, Ryan Sturm, Michal Mocny, Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Avi Drissman, Dominic Farolino, Eshwar Stalin, Francois Pierre Doray, Michal Mocny and Ryan Sturm

Katie Dektar voted and added 1 comment

Votes added by Katie Dektar

Code-Review+1

1 comment

Patchset-level comments
Katie Dektar . resolved

chrome/browser/screen_ai/resource_monitor files LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Dominic Farolino
  • Eshwar Stalin
  • Francois Pierre Doray
  • Michal Mocny
  • Ryan Sturm
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36b6f9c35ad17ac1081f2393de0fa477073a04b9
    Gerrit-Change-Number: 6855040
    Gerrit-PatchSet: 8
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Katie Dektar <ka...@chromium.org>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Attention: Ryan Sturm <ryan...@chromium.org>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 16:40:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dominic Farolino (Gerrit)

    unread,
    Aug 18, 2025, 1:18:47 PMAug 18
    to Avi Drissman, Katie Dektar, Chromium IPC Reviews, Eshwar Stalin, Ryan Sturm, Michal Mocny, Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Avi Drissman, Eshwar Stalin, Francois Pierre Doray, Michal Mocny and Ryan Sturm

    Dominic Farolino voted and added 1 comment

    Votes added by Dominic Farolino

    Code-Review+1

    1 comment

    Patchset-level comments
    Dominic Farolino . resolved

    mojom and the Blink changes that I own lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    Gerrit-Comment-Date: Mon, 18 Aug 2025 17:18:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ryan Sturm (Gerrit)

    unread,
    Aug 18, 2025, 3:48:23 PMAug 18
    to Avi Drissman, Dominic Farolino, Katie Dektar, Chromium IPC Reviews, Eshwar Stalin, Michal Mocny, Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Avi Drissman, Eshwar Stalin, Francois Pierre Doray and Michal Mocny

    Ryan Sturm voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Eshwar Stalin
    • Francois Pierre Doray
    • Michal Mocny
    Gerrit-Comment-Date: Mon, 18 Aug 2025 19:48:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Francois Pierre Doray (Gerrit)

    unread,
    Aug 18, 2025, 4:56:57 PMAug 18
    to Avi Drissman, Ryan Sturm, Dominic Farolino, Katie Dektar, Chromium IPC Reviews, Eshwar Stalin, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Avi Drissman, Eshwar Stalin and Michal Mocny

    Francois Pierre Doray voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Eshwar Stalin
    • Michal Mocny
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36b6f9c35ad17ac1081f2393de0fa477073a04b9
    Gerrit-Change-Number: 6855040
    Gerrit-PatchSet: 9
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Katie Dektar <ka...@chromium.org>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 20:56:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Aug 18, 2025, 5:02:35 PMAug 18
    to Avi Drissman, Steven Luong, Francois Pierre Doray, Ryan Sturm, Dominic Farolino, Katie Dektar, Chromium IPC Reviews, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Michal Mocny and Steven Luong

    Avi Drissman added 1 comment

    Patchset-level comments
    File-level comment, Patchset 9 (Latest):
    Avi Drissman . resolved

    → stluong for performance_controls

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michal Mocny
    • Steven Luong
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36b6f9c35ad17ac1081f2393de0fa477073a04b9
    Gerrit-Change-Number: 6855040
    Gerrit-PatchSet: 9
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Katie Dektar <ka...@chromium.org>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
    Gerrit-Reviewer: Steven Luong <stl...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Attention: Steven Luong <stl...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 21:02:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Steven Luong (Gerrit)

    unread,
    Aug 18, 2025, 5:30:57 PMAug 18
    to Avi Drissman, Francois Pierre Doray, Ryan Sturm, Dominic Farolino, Katie Dektar, Chromium IPC Reviews, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Avi Drissman and Michal Mocny

    Steven Luong voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Michal Mocny
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 21:30:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Aug 18, 2025, 5:31:39 PMAug 18
    to Avi Drissman, Steven Luong, Francois Pierre Doray, Ryan Sturm, Dominic Farolino, Katie Dektar, Chromium IPC Reviews, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Michal Mocny

    Avi Drissman voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michal Mocny
    Gerrit-Comment-Date: Mon, 18 Aug 2025 21:31:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 18, 2025, 6:19:51 PMAug 18
    to Avi Drissman, Steven Luong, Francois Pierre Doray, Ryan Sturm, Dominic Farolino, Katie Dektar, Chromium IPC Reviews, Michal Mocny, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, core-timi...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Switch performance_manager to use ByteCount

    base::ByteCount is a class to make bytes manipulations type safe,
    easier to read and less error-prone.
    Bug: 429140103
    Change-Id: I36b6f9c35ad17ac1081f2393de0fa477073a04b9
    Reviewed-by: Dominic Farolino <d...@chromium.org>
    Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
    Reviewed-by: Steven Luong <stl...@chromium.org>
    Reviewed-by: Katie Dektar <ka...@chromium.org>
    Reviewed-by: Ryan Sturm <ryan...@chromium.org>
    Commit-Queue: Avi Drissman <a...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1502994}
    Files:
    • M chrome/browser/memory/enterprise_memory_limit_evaluator.cc
    • M chrome/browser/performance_manager/chrome_browser_main_extra_parts_performance_manager.cc
    • M chrome/browser/performance_manager/mechanisms/page_discarder.cc
    • M chrome/browser/performance_manager/mechanisms/page_discarder.h
    • M chrome/browser/performance_manager/mechanisms/page_discarder_browsertest.cc
    • M chrome/browser/performance_manager/mechanisms/userspace_swap_chromeos.cc
    • M chrome/browser/performance_manager/mechanisms/userspace_swap_chromeos.h
    • M chrome/browser/performance_manager/metrics/metrics_provider_desktop.cc
    • M chrome/browser/performance_manager/metrics/metrics_provider_desktop.h
    • M chrome/browser/performance_manager/policies/page_discarding_helper.cc
    • M chrome/browser/performance_manager/policies/page_discarding_helper_unittest.cc
    • M chrome/browser/performance_manager/policies/termination_target_policy.cc
    • M chrome/browser/performance_manager/policies/termination_target_policy_unittest.cc
    • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos.cc
    • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos.h
    • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos_unittest.cc
    • M chrome/browser/performance_manager/public/user_tuning/user_performance_tuning_manager.h
    • M chrome/browser/performance_manager/public/user_tuning/user_tuning_utils.h
    • M chrome/browser/performance_manager/test_support/page_discarding_utils.cc
    • M chrome/browser/performance_manager/test_support/page_discarding_utils.h
    • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_manager.cc
    • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_notifier.cc
    • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_notifier.h
    • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_notifier_unittest.cc
    • M chrome/browser/performance_manager/user_tuning/user_tuning_utils.cc
    • M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • M chrome/browser/resource_coordinator/tab_lifecycle_unit.h
    • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
    • M chrome/browser/screen_ai/resource_monitor.cc
    • M chrome/browser/screen_ai/resource_monitor.h
    • M chrome/browser/screen_ai/screen_ai_service_handler_base.cc
    • M chrome/browser/ui/performance_controls/memory_saver_utils.cc
    • M chrome/browser/ui/performance_controls/tab_resource_usage_collector.cc
    • M chrome/browser/ui/views/performance_controls/memory_saver_interactive_ui_test.cc
    • M chrome/browser/ui/views/performance_controls/test_support/memory_saver_unit_test_mixin.h
    • M chrome/browser/ui/webui/discards/graph_dump_impl.cc
    • M chrome/browser/ui/webui/discards/site_data_provider_impl.cc
    • M components/page_load_metrics/browser/page_load_metrics_memory_tracker.cc
    • M components/page_load_metrics/browser/page_load_metrics_memory_tracker_unittest.cc
    • M components/performance_manager/decorators/process_metrics_decorator.cc
    • M components/performance_manager/decorators/process_metrics_decorator_unittest.cc
    • M components/performance_manager/decorators/site_data_recorder_unittest.cc
    • M components/performance_manager/freezing/freezing_policy.cc
    • M components/performance_manager/freezing/freezing_policy.h
    • M components/performance_manager/freezing/freezing_policy_unittest.cc
    • M components/performance_manager/graph/frame_node_impl.cc
    • M components/performance_manager/graph/frame_node_impl.h
    • M components/performance_manager/graph/frame_node_impl_describer.cc
    • M components/performance_manager/graph/page_node_impl.cc
    • M components/performance_manager/graph/page_node_impl.h
    • M components/performance_manager/graph/page_node_impl_describer.cc
    • M components/performance_manager/graph/process_node_impl.cc
    • M components/performance_manager/graph/process_node_impl.h
    • M components/performance_manager/graph/process_node_impl_describer.cc
    • M components/performance_manager/graph/process_node_impl_unittest.cc
    • M components/performance_manager/graph/worker_node_impl.cc
    • M components/performance_manager/graph/worker_node_impl.h
    • M components/performance_manager/graph/worker_node_impl_describer.cc
    • M components/performance_manager/metrics/page_resource_monitor.cc
    • M components/performance_manager/metrics/page_resource_monitor_unittest.cc
    • M components/performance_manager/persistence/site_data/leveldb_site_data_store.cc
    • M components/performance_manager/persistence/site_data/leveldb_site_data_store_unittest.cc
    • M components/performance_manager/persistence/site_data/noop_site_data_writer.cc
    • M components/performance_manager/persistence/site_data/noop_site_data_writer.h
    • M components/performance_manager/persistence/site_data/site_data_cache_inspector.h
    • M components/performance_manager/persistence/site_data/site_data_impl.cc
    • M components/performance_manager/persistence/site_data/site_data_impl.h
    • M components/performance_manager/persistence/site_data/site_data_impl_unittest.cc
    • M components/performance_manager/persistence/site_data/site_data_store.h
    • M components/performance_manager/persistence/site_data/site_data_writer.cc
    • M components/performance_manager/persistence/site_data/site_data_writer.h
    • M components/performance_manager/persistence/site_data/site_data_writer_unittest.cc
    • M components/performance_manager/public/graph/frame_node.h
    • M components/performance_manager/public/graph/page_node.h
    • M components/performance_manager/public/graph/process_node.h
    • M components/performance_manager/public/graph/worker_node.h
    • M components/performance_manager/public/mojom/web_memory.mojom
    • M components/performance_manager/public/resource_attribution/memory_measurement_delegate.h
    • M components/performance_manager/public/resource_attribution/query_results.h
    • M components/performance_manager/public/v8_memory/v8_detailed_memory.h
    • M components/performance_manager/resource_attribution/memory_measurement_delegate.cc
    • M components/performance_manager/resource_attribution/memory_measurement_provider.cc
    • M components/performance_manager/resource_attribution/memory_measurement_provider_browsertest.cc
    • M components/performance_manager/resource_attribution/queries_unittest.cc
    • M components/performance_manager/resource_attribution/query_scheduler_unittest.cc
    • M components/performance_manager/test_support/resource_attribution/gtest_util.h
    • M components/performance_manager/v8_memory/v8_detailed_memory_decorator.cc
    • M components/performance_manager/v8_memory/v8_detailed_memory_unittest.cc
    • M components/performance_manager/v8_memory/v8_memory_test_helpers.cc
    • M components/performance_manager/v8_memory/v8_memory_test_helpers.h
    • M components/performance_manager/v8_memory/web_memory_aggregator.cc
    • M components/performance_manager/v8_memory/web_memory_aggregator_unittest.cc
    • M components/performance_manager/v8_memory/web_memory_impl_unittest.cc
    • M third_party/blink/public/mojom/performance_manager/v8_detailed_memory_reporter.mojom
    • M third_party/blink/renderer/controller/performance_manager/v8_detailed_memory_reporter_impl.cc
    • M third_party/blink/renderer/controller/performance_manager/v8_detailed_memory_reporter_impl_test.cc
    • M third_party/blink/renderer/controller/performance_manager/v8_worker_memory_reporter.cc
    • M third_party/blink/renderer/controller/performance_manager/v8_worker_memory_reporter.h
    • M third_party/blink/renderer/controller/performance_manager/v8_worker_memory_reporter_test.cc
    • M third_party/blink/renderer/core/timing/measure_memory/local_web_memory_measurer.cc
    • M third_party/blink/renderer/core/timing/measure_memory/measure_memory_controller.cc
    Change size: XL
    Delta: 101 files changed, 1436 insertions(+), 1291 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Katie Dektar, +1 by Francois Pierre Doray, +1 by Dominic Farolino, +1 by Steven Luong, +1 by Ryan Sturm
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I36b6f9c35ad17ac1081f2393de0fa477073a04b9
    Gerrit-Change-Number: 6855040
    Gerrit-PatchSet: 10
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Katie Dektar <ka...@chromium.org>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
    Gerrit-Reviewer: Steven Luong <stl...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages