Remove superfluous chrome/common/chrome_features.h includes [chromium/src : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

Feb 13, 2026, 9:38:34 PM (7 days ago) Feb 13

to Lei Zhang, Avi Drissman, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Simon Hangl, aashna...@google.com, aixba+wat...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crost...@chromium.org, csharris...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, kenok...@google.com, khorimoto+w...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, stluon...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Avi Drissman

Lei Zhang voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Feb 13, 2026, 9:45:35 PM (7 days ago) Feb 13

Attention needed from Avi Drissman

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Lei Zhang . resolved

Please also OO+1 for chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc.

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Feb 17, 2026, 11:21:45 AM (3 days ago) Feb 17

Attention needed from Lei Zhang

Avi Drissman voted

Code-Review	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

2:36 PM (3 hours ago) 2:36 PM

to Lei Zhang, Yao Xiao, Josh Karlin, AyeAye, Avi Drissman, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Simon Hangl, aashna...@google.com, aixba+wat...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crost...@chromium.org, csharris...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, kenok...@google.com, khorimoto+w...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, stluon...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Avi Drissman

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Lei Zhang . resolved

Should be all green now. I ran extra try bots.

chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc needs OO+1 here too.

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rebekah Potter (Gerrit)

unread,

2:41 PM (3 hours ago) 2:41 PM

Attention needed from Avi Drissman and Lei Zhang

Rebekah Potter voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Lei Zhang

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Rebekah Potter (Gerrit)

unread,

2:42 PM (3 hours ago) 2:42 PM

Attention needed from Avi Drissman and Lei Zhang

Rebekah Potter added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Lei Zhang . resolved

Should be all green now. I ran extra try bots.
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc needs OO+1 here too.

Rebekah Potter

I was auto cc-ed on this, so reviewed/LGed for chrome_web_ui_controller_factory.cc

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

4:43 PM (1 hour ago) 4:43 PM

to Lei Zhang, Rebekah Potter, Yao Xiao, Josh Karlin, AyeAye, Avi Drissman, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Simon Hangl, aashna...@google.com, aixba+wat...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crost...@chromium.org, csharris...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, kenok...@google.com, khorimoto+w...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, stluon...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Avi Drissman

Lei Zhang voted and added 2 comments

Votes added by Lei Zhang

Commit-Queue

2 comments

Patchset-level comments

File-level comment, Patchset 2:

Lei Zhang . resolved

Please also OO+1 for chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc.

Lei Zhang

No longer needs OO+1.

File-level comment, Patchset 3 (Latest):

Lei Zhang . resolved

Should be all green now. I ran extra try bots.
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc needs OO+1 here too.

Rebekah Potter

I was auto cc-ed on this, so reviewed/LGed for chrome_web_ui_controller_factory.cc

Lei Zhang

Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

4:51 PM (1 hour ago) 4:51 PM

to Lei Zhang, Rebekah Potter, Yao Xiao, Josh Karlin, AyeAye, Avi Drissman, Christian Biesinger, chromium...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Simon Hangl, aashna...@google.com, aixba+wat...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crost...@chromium.org, csharris...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, kenok...@google.com, khorimoto+w...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, nicolas...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, stevenjb+wa...@chromium.org, stluon...@chromium.org, subresource-f...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove superfluous chrome/common/chrome_features.h includes

Since chrome_features.h wraps everything in namespace features, the lack
of "features::" is a strong signal that a file does not need to include
chrome_features.h. Cleanup these superfluous includes and do IWYU to fix
the build.

Bug: 40318405

Change-Id: Ifa9682e987987de348b6bc78b457f25a68a57c86

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7573056

Auto-Submit: Lei Zhang <the...@chromium.org>

Reviewed-by: Rebekah Potter <rbpo...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1588081}

Files:

M chrome/browser/actor/actor_keyed_service.cc
M chrome/browser/actor/tools/attempt_form_filling_tool_browsertest.cc
M chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble.cc
M chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_controller.cc
M chrome/browser/actor/ui/task_list_bubble/actor_task_list_bubble_row_button.cc
M chrome/browser/ai/ai_data_keyed_service_browsertest.cc
M chrome/browser/android/tab_android.cc
M chrome/browser/app_controller_mac_unittest.mm
M chrome/browser/apps/app_preload_service/app_preload_service_browsertest.cc
M chrome/browser/apps/app_preload_service/app_preload_service_factory.cc
M chrome/browser/apps/app_preload_service/app_preload_service_unittest.cc
M chrome/browser/apps/app_service/app_icon/app_icon_factory_unittest.cc
M chrome/browser/apps/app_service/app_icon/web_app_icon_unittest.cc
M chrome/browser/apps/app_service/notifications_browsertest.cc
M chrome/browser/apps/app_service/publishers/arc_apps.cc
M chrome/browser/apps/app_service/publishers/extension_apps_chromeos.cc
M chrome/browser/apps/app_service/publishers/publisher_unittest.cc
M chrome/browser/ash/app_list/app_service/app_service_app_model_builder_unittest.cc
M chrome/browser/ash/app_list/arc/arc_app_list_prefs.cc
M chrome/browser/ash/app_restore/arc_window_utils.cc
M chrome/browser/ash/child_accounts/parent_access_code/parent_access_service.cc
M chrome/browser/ash/child_accounts/time_limits/app_time_browsertest.cc
M chrome/browser/ash/child_accounts/time_limits/app_time_controller_unittest.cc
M chrome/browser/ash/crosapi/browser_manager.cc
M chrome/browser/ash/file_manager/file_manager_browsertest.cc
M chrome/browser/ash/file_manager/file_tasks.cc
M chrome/browser/ash/file_manager/open_with_browser_browsertest.cc
M chrome/browser/ash/hats/hats_finch_helper.cc
M chrome/browser/ash/hats/hats_finch_helper.h
M chrome/browser/ash/login/webview_login_browsertest.cc
M chrome/browser/ash/policy/core/browser_policy_connector_ash.cc
M chrome/browser/ash/policy/skyvault/drive_skyvault_uploader.cc
M chrome/browser/ash/policy/uploading/system_log_uploader.cc
M chrome/browser/ash/policy/uploading/system_log_uploader_unittest.cc
M chrome/browser/ash/preferences/preferences.cc
M chrome/browser/ash/system_web_apps/system_web_app_manager_factory.cc
M chrome/browser/background/glic/glic_controller.cc
M chrome/browser/background/glic/glic_launcher_configuration_unittest.cc
M chrome/browser/banners/android/chrome_app_banner_manager_android.cc
M chrome/browser/banners/app_banner_manager_desktop_browsertest.cc
M chrome/browser/component_updater/cros_component_installer_chromeos.cc
M chrome/browser/component_updater/registration.cc
M chrome/browser/content_settings/content_settings_browsertest.cc
M chrome/browser/contextual_cueing/contextual_cueing_helper_unittest.cc
M chrome/browser/download/download_target_determiner.cc
M chrome/browser/enterprise/watermark/watermark_browsertest.cc
M chrome/browser/extensions/api/crash_report_private/crash_report_private_apitest.cc
M chrome/browser/extensions/api/developer_private/extension_info_generator.cc
M chrome/browser/extensions/api/identity/identity_apitest.cc
M chrome/browser/extensions/api/management/chrome_management_api_delegate_nonandroid.cc
M chrome/browser/extensions/api/quick_unlock_private/quick_unlock_private_api_unittest.cc
M chrome/browser/extensions/api/settings_private/prefs_util.cc
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
M chrome/browser/extensions/chrome_app_sorting.cc
M chrome/browser/extensions/external_provider_manager.cc
M chrome/browser/glic/browser_ui/context_sharing_border_view_controller_impl.h
M chrome/browser/glic/browser_ui/tab_underline_view_controller_impl.h
M chrome/browser/glic/glic_navigation_throttle_browsertest.cc
M chrome/browser/glic/glic_occlusion_notifier.cc
M chrome/browser/glic/host/context/glic_tab_data_browsertest.cc
M chrome/browser/glic/host/context/glic_tab_data_observer.cc
M chrome/browser/glic/host/glic_actor_drag_and_release_tool_interactive_uitest.cc
M chrome/browser/glic/host/glic_actor_scroll_tool_interactive_uitest.cc
M chrome/browser/glic/host/glic_actor_task_management_interactive_uitest.cc
M chrome/browser/glic/host/guest_util_browsertest.cc
M chrome/browser/glic/test_support/glic_test_environment.h
M chrome/browser/glic/widget/glic_window_resize_animation.cc
M chrome/browser/global_features.cc
M chrome/browser/hid/chrome_hid_delegate_unittest.cc
M chrome/browser/hid/hid_browsertest.cc
M chrome/browser/interstitials/security_interstitial_page_test_utils.cc
M chrome/browser/media/webrtc/desktop_capture_access_handler.cc
M chrome/browser/media/webrtc/webrtc_event_log_manager.cc
M chrome/browser/metrics/chromeos_metrics_provider.cc
M chrome/browser/notifications/mac/mac_notification_provider_factory.cc
M chrome/browser/notifications/mac/notification_platform_bridge_mac.cc
M chrome/browser/notifications/mac/notification_utils.cc
M chrome/browser/notifications/platform_notification_service_unittest.cc
M chrome/browser/notifications/win/notification_template_builder.cc
M chrome/browser/notifications/win/notification_template_builder_unittest.cc
M chrome/browser/ntp_tiles/ntp_tiles_browsertest.cc
M chrome/browser/page_load_metrics/observers/ad_metrics/ad_density_intervention_android_browsertest.cc
M chrome/browser/performance_manager/policies/discard_eligibility_policy.cc
M chrome/browser/permissions/pref_based_quiet_permission_ui_selector.cc
M chrome/browser/permissions/quiet_notification_permission_ui_state.cc
M chrome/browser/permissions/system/system_permission_settings_mac.cc
M chrome/browser/plugins/pdf_iframe_navigation_throttle.cc
M chrome/browser/policy/extension_policy_browsertest.cc
M chrome/browser/policy/test/restore_on_startup_policy_browsertest.cc
M chrome/browser/prefs/chrome_pref_service_factory.cc
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc
M chrome/browser/resource_coordinator/tab_manager.cc
M chrome/browser/shortcuts/shortcut_creator_win_unittest.cc
M chrome/browser/signin/dice_browsertest.cc
M chrome/browser/ssl/chrome_security_state_tab_helper.cc
M chrome/browser/ssl/ssl_browsertest_util.cc
M chrome/browser/subresource_filter/ruleset_browsertest.cc
M chrome/browser/supervised_user/supervised_user_regional_url_filter_browsertest.cc
M chrome/browser/sync/test/integration/web_apps/single_client_web_apps_sync_test.cc
M chrome/browser/themes/theme_helper.cc
M chrome/browser/ui/ash/projector/projector_navigation_throttle_browsertest.cc
M chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc
M chrome/browser/ui/ash/sharesheet/sharesheet_header_view.cc
M chrome/browser/ui/ash/shelf/app_service/app_service_app_window_crostini_tracker.cc
M chrome/browser/ui/ash/shelf/app_service/app_service_app_window_shelf_controller.cc
M chrome/browser/ui/ash/shelf/browser_status_monitor.cc
M chrome/browser/ui/browser_command_controller_browsertest.cc
M chrome/browser/ui/browser_command_controller_unittest.cc
M chrome/browser/ui/browser_tab_strip_model_delegate.h
M chrome/browser/ui/layout_constants.cc
M chrome/browser/ui/omnibox/omnibox_pedal_implementations.cc
M chrome/browser/ui/safety_hub/extensions_result.cc
M chrome/browser/ui/safety_hub/menu_notification_service_factory.cc
M chrome/browser/ui/safety_hub/notification_permission_review_service_factory.cc
M chrome/browser/ui/safety_hub/password_status_check_service_factory.cc
M chrome/browser/ui/safety_hub/revoked_permissions_service_factory.cc
M chrome/browser/ui/safety_hub/safety_hub_hats_service.cc
M chrome/browser/ui/search/search_tab_helper.cc
M chrome/browser/ui/startup/startup_tab_provider.cc
M chrome/browser/ui/startup/web_app_startup_utils.cc
M chrome/browser/ui/tabs/alert/tab_alert_controller_unittest.cc
M chrome/browser/ui/tabs/alert/tab_alert_icon.cc
M chrome/browser/ui/tabs/tab_strip_model.h
M chrome/browser/ui/tabs/tab_strip_model_delegate.h
M chrome/browser/ui/tabs/test_tab_strip_model_delegate.h
M chrome/browser/ui/toolbar/back_forward_menu_model.cc
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc
M chrome/browser/ui/toolbar/pinned_toolbar/tab_search_toolbar_button_controller.cc
M chrome/browser/ui/unload_controller_browsertest.cc
M chrome/browser/ui/url_identity_unittest.cc
M chrome/browser/ui/views/apps/app_dialog/app_uninstall_dialog_view.cc
M chrome/browser/ui/views/crostini/crostini_dialogue_browser_test_util.cc
M chrome/browser/ui/views/enable_link_capturing_infobar_browsertest.cc
M chrome/browser/ui/views/frame/browser_view_browsertest.cc
M chrome/browser/ui/views/frame/horizontal_tab_strip_region_view_interactive_uitest.cc
M chrome/browser/ui/views/frame/system_menu_model_builder_browsertest.cc
M chrome/browser/ui/views/hats/hats_browsertest.cc
M chrome/browser/ui/views/location_bar/content_setting_image_view_interactive_uitest.cc
M chrome/browser/ui/views/location_bar/intent_picker_view.cc
M chrome/browser/ui/views/location_bar/merchant_trust_chip_button_interactive_uitest.cc
M chrome/browser/ui/views/media_preview/permission_prompt_preview_browsertest.cc
M chrome/browser/ui/views/omnibox/omnibox_popup_view_views_browsertest.cc
M chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc
M chrome/browser/ui/views/permissions/permission_prompt_factory.cc
M chrome/browser/ui/views/profiles/dice_web_signin_interception_bubble_view_browsertest.cc
M chrome/browser/ui/views/profiles/dice_web_signin_interception_bubble_view_pixel_browsertest.cc
M chrome/browser/ui/views/profiles/profiles_pixel_test_utils.cc
M chrome/browser/ui/views/side_panel/side_panel_util.cc
M chrome/browser/ui/views/status_icons/status_tray_chromeos.cc
M chrome/browser/ui/views/tab_search_bubble_host.cc
M chrome/browser/ui/views/tabs/glic/glic_actor_task_icon.cc
M chrome/browser/ui/views/tabs/glic/glic_and_actor_buttons_container.cc
M chrome/browser/ui/views/tabs/tab_search_button.cc
M chrome/browser/ui/views/tabs/tab_strip_control_button.cc
M chrome/browser/ui/views/tabs/tab_unittest.cc
M chrome/browser/ui/views/toolbar/pinned_toolbar_actions_container.cc
M chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
M chrome/browser/ui/views/web_apps/deprecated_apps_dialog_view.cc
M chrome/browser/ui/views/web_apps/force_installed_deprecated_apps_dialog_view.cc
M chrome/browser/ui/views/web_apps/force_installed_preinstalled_deprecated_app_dialog_view.cc
M chrome/browser/ui/views/web_apps/simple_install_dialog_bubble_view_browsertest.cc
M chrome/browser/ui/views/web_apps/web_app_detailed_install_dialog.cc
M chrome/browser/ui/views/web_apps/web_app_diy_install_dialog.cc
M chrome/browser/ui/views/web_apps/web_app_install_not_supported_dialog.cc
M chrome/browser/ui/views/web_apps/web_app_integration_browsertest.cc
M chrome/browser/ui/views/web_apps/web_app_launch_dialog.cc
M chrome/browser/ui/views/web_apps/web_app_simple_install_dialog.cc
M chrome/browser/ui/web_applications/web_app_dialog_utils.cc
M chrome/browser/ui/webid/identity_dialog_controller_browsertest.cc
M chrome/browser/ui/webui/about/about_ui.cc
M chrome/browser/ui/webui/actor_internals/actor_internals_ui.cc
M chrome/browser/ui/webui/actor_internals/actor_internals_ui.h
M chrome/browser/ui/webui/app_settings/web_app_settings_navigation_throttle.cc
M chrome/browser/ui/webui/ash/lock_screen_reauth/lock_screen_reauth_handler.cc
M chrome/browser/ui/webui/ash/network_ui/onc_import_message_handler.cc
M chrome/browser/ui/webui/ash/settings/pages/main/main_section.cc
M chrome/browser/ui/webui/ash/settings/pages/printing/cups_printers_handler.cc
M chrome/browser/ui/webui/ash/settings/pages/printing/printing_section.cc
M chrome/browser/ui/webui/ash/settings/pages/privacy/privacy_hub_handler.cc
M chrome/browser/ui/webui/ash/settings/pages/storage/device_storage_handler_unittest.cc
M chrome/browser/ui/webui/certificate_manager/certificate_manager_handler.cc
M chrome/browser/ui/webui/certificate_manager/certificate_manager_ui.cc
M chrome/browser/ui/webui/certificate_manager/enterprise_cert_sources.cc
M chrome/browser/ui/webui/certificate_manager/user_cert_sources.cc
M chrome/browser/ui/webui/certificate_manager/user_cert_sources_unittest.cc
M chrome/browser/ui/webui/chrome_urls/chrome_urls_ui.cc
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
M chrome/browser/ui/webui/ntp/new_tab_ui.cc
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
M chrome/browser/ui/webui/settings/safety_hub_handler.cc
M chrome/browser/ui/webui/support_tool/support_tool_ui.cc
M chrome/browser/ui/webui/support_tool/support_tool_ui_browsertest.cc
M chrome/browser/ui/webui/whats_new/whats_new_ui.cc
M chrome/browser/usb/chrome_usb_browsertest.cc
M chrome/browser/usb/chrome_usb_delegate_unittest.cc
M chrome/browser/web_applications/commands/external_app_resolution_command.cc
M chrome/browser/web_applications/commands/fetch_install_info_from_install_url_command.cc
M chrome/browser/web_applications/commands/fetch_manifest_and_install_command.cc
M chrome/browser/web_applications/commands/fetch_manifest_and_install_command_browsertest.cc
M chrome/browser/web_applications/commands/generated_icon_fix_command.cc
M chrome/browser/web_applications/commands/install_app_locally_command.cc
M chrome/browser/web_applications/commands/install_app_locally_command_unittest.cc
M chrome/browser/web_applications/commands/manifest_silent_update_command.cc
M chrome/browser/web_applications/commands/navigate_and_trigger_install_dialog_command_browsertest.cc
M chrome/browser/web_applications/commands/os_integration_synchronize_command_unittest.cc
M chrome/browser/web_applications/commands/rewrite_diy_icons_command.cc
M chrome/browser/web_applications/commands/run_on_os_login_command_unittest.cc
M chrome/browser/web_applications/commands/update_file_handler_command_unittest.cc
M chrome/browser/web_applications/commands/update_protocol_handler_approval_command_browsertest.cc
M chrome/browser/web_applications/extensions/extension_status_utils.cc
M chrome/browser/web_applications/externally_managed_app_manager.cc
M chrome/browser/web_applications/externally_managed_app_manager_unittest.cc
M chrome/browser/web_applications/generated_icon_fix_manager.cc
M chrome/browser/web_applications/generated_icon_fix_util.cc
M chrome/browser/web_applications/isolated_web_apps/isolated_web_app_trust_checker.cc
M chrome/browser/web_applications/isolated_web_apps/policy/isolated_web_app_policy_manager_browsertest.cc
M chrome/browser/web_applications/isolated_web_apps/update/isolated_web_app_update_manager.cc
M chrome/browser/web_applications/isolated_web_apps/update/isolated_web_app_update_manager_unittest.cc
M chrome/browser/web_applications/isolated_web_apps/window_management/isolated_web_apps_window_open_permission_service_browsertest.cc
M chrome/browser/web_applications/jobs/link_capturing_unittest.cc
M chrome/browser/web_applications/os_integration/file_handling_sub_manager_unittest.cc
M chrome/browser/web_applications/os_integration/os_integration_manager.cc
M chrome/browser/web_applications/os_integration/protocol_handling_sub_manager_unittest.cc
M chrome/browser/web_applications/os_integration/run_on_os_login_sub_manager.cc
M chrome/browser/web_applications/os_integration/run_on_os_login_sub_manager_unittest.cc
M chrome/browser/web_applications/os_integration/shortcut_menu_handling_sub_manager_unittest.cc
M chrome/browser/web_applications/os_integration/uninstallation_via_os_settings_sub_manager_unittest.cc
M chrome/browser/web_applications/test/prevent_close_test_base.h
M chrome/browser/web_applications/test/profile_test_helper.h
M chrome/browser/web_applications/web_app_command_manager.cc
M chrome/browser/web_applications/web_app_command_scheduler.cc
M chrome/browser/web_applications/web_app_database_factory.cc
M chrome/browser/web_applications/web_app_database_unittest.cc
M chrome/browser/web_applications/web_app_install_finalizer.cc
M chrome/browser/web_applications/web_app_install_manager.cc
M chrome/browser/web_applications/web_app_internals_browsertest.cc
M chrome/browser/web_applications/web_app_run_on_os_login_manager.cc
M chrome/browser/web_applications/web_app_run_on_os_login_manager_browsertest.cc
M chrome/browser/web_applications/web_app_run_on_os_login_manager_unittest.cc
M chrome/browser/web_applications/web_app_sync_bridge.cc
M chrome/browser/web_applications/web_app_ui_manager.cc
M chrome/browser/web_applications/web_app_utils.cc
M chrome/browser/web_applications/web_app_utils_unittest.cc
M chrome/browser/webshare/share_service_impl.cc
M chrome/browser/win/settings_app_monitor.cc
M chrome/common/extensions/webstore_override.cc
M chrome/common/google_url_loader_throttle.cc
M chrome/renderer/actor/drag_and_release_tool.cc
M chrome/renderer/actor/paint_stability_monitor.h
M chrome/renderer/actor/scroll_tool.cc
M chrome/renderer/actor/select_tool.cc
M chrome/renderer/google_accounts_private_api_extension.cc
M chrome/renderer/webui_browser/webui_browser_renderer_extension_browsertest.cc
M chrome/test/base/testing_profile.cc
M chrome/test/data/webui/glic/glic_browsertest.cc
M chrome/test/data/webui/settings/settings_focus_test.cc
M chrome/test/data/webui/support_tool/support_tool_focus_test.cc
M chrome/test/data/webui/webview/webui_webview_browsertest.cc

Change size: L

Delta: 259 files changed, 12 insertions(+), 260 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Rebekah Potter

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages