Remove BrowserProcess::CreateGlobalFeaturesForTesting and GlobalFeatures::Shutdown. [chromium/src : main]
0 views
Skip to first unread message
Glenn Hartmann (Gerrit)
Dec 16, 2025, 7:11:16 PM (12 days ago) Dec 16
to Tom Lukaszewicz, Chromium LUCI CQ, Peter Beverloo, AyeAye, permissio...@chromium.org, chrome-gr...@chromium.org
Attention needed from Tom Lukaszewicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Dec 16, 2025, 10:08:50 PM (12 days ago) Dec 16
to Glenn Hartmann, Chromium LUCI CQ, Peter Beverloo, AyeAye, permissio...@chromium.org, chrome-gr...@chromium.org
Attention needed from Glenn Hartmann
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Glenn Hartmann
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Dec 17, 2025, 9:35:40 AM (11 days ago) Dec 17
to Tom Lukaszewicz, Chromium LUCI CQ, Peter Beverloo, AyeAye, permissio...@chromium.org, chrome-gr...@chromium.org
Glenn Hartmann voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Glenn Hartmann (Gerrit)
Dec 17, 2025, 9:38:39 AM (11 days ago) Dec 17
to Tom Lukaszewicz, Chromium LUCI CQ, Peter Beverloo, AyeAye, permissio...@chromium.org, chrome-gr...@chromium.org
Glenn Hartmann voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 17, 2025, 9:41:54 AM (11 days ago) Dec 17
to Glenn Hartmann, Tom Lukaszewicz, Peter Beverloo, AyeAye, permissio...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove BrowserProcess::CreateGlobalFeaturesForTesting and GlobalFeatures::Shutdown.
These methods are legacy and should be replaced with
TestingBrowserProcess::SetUpGlobalFeaturesForTesting() and
TestingBrowserProcess::TearDownGlobalFeaturesForTesting(), respectively.
Bug: 467395900
Change-Id: I227f04457ea15f673408e99552f59f446a6a6964
Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
Commit-Queue: Glenn Hartmann <hart...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559923}
Files:
- M chrome/browser/browser_process.h
- M chrome/browser/browser_process_impl.cc
- M chrome/browser/browser_process_impl.h
- M chrome/browser/global_features.cc
- M chrome/browser/global_features.h
- M chrome/browser/permissions/permission_manager_unittest.cc
- M chrome/browser/permissions/permission_subscription_unittest.cc
- M chrome/browser/push_messaging/push_messaging_service_unittest.cc
- M chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
- M chrome/browser/startup/startup_launch_manager_unittest.cc
- M chrome/browser/ui/views/permissions/chip/permission_dashboard_unittest.cc
- M chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
- M chrome/browser/ui/webui/settings/site_settings_helper_unittest.cc
- M chrome/test/base/testing_browser_process.cc
- M chrome/test/base/testing_browser_process.h
Change size: M
Delta: 15 files changed, 67 insertions(+), 43 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages