Enable DiscardTabsWithOccludedWindow on ChromeOS. [chromium/src : main]

0 views
Skip to first unread message

Vovo Yang (Gerrit)

unread,
Nov 27, 2025, 1:42:44 AM (3 days ago) Nov 27
to Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Joe Mason and Lingqi Chi

Vovo Yang added 1 comment

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
  • Lingqi Chi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3dadd78b3d4b65e7db4095361f1c7160b3aeaf91
Gerrit-Change-Number: 7206173
Gerrit-PatchSet: 3
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Lingqi Chi <lin...@chromium.org>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Thu, 27 Nov 2025 06:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vovo Yang (Gerrit)

unread,
Nov 27, 2025, 9:29:32 AM (3 days ago) Nov 27
to Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Joe Mason and Lingqi Chi

New activity on the change

Gerrit-Comment-Date: Thu, 27 Nov 2025 14:28:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vovo Yang (Gerrit)

unread,
Nov 27, 2025, 9:48:32 AM (3 days ago) Nov 27
to Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Joe Mason and Lingqi Chi

Vovo Yang voted Mega-CQ+0

Mega-CQ+0
Gerrit-Comment-Date: Thu, 27 Nov 2025 14:47:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Mason (Gerrit)

unread,
Nov 27, 2025, 10:42:10 AM (3 days ago) Nov 27
to Vovo Yang, Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Lingqi Chi and Vovo Yang

Joe Mason voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lingqi Chi
  • Vovo Yang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3dadd78b3d4b65e7db4095361f1c7160b3aeaf91
Gerrit-Change-Number: 7206173
Gerrit-PatchSet: 3
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Lingqi Chi <lin...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Nov 2025 15:42:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Vovo Yang (Gerrit)

unread,
Nov 27, 2025, 6:53:25 PM (2 days ago) Nov 27
to Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Lingqi Chi

Vovo Yang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Lingqi Chi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3dadd78b3d4b65e7db4095361f1c7160b3aeaf91
Gerrit-Change-Number: 7206173
Gerrit-PatchSet: 3
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Lingqi Chi <lin...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Nov 2025 23:52:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 27, 2025, 6:55:47 PM (2 days ago) Nov 27
to Vovo Yang, Lingqi Chi, chromium...@chromium.org, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Enable DiscardTabsWithOccludedWindow on ChromeOS.

This reverts commit 88eed7d902e8b7fab6f983957bfe3408d2b28ba4.

commit b61f8ddd08cd164b6c91685d1a1429f113430459 fixed the test on
ChromeOS.
Bug: 394889323
Change-Id: I3dadd78b3d4b65e7db4095361f1c7160b3aeaf91
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-by: Joe Mason <joenot...@google.com>
Commit-Queue: Vovo Yang <vo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1551267}
Files:
  • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joe Mason
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3dadd78b3d4b65e7db4095361f1c7160b3aeaf91
Gerrit-Change-Number: 7206173
Gerrit-PatchSet: 4
Gerrit-Owner: Vovo Yang <vo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages