Victor Vianna (Gerrit)

unread,

Jan 6, 2026, 1:18:13 PM (11 days ago) Jan 6

to Osama Fathy, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Mathias Bynens, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sophie Chang, Lei Zhang, Tommy Li, Victor Tan, abigailbk...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jatapiaro+wat...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shgar+aut...@google.com, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Osama Fathy

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Victor Vianna . resolved

osamafathy@ since I'm gonna need an owner for wizard_controller.cc anyway, would you mind reviewing everything?

Open in Gerrit

Related details

Attention is currently required from:

Osama Fathy

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 6, 2026, 1:22:53 PM (11 days ago) Jan 6

to Vasilii Sukhanov, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Permissions Reviews, Peter Beverloo, prerendering-reviews, abigailbk...@google.com, ajayramamurth...@google.com, andysjl...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, cros-print...@google.com, cros-report...@google.com, csharris...@chromium.org, dclasson+w...@google.com, druber...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Vasilii Sukhanov

Victor Vianna voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Vasilii Sukhanov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 7, 2026, 11:49:36 AM (10 days ago) Jan 7

to Yaron Friedman, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Permissions Reviews, Peter Beverloo, prerendering-reviews, abigailbk...@google.com, ajayramamurth...@google.com, andysjl...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, cros-print...@google.com, cros-report...@google.com, csharris...@chromium.org, dclasson+w...@google.com, druber...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Yaron Friedman

Victor Vianna added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Victor Vianna . resolved

vasilii@ is OOO, routing to yfriedman@ instead

Open in Gerrit

Related details

Attention is currently required from:

Yaron Friedman

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yaron Friedman (Gerrit)

unread,

Jan 7, 2026, 1:30:53 PM (10 days ago) Jan 7

to Victor Vianna, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Permissions Reviews, Peter Beverloo, prerendering-reviews, abigailbk...@google.com, ajayramamurth...@google.com, andysjl...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, cros-print...@google.com, cros-report...@google.com, csharris...@chromium.org, dclasson+w...@google.com, druber...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Victor Vianna

Yaron Friedman voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 7, 2026, 2:25:06 PM (10 days ago) Jan 7

to Yaron Friedman, Chromium LUCI CQ, Akihiro Ota, chromium...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Permissions Reviews, Peter Beverloo, prerendering-reviews, abigailbk...@google.com, ajayramamurth...@google.com, andysjl...@chromium.org, bmcquad...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, cros-print...@google.com, cros-report...@google.com, csharris...@chromium.org, dclasson+w...@google.com, druber...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, jackshira+w...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, rhalava...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yuzo+...@chromium.org, zackha...@chromium.org

Victor Vianna submitted the change

Change information

Commit message:

Migrate various base::Contains() to contains() in chrome

Bug: 470391351

Change-Id: Ie777c42bacacd0d9e40995568375613362a11fe5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7367732

Reviewed-by: Yaron Friedman <yfri...@chromium.org>

Auto-Submit: Victor Vianna <victor...@google.com>

Commit-Queue: Yaron Friedman <yfri...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1565804}

Files:

M chrome/browser/navigation_predictor/search_engine_preconnector_browsertest.cc
M chrome/browser/nearby_sharing/certificates/nearby_share_private_certificate.cc
M chrome/browser/nearby_sharing/contacts/nearby_share_contact_manager_impl.cc
M chrome/browser/nearby_sharing/contacts/nearby_share_contact_manager_impl_unittest.cc
M chrome/browser/nearby_sharing/mdns/nearby_connections_mdns_manager.cc
M chrome/browser/nearby_sharing/nearby_per_session_discovery_manager.cc
M chrome/browser/nearby_sharing/nearby_sharing_service_impl.cc
M chrome/browser/nearby_sharing/tcp_socket/nearby_connections_tcp_socket_factory.cc
M chrome/browser/net/secure_dns_util.cc
M chrome/browser/notifications/arc_application_notifier_controller.cc
M chrome/browser/notifications/notification_platform_bridge_linux.cc
M chrome/browser/notifications/notifier_state_tracker.cc
M chrome/browser/notifications/scheduler/internal/notification_scheduler.cc
M chrome/browser/notifications/scheduler/internal/scheduled_notification_manager.cc
M chrome/browser/notifications/scheduler/internal/scheduled_notification_manager_unittest.cc
M chrome/browser/notifications/scheduler/test/test_utils.cc
M chrome/browser/optimization_guide/hints_fetcher_browsertest.cc
M chrome/browser/optimization_guide/model_execution/model_execution_browsertest.cc
M chrome/browser/optimization_guide/model_execution/model_execution_validation_browsertest.cc
M chrome/browser/optimization_guide/prediction/prediction_manager_browsertest.cc
M chrome/browser/page_content_annotations/page_text_observer_browsertest.cc
M chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer_browsertest.cc
M chrome/browser/paint_preview/paint_preview_compositor_browsertest.cc
M chrome/browser/password_manager/credential_manager_browsertest.cc
M chrome/browser/password_manager/password_manager_browsertest.cc
M chrome/browser/payments/browser_binding/browser_bound_key_deleter_service_desktop.cc
M chrome/browser/pdf/pdf_extension_accessibility_test.cc
M chrome/browser/pdf/pdf_viewer_stream_manager.cc
M chrome/browser/performance_manager/policies/discard_eligibility_policy_unittest.cc
M chrome/browser/performance_manager/policies/frame_throttling_policy.cc
M chrome/browser/performance_manager/policies/memory_saver_mode_policy.cc
M chrome/browser/platform_util_linux.cc
M chrome/browser/plugins/chrome_plugin_service_filter.cc
M chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client_unittest.cc
M chrome/browser/policy/messaging_layer/upload/file_upload_impl_unittest.cc
M chrome/browser/policy/networking/policy_cert_service_factory.cc
M chrome/browser/policy/system_features_disable_list_policy_handler.cc
M chrome/browser/policy/test/url_blocklist_policy_browsertest.cc
M chrome/browser/policy/test/web_rtc_local_ips_allowed_urls_policy_browsertest.cc
M chrome/browser/predictors/lcp_critical_path_predictor/lcp_critical_path_predictor_util.cc
M chrome/browser/predictors/loading_data_collector_unittest.cc
M chrome/browser/predictors/loading_predictor_browsertest.cc
M chrome/browser/predictors/loading_stats_collector.cc
M chrome/browser/preloading/prefetch/search_prefetch/search_prefetch_browser_test_base.cc
M chrome/browser/preloading/prefetch/search_prefetch/search_prefetch_service.cc
M chrome/browser/preloading/prefetch/search_prefetch/search_prefetch_service_browsertest.cc
M chrome/browser/preloading/prerender/prerender_browsertest.cc
M chrome/browser/preloading/prerender/prerender_omnibox_interactive_uitest.cc
M chrome/browser/printing/background_printing_manager.cc
M chrome/browser/printing/print_backend_service_manager.cc
M chrome/browser/printing/print_browsertest.cc
M chrome/browser/printing/print_preview_data_service.cc
M chrome/browser/printing/print_preview_dialog_controller.cc
M chrome/browser/printing/print_view_manager.cc
M chrome/browser/printing/system_access_process_print_browsertest.cc
M chrome/browser/privacy_sandbox/notice/histograms_unittest.cc
M chrome/browser/privacy_sandbox/privacy_sandbox_settings_browsertest.cc
M chrome/browser/profiles/gaia_info_update_service.cc
M chrome/browser/profiles/incognito_profile_containment_browsertest.cc
M chrome/browser/profiles/nuke_profile_directory_utils.cc
M chrome/browser/profiles/profile_attributes_storage.cc
M chrome/browser/profiles/profile_impl.cc
M chrome/browser/push_messaging/push_messaging_service_impl.cc
M chrome/browser/reduce_accept_language/reduce_accept_language_browsertest.cc
M chrome/browser/renderer_context_menu/render_view_context_menu.cc
M chrome/browser/resource_coordinator/session_restore_policy.cc
M chrome/browser/resource_coordinator/tab_load_tracker.cc
M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
M chrome/browser/safe_browsing/extension_telemetry/extension_telemetry_service.cc
M chrome/browser/safe_browsing/extension_telemetry/extension_telemetry_service_browsertest.cc
M chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc
M chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc
M chrome/browser/safe_browsing/url_lookup_service_browsertest.cc
M chrome/browser/screen_ai/screen_ai_service_router.cc
M chrome/browser/search_engine_choice/search_engine_choice_dialog_service.cc
M chrome/browser/serial/serial_chooser_context.cc
M chrome/browser/serial/serial_policy_allowed_ports.cc
M chrome/browser/serial/serial_policy_allowed_ports_unittest.cc
M chrome/browser/sessions/session_service.cc
M chrome/browser/sessions/session_service_unittest.cc
M chrome/browser/sessions/tab_loader.cc
M chrome/browser/shell_integration_linux_unittest.cc
M chrome/browser/shortcuts/icon_badging.cc
M chrome/browser/signin/bound_session_credentials/bound_session_cookie_refresh_service_factory_unittest.cc
M chrome/browser/signin/signin_util.cc
M chrome/browser/site_isolation/site_per_process_interactive_uitest.cc
M chrome/browser/speech/chrome_speech_recognition_service.cc
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc
M chrome/browser/ssl/https_first_mode_settings_tracker.cc
M chrome/browser/ssl/https_first_mode_settings_tracker_unittest.cc
M chrome/browser/ssl/https_upgrades_interceptor.cc
M chrome/browser/storage/durable_storage_permission_context.cc
M chrome/browser/storage/shared_storage_browsertest.cc
M chrome/browser/subresource_filter/ad_heuristic_tpcd_browsertest.cc
M chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc
M chrome/browser/supervised_user/supervised_user_navigation_observer.cc
M chrome/browser/supervised_user/supervised_user_navigation_throttle_browsertest.cc
M chrome/browser/supervised_user/supervised_user_pending_state_navigation_browsertest.cc
M chrome/browser/support_tool/ash/network_health_data_collector.cc

Change size: L

Delta: 100 files changed, 388 insertions(+), 487 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Yaron Friedman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Osama Fathy (Gerrit)

unread,

Jan 8, 2026, 1:06:30 PM (9 days ago) Jan 8

to Victor Vianna, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Mathias Bynens, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sophie Chang, Lei Zhang, Tommy Li, Victor Tan, abigailbk...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jatapiaro+wat...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shgar+aut...@google.com, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Victor Vianna

Osama Fathy voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 8, 2026, 1:09:17 PM (9 days ago) Jan 8

to Elly FJ, Osama Fathy, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Mathias Bynens, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sophie Chang, Lei Zhang, Tommy Li, Victor Tan, abigailbk...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jatapiaro+wat...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shgar+aut...@google.com, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Elly FJ

Victor Vianna added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Victor Vianna . resolved

+ellyjones@ for a stamp on document_scan_ash_type_converters_unittest.cc

Open in Gerrit

Related details

Attention is currently required from:

Elly FJ

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Elly FJ (Gerrit)

unread,

Jan 8, 2026, 6:03:55 PM (9 days ago) Jan 8

to Victor Vianna, Elly FJ, Osama Fathy, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Mathias Bynens, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sophie Chang, Lei Zhang, Tommy Li, Victor Tan, abigailbk...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jatapiaro+wat...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shgar+aut...@google.com, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Victor Vianna

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Elly FJ . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners

satisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 8, 2026, 6:04:09 PM (9 days ago) Jan 8

to Elly FJ, Osama Fathy, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Mathias Bynens, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sophie Chang, Lei Zhang, Tommy Li, Victor Tan, abigailbk...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jatapiaro+wat...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shgar+aut...@google.com, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Victor Vianna voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 8, 2026, 6:54:42 PM (9 days ago) Jan 8

to Victor Vianna, Elly FJ, Osama Fathy, Akihiro Ota, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Mathias Bynens, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Sophie Chang, Lei Zhang, Tommy Li, Victor Tan, abigailbk...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jatapiaro+wat...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, lwinston+watc...@google.com, mac-r...@chromium.org, mattreyno...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nicolas...@chromium.org, niharm...@google.com, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rhalava...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shgar+aut...@google.com, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, steimel+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Migrate various base::Contains() to contains() in chrome

Bug: 470391351

Change-Id: Iee1bb78ddbec43ce74337960d70e1e2bca3f1adc

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7369394

Reviewed-by: Osama Fathy <osama...@google.com>

Commit-Queue: Victor Vianna <victor...@google.com>

Auto-Submit: Victor Vianna <victor...@google.com>

Reviewed-by: Elly FJ <elly...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1566607}

Files:

M chrome/browser/accessibility/image_annotation_browsertest.cc
M chrome/browser/accessibility/live_caption/live_caption_automatic_language_download_browsertest.cc
M chrome/browser/accessibility/live_caption/live_caption_language_identification_browsertest.cc
M chrome/browser/accessibility/soda_installer_impl.cc
M chrome/browser/apps/app_discovery_service/recommended_arc_apps/recommend_apps_fetcher_impl.cc
M chrome/browser/apps/app_service/app_icon/app_icon_factory_unittest.cc
M chrome/browser/apps/app_service/app_icon/arc_apps_icon_unittest.cc
M chrome/browser/apps/app_service/app_install/app_install_navigation_throttle.cc
M chrome/browser/apps/app_service/app_notifications.cc
M chrome/browser/apps/app_service/app_service_proxy_ash.cc
M chrome/browser/apps/app_service/app_service_proxy_base.cc
M chrome/browser/apps/app_service/app_service_proxy_unittest.cc
M chrome/browser/apps/app_service/metrics/app_platform_input_metrics.cc
M chrome/browser/apps/app_service/metrics/app_platform_metrics_service_unittest.cc
M chrome/browser/apps/app_service/metrics/website_metrics.cc
M chrome/browser/apps/app_service/metrics/website_metrics_browsertest.cc
M chrome/browser/apps/app_service/paused_apps.cc
M chrome/browser/apps/app_service/publishers/arc_apps.cc
M chrome/browser/apps/app_service/publishers/extension_apps_chromeos.cc
M chrome/browser/apps/app_service/publishers/publisher_unittest.cc
M chrome/browser/apps/link_capturing/metrics/intent_handling_metrics.cc
M chrome/browser/apps/platform_apps/app_browsertest.cc
M chrome/browser/apps/platform_apps/app_window_apitest.cc
M chrome/browser/apps/platform_apps/install_chrome_app.cc
M chrome/browser/ash/accessibility/accessibility_dlc_installer.cc
M chrome/browser/ash/accessibility/dictation.cc
M chrome/browser/ash/accessibility/dictation_browsertest.cc
M chrome/browser/ash/accessibility/dictation_test_utils.cc
M chrome/browser/ash/android_sms/android_sms_app_setup_controller_impl_unittest.cc
M chrome/browser/ash/api/tasks/tasks_client_impl.cc
M chrome/browser/ash/app_list/app_list_sync_model_sanitizer.cc
M chrome/browser/ash/app_list/app_list_syncable_service.cc
M chrome/browser/ash/app_list/app_service/app_service_app_icon_loader.cc
M chrome/browser/ash/app_list/app_service/app_service_promise_app_item_browsertest.cc
M chrome/browser/ash/app_list/arc/arc_app_icon.cc
M chrome/browser/ash/app_list/arc/arc_app_list_prefs.cc
M chrome/browser/ash/app_list/arc/arc_package_syncable_service.cc
M chrome/browser/ash/app_list/search/search_file_scanner.cc
M chrome/browser/ash/app_restore/arc_app_queue_restore_handler.cc
M chrome/browser/ash/app_restore/full_restore_app_launch_handler.cc
M chrome/browser/ash/app_restore/full_restore_app_launch_handler_browsertest.cc
M chrome/browser/ash/apps/apk_web_app_service.cc
M chrome/browser/ash/arc/bluetooth/arc_bluetooth_bridge.cc
M chrome/browser/ash/arc/bluetooth/arc_floss_bridge.cc
M chrome/browser/ash/arc/policy/arc_policy_bridge.cc
M chrome/browser/ash/auth/active_session_fingerprint_client_impl.cc
M chrome/browser/ash/auth/cryptohome_pin_engine.cc
M chrome/browser/ash/auth/legacy_fingerprint_engine.cc
M chrome/browser/ash/boca/on_task/on_task_locked_session_window_tracker.cc
M chrome/browser/ash/calendar/calendar_client_impl.cc
M chrome/browser/ash/cert_provisioning/cert_provisioning_platform_keys_helpers.cc
M chrome/browser/ash/cert_provisioning/cert_provisioning_scheduler.cc
M chrome/browser/ash/cert_provisioning/cert_provisioning_scheduler_unittest.cc
M chrome/browser/ash/child_accounts/family_user_app_metrics.cc
M chrome/browser/ash/child_accounts/family_user_chrome_activity_metrics.cc
M chrome/browser/ash/child_accounts/on_device_controls/app_activity_watcher.cc
M chrome/browser/ash/child_accounts/on_device_controls/blocked_app_registry.cc
M chrome/browser/ash/child_accounts/on_device_controls/blocked_app_registry_unittest.cc
M chrome/browser/ash/child_accounts/on_device_controls/blocked_app_store_unittest.cc
M chrome/browser/ash/child_accounts/parent_access_code/parent_access_service.cc
M chrome/browser/ash/child_accounts/time_limits/app_activity_registry.cc
M chrome/browser/ash/child_accounts/time_limits/web_time_activity_provider.cc
M chrome/browser/ash/child_accounts/usage_time_limit_processor_unittest.cc
M chrome/browser/ash/crosapi/document_scan_ash_type_converters_unittest.cc
M chrome/browser/ash/crosapi/document_scan_ash_unittest.cc
M chrome/browser/ash/early_prefs/early_prefs_export_service.cc
M chrome/browser/ash/events/event_rewriter_unittest.cc
M chrome/browser/ash/extensions/file_manager/drivefs_event_router.cc
M chrome/browser/ash/extensions/file_manager/event_router.cc
M chrome/browser/ash/extensions/file_manager/private_api_file_system.cc
M chrome/browser/ash/extensions/users_private/users_private_api.cc
M chrome/browser/ash/file_manager/copy_or_move_io_task_policy_impl.cc
M chrome/browser/ash/file_manager/file_browser_handlers.cc
M chrome/browser/ash/file_manager/file_manager_policy_browsertest.cc
M chrome/browser/ash/file_manager/file_tasks.cc
M chrome/browser/ash/file_manager/file_tasks_unittest.cc
M chrome/browser/ash/file_manager/volume_manager.cc
M chrome/browser/ash/file_manager/volume_manager_unittest.cc
M chrome/browser/ash/file_suggest/file_suggest_keyed_service.cc
M chrome/browser/ash/file_system_provider/fileapi/provider_async_file_util.cc
M chrome/browser/ash/file_system_provider/service_worker_lifetime_manager.cc
M chrome/browser/ash/file_system_provider/service_worker_lifetime_manager_unittest.cc
M chrome/browser/ash/growth/update_user_pref_action_performer_unittest.cc
M chrome/browser/ash/guest_os/guest_os_mime_types_service.cc
M chrome/browser/ash/guest_os/guest_os_registry_service.cc
M chrome/browser/ash/guest_os/guest_os_share_path.cc
M chrome/browser/ash/input_method/editor_helpers.cc
M chrome/browser/ash/input_method/editor_mediator.cc
M chrome/browser/ash/kerberos/kerberos_credentials_manager_unittest.cc
M chrome/browser/ash/locale/locale_change_guard.cc
M chrome/browser/ash/login/lock/screen_locker.cc
M chrome/browser/ash/login/login_manager_test.cc
M chrome/browser/ash/login/quick_unlock/quick_unlock_utils.cc
M chrome/browser/ash/login/saml/fake_saml_idp_mixin.cc
M chrome/browser/ash/login/saml/password_sync_token_checkers_collection.cc
M chrome/browser/ash/login/screens/guest_tos_screen_browsertest.cc
M chrome/browser/ash/login/screens/update_screen.cc
M chrome/browser/ash/login/test/login_manager_mixin.cc
M chrome/browser/ash/login/wizard_controller.cc
M chrome/browser/ash/mahi/mahi_test_util.cc

Change size: L

Delta: 100 files changed, 279 insertions(+), 374 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Elly FJ, +1 by Osama Fathy

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Migrate various base::Contains() to contains() in chrome [chromium/src : main]

Victor Vianna (Gerrit)

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

1 comment

Related details

Victor Vianna (Gerrit)

Victor Vianna voted Auto-Submit+1

Related details

Victor Vianna (Gerrit)

Victor Vianna added 1 comment

Related details

Yaron Friedman (Gerrit)

Yaron Friedman voted

Related details

Victor Vianna (Gerrit)

Victor Vianna submitted the change

Change information

Osama Fathy (Gerrit)

Osama Fathy voted

Related details

Victor Vianna (Gerrit)

Victor Vianna added 1 comment

Related details

Elly FJ (Gerrit)

Elly FJ voted and added 1 comment

Votes added by Elly FJ

1 comment

Related details

Victor Vianna (Gerrit)

Victor Vianna voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information