doc: Fix the comment about mincore() behavior [chromium/src : main]

2 views
Skip to first unread message

Francois Pierre Doray (Gerrit)

unread,
Oct 22, 2025, 2:36:12 PMOct 22
to Egor Pasko, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Egor Pasko

Francois Pierre Doray voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Egor Pasko
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc6e7b9637b165e6f6098937ad84c1692d82d770
Gerrit-Change-Number: 7072657
Gerrit-PatchSet: 1
Gerrit-Owner: Egor Pasko <pa...@chromium.org>
Gerrit-Reviewer: Egor Pasko <pa...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Egor Pasko <pa...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 18:36:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Egor Pasko (Gerrit)

unread,
Oct 22, 2025, 2:36:32 PMOct 22
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Egor Pasko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc6e7b9637b165e6f6098937ad84c1692d82d770
Gerrit-Change-Number: 7072657
Gerrit-PatchSet: 1
Gerrit-Owner: Egor Pasko <pa...@chromium.org>
Gerrit-Reviewer: Egor Pasko <pa...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 18:36:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 22, 2025, 2:39:16 PMOct 22
to Egor Pasko, Francois Pierre Doray, chromium...@chromium.org, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
doc: Fix the comment about mincore() behavior

What is written (hello my past self) is simply incorrect. Clarify
behavior with a reference to kernel source.
Bug: None
Change-Id: Idc6e7b9637b165e6f6098937ad84c1692d82d770
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Commit-Queue: Egor Pasko <pa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533792}
Files:
  • M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics.h
Change size: XS
Delta: 1 file changed, 3 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc6e7b9637b165e6f6098937ad84c1692d82d770
Gerrit-Change-Number: 7072657
Gerrit-PatchSet: 2
Gerrit-Owner: Egor Pasko <pa...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Egor Pasko <pa...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages