Reformat tab_lifecycle_unit_source.cc. [chromium/src : main]

0 views
Skip to first unread message

Glenn Hartmann (Gerrit)

unread,
Dec 12, 2025, 4:07:35 PMDec 12
to Francois Pierre Doray, Chromium LUCI CQ, AyeAye, chrome-gr...@chromium.org
Attention needed from Francois Pierre Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53de005fc769b76f039b052b4d36f8aa6a6a6964
Gerrit-Change-Number: 7252250
Gerrit-PatchSet: 7
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 21:07:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Dec 15, 2025, 1:25:03 PM (13 days ago) Dec 15
to Glenn Hartmann, Chromium LUCI CQ, AyeAye, chrome-gr...@chromium.org
Attention needed from Glenn Hartmann

Francois Pierre Doray voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Glenn Hartmann
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53de005fc769b76f039b052b4d36f8aa6a6a6964
Gerrit-Change-Number: 7252250
Gerrit-PatchSet: 8
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Attention: Glenn Hartmann <hart...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 18:24:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Glenn Hartmann (Gerrit)

unread,
Dec 15, 2025, 3:56:19 PM (13 days ago) Dec 15
to Francois Pierre Doray, Chromium LUCI CQ, AyeAye, chrome-gr...@chromium.org

Glenn Hartmann voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53de005fc769b76f039b052b4d36f8aa6a6a6964
Gerrit-Change-Number: 7252250
Gerrit-PatchSet: 8
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Glenn Hartmann <hart...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 20:56:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 15, 2025, 4:00:08 PM (13 days ago) Dec 15
to Glenn Hartmann, Francois Pierre Doray, AyeAye, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Reformat tab_lifecycle_unit_source.cc.

This makes
https://chromium-review.googlesource.com/c/chromium/src/+/7238850 nicer.
Bug: 459777668
Change-Id: I53de005fc769b76f039b052b4d36f8aa6a6a6964
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Commit-Queue: Glenn Hartmann <hart...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558942}
Files:
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
Change size: S
Delta: 1 file changed, 20 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53de005fc769b76f039b052b4d36f8aa6a6a6964
Gerrit-Change-Number: 7252250
Gerrit-PatchSet: 9
Gerrit-Owner: Glenn Hartmann <hart...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages