[bedrock] Remove Browser* from tab_lifecycle_unit_unittest [chromium/src : main]

1 view
Skip to first unread message

Daniel Rubery (Gerrit)

unread,
Apr 29, 2026, 12:44:37 PMApr 29
to chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chrome-gr...@chromium.org
Attention needed from chromium-bedrock-reviews

Daniel Rubery voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • chromium-bedrock-reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I07a82eb839f6e09139b2ff57a35668f96a6a6964
Gerrit-Change-Number: 7802236
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Attention: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Comment-Date: Wed, 29 Apr 2026 16:44:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Apr 29, 2026, 12:50:52 PMApr 29
to Daniel Rubery, chromium-bedrock-reviews, Sophie Chang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chrome-gr...@chromium.org
Attention needed from Sophie Chang

Message from gwsq

Reviewer source(s):
sophi...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Sophie Chang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I07a82eb839f6e09139b2ff57a35668f96a6a6964
Gerrit-Change-Number: 7802236
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Apr 2026 16:50:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sophie Chang (Gerrit)

unread,
Apr 29, 2026, 1:24:12 PMApr 29
to Daniel Rubery, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chrome-gr...@chromium.org
Attention needed from Daniel Rubery

Sophie Chang voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Rubery
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I07a82eb839f6e09139b2ff57a35668f96a6a6964
Gerrit-Change-Number: 7802236
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Daniel Rubery <dru...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Apr 2026 17:23:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 29, 2026, 1:30:49 PMApr 29
to Daniel Rubery, Sophie Chang, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[bedrock] Remove Browser* from tab_lifecycle_unit_unittest

This test doesn't actually use it anywhere, so just remove the #includes
Bug: 507743685
Commit-Queue: Sophie Chang <sophi...@chromium.org>
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Auto-Submit: Daniel Rubery <dru...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1622560}
Files:
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sophie Chang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I07a82eb839f6e09139b2ff57a35668f96a6a6964
Gerrit-Change-Number: 7802236
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages