Modularize //chrome/browser [chromium/src : main]

[Erik Chen (Gerrit)]

Attention needed from Thomas Lukaszewicz

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Thomas Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie42c13948dc22978ba6298d0806246c186503e3d

Gerrit-Change-Number: 7815008

Gerrit-PatchSet: 5

Gerrit-Owner: Erik Chen <erik...@chromium.org>

Gerrit-Reviewer: Erik Chen <erik...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Ale Bzk <ales...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Charles Hager <clh...@google.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: James Su <su...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Kevin McNee <mc...@chromium.org>

Gerrit-CC: Linyu He <lin...@google.com>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Mark Schillaci <mschi...@google.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Moe Adel <ad...@google.com>

Gerrit-CC: Neil Coronado <ne...@google.com>

Gerrit-CC: Per Åhgren <pe...@chromium.org>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sam Zackrisson <sa...@chromium.org>

Gerrit-CC: Shu Yang <shu...@google.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Sinan Sahin <sinan...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Tue, 05 May 2026 15:15:47 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Thomas Lukaszewicz (Gerrit)]

Attention needed from Erik Chen

Thomas Lukaszewicz added 1 comment

File chrome/browser/BUILD.gn

Line 200, Patchset 5 (Latest):source_set("core") {

Thomas Lukaszewicz . unresolved

Creating the `:core` target here sounds good to me.

Now that we've moved many of the `deps`, `public_deps` and `allow_circular_includes_from` to `:core` is it possible to also remove these from the `:browser` target below? Or do lists in both have to co-exist in the meantime?

Open in Gerrit

Related details

Attention is currently required from:

• Erik Chen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Attention: Erik Chen <erik...@chromium.org>

Gerrit-Comment-Date: Tue, 05 May 2026 18:32:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Erik Chen (Gerrit)]

Attention needed from Thomas Lukaszewicz

Erik Chen added 1 comment

File chrome/browser/BUILD.gn

Line 200, Patchset 5 (Latest):source_set("core") {

Thomas Lukaszewicz . unresolved

Creating the `:core` target here sounds good to me.

Now that we've moved many of the `deps`, `public_deps` and `allow_circular_includes_from` to `:core` is it possible to also remove these from the `:browser` target below? Or do lists in both have to co-exist in the meantime?

Erik Chen

yep my thoughts exactly. most can be removed.

Open in Gerrit

Related details

Attention is currently required from:

• Thomas Lukaszewicz

Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Tue, 05 May 2026 18:34:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Thomas Lukaszewicz <tl...@chromium.org>

[Thomas Lukaszewicz (Gerrit)]

Attention needed from Erik Chen

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review

+1

1 comment

File chrome/browser/BUILD.gn

Line 200, Patchset 5 (Latest):source_set("core") {

Thomas Lukaszewicz . resolved

Creating the `:core` target here sounds good to me.

Now that we've moved many of the `deps`, `public_deps` and `allow_circular_includes_from` to `:core` is it possible to also remove these from the `:browser` target below? Or do lists in both have to co-exist in the meantime?

Erik Chen

yep my thoughts exactly. most can be removed.

Thomas Lukaszewicz

sgtm - happy to approve this and will leave it to you if we want to try to remove them in this change or a follow-up.

Open in Gerrit

Related details

Attention is currently required from:

• Erik Chen

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Attention: Erik Chen <erik...@chromium.org>

Gerrit-Comment-Date: Tue, 05 May 2026 18:36:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Erik Chen <erik...@chromium.org>

Comment-In-Reply-To: Thomas Lukaszewicz <tl...@chromium.org>

[Erik Chen (Gerrit)]

Erik Chen voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Tue, 05 May 2026 19:39:09 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Modularize //chrome/browser

This CL refactors `chrome/browser/BUILD.gn` by splitting the existing
`static_library("browser")` into a new `source_set("core")` target plus
a slimmed-down `static_library("browser")`. The new `:core` target
absorbs the bulk of the source files, deps, and
`allow_circular_includes_from` entries, while `:browser` retains only a
small set of sources (icon_manager, memory_details, net_benchmarking,
etc.) and now depends on `:core`. The
`chrome/browser/media/prefs/BUILD.gn` visibility list is updated to
grant access to the new `//chrome/browser:core` target. This is a
build-system reorganization with no functional code changes.

AGENT_GENERATED_CL

Bug: 353332589

Change-Id: Ie42c13948dc22978ba6298d0806246c186503e3d

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7815008

Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>

Commit-Queue: Erik Chen <erik...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1625651}

Files:

• M chrome/browser/BUILD.gn
• M chrome/browser/media/prefs/BUILD.gn

Change size: XL

Delta: 2 files changed, 999 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Thomas Lukaszewicz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie42c13948dc22978ba6298d0806246c186503e3d

Gerrit-Change-Number: 7815008

Gerrit-PatchSet: 6

Gerrit-Owner: Erik Chen <erik...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Erik Chen <erik...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Ale Bzk <ales...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Charles Hager <clh...@google.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

[Dale Curtis (Gerrit)]

Dale Curtis has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: revert