[discard] Add ignore_workers to URGENT ChromeOS discard [chromium/src : main]
0 views
Skip to first unread message
Tom Lukaszewicz (Gerrit)
Nov 24, 2025, 5:56:16 PM (5 days ago) Nov 24
to Francois Pierre Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Attention needed from Francois Pierre Doray
Tom Lukaszewicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Nov 24, 2025, 6:01:20 PM (5 days ago) Nov 24
to Darryl James, Rakina Zata Amni, Francois Pierre Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Attention needed from Darryl James, Francois Pierre Doray and Rakina Zata Amni
Tom Lukaszewicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Darryl James
- Francois Pierre Doray
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Nov 24, 2025, 6:03:13 PM (5 days ago) Nov 24
to Tom Lukaszewicz, Rakina Zata Amni, Francois Pierre Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Attention needed from Francois Pierre Doray, Rakina Zata Amni and Tom Lukaszewicz
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Francois Pierre Doray
- Rakina Zata Amni
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Nov 24, 2025, 8:36:55 PM (5 days ago) Nov 24
to Tom Lukaszewicz, Darryl James, Francois Pierre Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Attention needed from Francois Pierre Doray and Tom Lukaszewicz
Rakina Zata Amni voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Francois Pierre Doray
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Nov 25, 2025, 10:30:11 AM (4 days ago) Nov 25
to Tom Lukaszewicz, Rakina Zata Amni, Darryl James, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Attention needed from Tom Lukaszewicz
Francois Pierre Doray voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Nov 25, 2025, 12:03:55 PM (4 days ago) Nov 25
to Francois Pierre Doray, Rakina Zata Amni, Darryl James, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Tom Lukaszewicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 25, 2025, 12:07:55 PM (4 days ago) Nov 25
to Tom Lukaszewicz, Francois Pierre Doray, Rakina Zata Amni, Darryl James, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[discard] Add ignore_workers to URGENT ChromeOS discard
This CL introduces a new feature param that controls ignoring open
workers in URGENT discard scenarios on ChromeOS.
Workers are currently responsible for ~13% of ChromeOS stable
blocks on fast shutdown.
Bug: 347770670
Change-Id: If61d321c330f628f897384564f843ff4b7ea9ecc
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Reviewed-by: Darryl James <dlj...@chromium.org>
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1549858}
Files:
- M chrome/browser/resource_coordinator/tab_manager.h
- M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
- M chrome/browser/resource_coordinator/utils.cc
- M chrome/browser/resource_coordinator/utils.h
- M content/public/common/content_features.cc
- M content/public/common/content_features.h
- M tools/metrics/histograms/metadata/tab/enums.xml
Change size: M
Delta: 7 files changed, 96 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Francois Pierre Doray, +1 by Darryl James, +1 by Rakina Zata Amni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages