Lei Zhang (Gerrit)

unread,

Nov 14, 2025, 12:03:32 PMNov 14

to Lei Zhang, Daniel Cheng, Zijie He, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, cc-...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Nov 14, 2025, 1:20:59 PMNov 14

to Lei Zhang, Daniel Cheng, Zijie He, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, cc-...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 16, 2025, 2:02:33 AMNov 16

to Lei Zhang, Daniel Cheng, Zijie He, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, cc-...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 16, 2025, 2:05:30 AMNov 16

to Lei Zhang, Daniel Cheng, Zijie He, Sadrul Chowdhury, AyeAye, chromium...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, cc-...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Switch to base/functional/callback_forward.h in a few headers

Switch from base/functional/callback.h to callback_forward.h in a few
commonly included headers. Then do IWYU to fix the build.

Change-Id: I608053dda1471354b0193235a76cb1e91e1ef9f4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7155708

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1545549}

Files:

M android_webview/browser/tracing/aw_trace_event_args_allowlist.cc
M base/message_loop/message_pump_fuchsia.cc
M base/trace_event/memory_dump_manager.h
M base/trace_event/memory_dump_request_args.h
M base/trace_event/trace_event_impl.h
M base/trace_event/trace_log.h
M cc/metrics/scroll_jank_v4_frame_stage.cc
M components/subresource_filter/core/common/indexed_ruleset.cc
M components/tabs/impl/tab_collection.cc
M components/tabs/public/tab_interface.h
M components/translate/core/language_detection/language_detection_model.cc
M components/viz/common/frame_sinks/begin_frame_args.cc
M gpu/command_buffer/service/query_manager.cc
M media/base/frame_buffer_pool_unittest.cc
M services/resource_coordinator/memory_instrumentation/global_dump_graph_converter.cc
M services/tracing/public/cpp/perfetto/custom_event_recorder.h
M services/tracing/public/cpp/trace_event_args_allowlist.cc
M ui/android/handle_view_resources.cc
M ui/events/android/motion_event_android_source_native.cc
M ui/gl/os_compositor_tree_base_unittest.cc
M ui/latency/latency_info.cc
M ui/ozone/public/gpu_platform_support_host.cc

Change size: S

Delta: 22 files changed, 23 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Switch to base/functional/callback_forward.h in a few headers [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information