Mark various arrays as constexpr [chromium/src : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Nov 15, 2025, 12:25:08 AMNov 15
to Lei Zhang, Arthur Sonzogni, chromium...@chromium.org, Enterprise Policy Reviews, James Su, Chromium LUCI CQ, cc-...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, philli...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Arthur Sonzogni
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Nov 17, 2025, 1:11:34 AM (13 days ago) Nov 17
to Lei Zhang, chromium...@chromium.org, Enterprise Policy Reviews, James Su, Chromium LUCI CQ, cc-...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, philli...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang
Arthur Sonzogni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
Lei Zhang . resolved
Please OO+1.
Arthur Sonzogni
SGTM! Thanks!
As far as I remember, the clang plugin preserves qualifiers like const, constexpr, etc..
See [source](https://source.chromium.org/chromium/chromium/src/+/main:tools/clang/spanify/Spanifier.cpp;l=2470-2472). I would have expected to see `const` at least here. I am surprised we don't. I am going to investigate if other array can be made
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 17, 2025, 2:41:32 AM (13 days ago) Nov 17
to Lei Zhang, Arthur Sonzogni, chromium...@chromium.org, Enterprise Policy Reviews, James Su, cc-...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, philli...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, translat...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, zelin+watch-we...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Mark various arrays as constexpr
Grep for '^auto k[A-Z].*std::to_array' and mark the arrays as constexpr.
Change-Id: I69b38d122d6c6ab1f919fa2b8c95faf45bb09562
Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
Owners-Override: Arthur Sonzogni <arthurs...@chromium.org>
Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
Auto-Submit: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1545726}
Files:
- M cc/trees/layer_tree_host_pixeltest_blending.cc
- M chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
- M chrome/browser/resource_coordinator/decision_details.cc
- M chrome/browser/translate/translate_manager_render_view_host_unittest.cc
- M chrome/browser/ui/web_applications/web_app_engagement_browsertest.cc
- M components/no_state_prefetch/common/no_state_prefetch_final_status.cc
- M components/no_state_prefetch/common/no_state_prefetch_origin.cc
- M components/page_content_annotations/core/page_content_annotations_validator.cc
- M components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc
- M components/policy/core/common/cloud/external_policy_data_updater_unittest.cc
- M components/proxy_config/proxy_prefs.cc
- M components/safe_search_api/safe_search/safe_search_url_checker_client_unittest.cc
- M components/safe_search_api/url_checker_unittest.cc
- M components/viz/common/yuv_readback_unittest.cc
- M device/gamepad/nintendo_controller.cc
- M gpu/command_buffer/tests/gl_helper_benchmark.cc
- M gpu/command_buffer/tests/gl_helper_unittest.cc
- M media/filters/in_memory_url_protocol_unittest.cc
- M net/test/url_request/url_request_failed_job.cc
- M net/tools/cachetool/cachetool.cc
- M ui/base/ime/candidate_window_unittest.cc
Change size: M
Delta: 21 files changed, 28 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Arthur Sonzogni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages