[tracing] Migrate legacy async macros in services [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Aug 13, 2025, 10:20:04 AMAug 13
to Ahmed Moussa, Maks Orlovich, Austin Sullivan, Primiano Tucci, Olga Sharonova, Jiewei Qian, ningxin hu, chromium...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, chrome-gr...@chromium.org, blink-...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, network-ser...@chromium.org, tracing...@chromium.org
Attention needed from Ahmed Moussa, Austin Sullivan, Maks Orlovich, Olga Sharonova and Primiano Tucci
Etienne Pierre-Doray has uploaded the change for review![]( "Open in Gerrit")
Etienne Pierre-Doray would like Ahmed Moussa, Maks Orlovich, Austin Sullivan, Primiano Tucci and Olga Sharonova to review this change.
Commit message
[tracing] Migrate legacy async macros in services
Migrating the following async event macros somewhat mechanically:
```
- TRACE_EVENT(_NESTABLE)?_ASYNC_BEGIN(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
-> TRACE_EVENT_BEGIN(<category_group>, <name>, <track>, ...)
- TRACE_EVENT(_NESTABLE)?_ASYNC_END(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
-> TRACE_EVENT_END(<category_group>, <track>, ...)
- TRACE_EVENT(_NESTABLE)?_ASYNC_INSTANT(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
-> TRACE_EVENT_INSTANT(<category_group>, <name>, <track>, ...)
```
This CL was uploaded by git cl split.
R=ahmed...@google.com, asu...@chromium.org, morl...@chromium.org, ol...@chromium.org, prim...@chromium.org
Bug: 432427382
Change-Id: I780c196c556c0a16ca70af047bf703014c6e4ae2
Change diff
Change information
Files:
- M services/audio/input_stream.cc
- M services/audio/output_device_mixer_impl.cc
- M services/audio/output_stream.cc
- M services/audio/public/cpp/audio_system_to_service_adapter.cc
- M services/audio/stream_factory.cc
- M services/network/accept_ch_frame_interceptor.cc
- M services/network/p2p/socket_udp.cc
- M services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
- M services/tracing/public/cpp/stack_sampling/loader_lock_sampling_thread_win.cc
- M services/video_effects/video_effects_processor_webgpu.cc
- M services/webnn/dml/command_queue.cc
- M services/webnn/public/cpp/webnn_trace.cc
- M services/webnn/public/cpp/webnn_trace.h
- M third_party/blink/renderer/modules/ml/webnn/ml_graph_builder.cc
Change size: L
Delta: 14 files changed, 179 insertions(+), 165 deletions(-)
Related details
Attention is currently required from:
- Ahmed Moussa
- Austin Sullivan
- Maks Orlovich
- Olga Sharonova
- Primiano Tucci
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Austin Sullivan (Gerrit)
Aug 13, 2025, 10:26:35 AMAug 13
to Etienne Pierre-Doray, Chromium LUCI CQ, Ahmed Moussa, Maks Orlovich, Olga Sharonova, Primiano Tucci, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Ahmed Moussa, Etienne Pierre-Doray, Maks Orlovich, Olga Sharonova and Primiano Tucci
Austin Sullivan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Austin Sullivan
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Ahmed Moussa
- Etienne Pierre-Doray
- Maks Orlovich
- Olga Sharonova
- Primiano Tucci
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Austin Sullivan (Gerrit)
Aug 13, 2025, 11:33:45 AMAug 13
to Etienne Pierre-Doray, Chromium LUCI CQ, Ahmed Moussa, Maks Orlovich, Olga Sharonova, Primiano Tucci, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Ahmed Moussa, Etienne Pierre-Doray, Maks Orlovich, Olga Sharonova and Primiano Tucci
Austin Sullivan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ahmed Moussa
- Etienne Pierre-Doray
- Maks Orlovich
- Olga Sharonova
- Primiano Tucci
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Aug 13, 2025, 1:09:33 PMAug 13
to Etienne Pierre-Doray, Austin Sullivan, Chromium LUCI CQ, Ahmed Moussa, Olga Sharonova, Primiano Tucci, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Ahmed Moussa, Etienne Pierre-Doray, Olga Sharonova and Primiano Tucci
Maks Orlovich voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maks Orlovich
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Ahmed Moussa
- Etienne Pierre-Doray
- Olga Sharonova
- Primiano Tucci
Etienne Pierre-Doray (Gerrit)
Aug 13, 2025, 4:48:39 PMAug 13
to Primiano Tucci, Maks Orlovich, Austin Sullivan, Chromium LUCI CQ, Ahmed Moussa, Olga Sharonova, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Ahmed Moussa, Austin Sullivan, Maks Orlovich and Olga Sharonova
Etienne Pierre-Doray removed Primiano Tucci from this change![]( "Open in Gerrit")
Attention is currently required from:
- Ahmed Moussa
- Austin Sullivan
- Maks Orlovich
- Olga Sharonova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ahmed Moussa (Gerrit)
Aug 13, 2025, 5:13:30 PMAug 13
to Etienne Pierre-Doray, Maks Orlovich, Austin Sullivan, Chromium LUCI CQ, Olga Sharonova, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Austin Sullivan, Etienne Pierre-Doray, Maks Orlovich and Olga Sharonova
Ahmed Moussa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ahmed Moussa
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ahmed Moussa . resolved
services/video_effects/video_effects_processor_webgpu.cc LGTM
Related details
Attention is currently required from:
- Austin Sullivan
- Etienne Pierre-Doray
- Maks Orlovich
- Olga Sharonova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Aug 15, 2025, 2:18:39 PMAug 15
to Etienne Pierre-Doray, Ahmed Moussa, Austin Sullivan, Chromium LUCI CQ, Olga Sharonova, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Austin Sullivan, Etienne Pierre-Doray and Olga Sharonova
Maks Orlovich voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maks Orlovich
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Austin Sullivan
- Etienne Pierre-Doray
- Olga Sharonova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olga Sharonova (Gerrit)
Aug 18, 2025, 9:10:42 AMAug 18
to Etienne Pierre-Doray, Maks Orlovich, Ahmed Moussa, Austin Sullivan, Chromium LUCI CQ, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Olga Sharonova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olga Sharonova
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 18, 2025, 10:40:56 AMAug 18
to Daniel Cheng, Olga Sharonova, Maks Orlovich, Ahmed Moussa, Austin Sullivan, Chromium LUCI CQ, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Etienne Pierre-Doray . resolved
+dcheng@ for services/test/run_all_unittests.cc
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Aug 18, 2025, 2:16:37 PMAug 18
to Etienne Pierre-Doray, Daniel Cheng, Olga Sharonova, Maks Orlovich, Ahmed Moussa, Austin Sullivan, Chromium LUCI CQ, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Daniel Cheng voted![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 18, 2025, 3:43:30 PMAug 18
to Etienne Pierre-Doray, Daniel Cheng, Olga Sharonova, Maks Orlovich, Ahmed Moussa, Austin Sullivan, chromium...@chromium.org, ningxin hu, Jiewei Qian, blink-...@chromium.org, chrome-gr...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Migrate legacy async macros in services
Migrating the following async event macros somewhat mechanically:
```
- TRACE_EVENT(_NESTABLE)?_ASYNC_BEGIN(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
-> TRACE_EVENT_BEGIN(<category_group>, <name>, <track>, ...)
- TRACE_EVENT(_NESTABLE)?_ASYNC_END(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
-> TRACE_EVENT_END(<category_group>, <track>, ...)
- TRACE_EVENT(_NESTABLE)?_ASYNC_INSTANT(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
-> TRACE_EVENT_INSTANT(<category_group>, <name>, <track>, ...)
```
This CL was uploaded by git cl split.
R=ahmed...@google.com, asu...@chromium.org, morl...@chromium.org, ol...@chromium.org, prim...@chromium.org
Bug: 432427382
Change-Id: I780c196c556c0a16ca70af047bf703014c6e4ae2
Reviewed-by: Maks Orlovich <morl...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Auto-Submit: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Ahmed Moussa <ahmed...@google.com>
Reviewed-by: Olga Sharonova <ol...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1502887}
Files:
- M services/audio/input_stream.cc
- M services/audio/output_device_mixer_impl.cc
- M services/audio/output_stream.cc
- M services/audio/public/cpp/audio_system_to_service_adapter.cc
- M services/audio/stream_factory.cc
- M services/network/accept_ch_frame_interceptor.cc
- M services/network/p2p/socket_udp.cc
- M services/test/run_all_unittests.cc
- M services/tracing/public/cpp/stack_sampling/loader_lock_sampling_thread_win.cc
- M services/video_effects/video_effects_processor_webgpu.cc
- M services/webnn/dml/command_queue.cc
- M services/webnn/public/cpp/webnn_trace.cc
- M services/webnn/public/cpp/webnn_trace.h
- M third_party/blink/renderer/modules/ml/webnn/ml_graph_builder.cc
Change size: L
Delta: 14 files changed, 176 insertions(+), 159 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Maks Orlovich, +1 by Olga Sharonova, +1 by Ahmed Moussa, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages