Revert "Remove superfluous callback.h includes from //chrome headers" [chromium/src : main]

0 views
Skip to first unread message

Yuki Shiino (Gerrit)

unread,
Nov 12, 2025, 3:16:15 AMNov 12
to Yuki Shiino, Rubber Stamper, AyeAye, Lei Zhang, Chromium LUCI CQ, Victor Vianna, Daniel Cheng, Thiabaud Engelbrecht, Tommy Li, chromium...@chromium.org, Kaan Icer, Nikhil Nayunigari, Sean Maher, Enterprise Policy Reviews, prerendering-reviews, devtools...@chromium.org, Mathias Bynens, Sophie Chang, Christian Biesinger, (Julie)Jeongeun Kim, Peter Beverloo, npm+...@chromium.org, tranbaod...@chromium.org, suetfei+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, pushi+wat...@google.com, jonmann+wa...@chromium.org, hsuregan+wa...@chromium.org, hansberry+w...@chromium.org, hansberry+w...@chromium.org, storage...@chromium.org, dclasson+w...@google.com, net-r...@chromium.org, feature-v...@chromium.org, hansenmichael...@google.com, chromium-a...@chromium.org, kinuko+...@chromium.org, cros-enterpris...@chromium.org, dmurph+watc...@chromium.org, jkeitel+watch-...@google.com, dibyapal+wa...@chromium.org, yigu+...@chromium.org, marimatthew+watc...@google.com, asumane...@google.com, khorimoto+w...@chromium.org, filesapp...@chromium.org, jackshira+w...@google.com, mreichhoff+watc...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, hais+wat...@google.com, francisjp...@google.com, mgiuca...@chromium.org, kuragin+web-ap...@chromium.org, gcasto+w...@chromium.org, feature-me...@chromium.org, omnibox-...@chromium.org, shuche...@chromium.org, dtraino...@chromium.org, josiah...@chromium.org, gavin...@chromium.org, loyso...@chromium.org, tburkar...@chromium.org, zelin+watch-we...@chromium.org, bhartmire+w...@google.com, chromiumme...@microsoft.com, webap...@microsoft.com, ejcaruso+wa...@chromium.org, rhalava...@chromium.org, jiajunz+wa...@google.com, ajayramamurth...@google.com, cros-report...@google.com, nektar...@chromium.org, extension...@chromium.org, yhanad...@chromium.org, dtseng...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, jackshira+w...@google.com, mtomas...@chromium.org, rrsilva+wat...@google.com, jasonrhee+w...@google.com, mfoltz+wa...@chromium.org, nona+...@chromium.org, hirokisa...@chromium.org, chadduffin+w...@chromium.org, keithle...@chromium.org, yhanada+...@chromium.org, minap+watch-p...@google.com, rginda...@chromium.org, crost...@chromium.org, crisrael+w...@google.com, arc-review...@google.com, yuzo+...@chromium.org, ajayramamurth...@google.com, abigailbk...@google.com, jackshira+w...@google.com, mfoltz+wa...@chromium.org, kyungjunle...@google.com, kaklilu+watch-...@chromium.org, asvitki...@chromium.org, jdonnel...@chromium.org, bcb+watch-pl...@chromium.org, cros-ed...@google.com, philli...@chromium.org, print-rev...@chromium.org, hidehik...@chromium.org, stevenjb+wa...@chromium.org, xlythe+wa...@google.com
Attention needed from Daniel Cheng, Lei Zhang and Victor Vianna

Yuki Shiino voted

Auto-Submit+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Lei Zhang
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I08dd51dd27413971d29b842d6c1a5346994f0c45
Gerrit-Change-Number: 7144264
Gerrit-PatchSet: 1
Gerrit-Owner: Yuki Shiino <yukis...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 08:15:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Nov 12, 2025, 3:16:15 AMNov 12
to Yuki Shiino, AyeAye, Lei Zhang, Chromium LUCI CQ, Victor Vianna, Daniel Cheng, Thiabaud Engelbrecht, Tommy Li, chromium...@chromium.org, Kaan Icer, Nikhil Nayunigari, Sean Maher, Enterprise Policy Reviews, prerendering-reviews, devtools...@chromium.org, Mathias Bynens, Sophie Chang, Christian Biesinger, (Julie)Jeongeun Kim, Peter Beverloo, npm+...@chromium.org, tranbaod...@chromium.org, suetfei+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, pushi+wat...@google.com, jonmann+wa...@chromium.org, hsuregan+wa...@chromium.org, hansberry+w...@chromium.org, hansberry+w...@chromium.org, storage...@chromium.org, dclasson+w...@google.com, net-r...@chromium.org, feature-v...@chromium.org, hansenmichael...@google.com, chromium-a...@chromium.org, kinuko+...@chromium.org, cros-enterpris...@chromium.org, dmurph+watc...@chromium.org, jkeitel+watch-...@google.com, dibyapal+wa...@chromium.org, yigu+...@chromium.org, marimatthew+watc...@google.com, asumane...@google.com, khorimoto+w...@chromium.org, filesapp...@chromium.org, jackshira+w...@google.com, mreichhoff+watc...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, hais+wat...@google.com, francisjp...@google.com, mgiuca...@chromium.org, kuragin+web-ap...@chromium.org, gcasto+w...@chromium.org, feature-me...@chromium.org, omnibox-...@chromium.org, shuche...@chromium.org, dtraino...@chromium.org, josiah...@chromium.org, gavin...@chromium.org, loyso...@chromium.org, tburkar...@chromium.org, zelin+watch-we...@chromium.org, bhartmire+w...@google.com, chromiumme...@microsoft.com, webap...@microsoft.com, ejcaruso+wa...@chromium.org, rhalava...@chromium.org, jiajunz+wa...@google.com, ajayramamurth...@google.com, cros-report...@google.com, nektar...@chromium.org, extension...@chromium.org, yhanad...@chromium.org, dtseng...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, jackshira+w...@google.com, mtomas...@chromium.org, rrsilva+wat...@google.com, jasonrhee+w...@google.com, mfoltz+wa...@chromium.org, nona+...@chromium.org, hirokisa...@chromium.org, chadduffin+w...@chromium.org, keithle...@chromium.org, yhanada+...@chromium.org, minap+watch-p...@google.com, rginda...@chromium.org, crost...@chromium.org, crisrael+w...@google.com, arc-review...@google.com, yuzo+...@chromium.org, ajayramamurth...@google.com, abigailbk...@google.com, jackshira+w...@google.com, mfoltz+wa...@chromium.org, kyungjunle...@google.com, kaklilu+watch-...@chromium.org, asvitki...@chromium.org, jdonnel...@chromium.org, bcb+watch-pl...@chromium.org, cros-ed...@google.com, philli...@chromium.org, print-rev...@chromium.org, hidehik...@chromium.org, stevenjb+wa...@chromium.org, xlythe+wa...@google.com
Attention needed from Daniel Cheng, Lei Zhang and Victor Vianna

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Lei Zhang
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Comment-Date: Wed, 12 Nov 2025 08:16:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 12, 2025, 3:16:42 AMNov 12
    to Yuki Shiino, Rubber Stamper, AyeAye, Lei Zhang, Victor Vianna, Daniel Cheng, Thiabaud Engelbrecht, Tommy Li, chromium...@chromium.org, Kaan Icer, Nikhil Nayunigari, Sean Maher, Akihiro Ota, Enterprise Policy Reviews, prerendering-reviews, devtools...@chromium.org, Mathias Bynens, Sophie Chang, Christian Biesinger, (Julie)Jeongeun Kim, Peter Beverloo, npm+...@chromium.org, tranbaod...@chromium.org, suetfei+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, pushi+wat...@google.com, jonmann+wa...@chromium.org, hsuregan+wa...@chromium.org, hansberry+w...@chromium.org, hansberry+w...@chromium.org, storage...@chromium.org, dclasson+w...@google.com, net-r...@chromium.org, feature-v...@chromium.org, hansenmichael...@google.com, chromium-a...@chromium.org, kinuko+...@chromium.org, cros-enterpris...@chromium.org, dmurph+watc...@chromium.org, jkeitel+watch-...@google.com, dibyapal+wa...@chromium.org, yigu+...@chromium.org, marimatthew+watc...@google.com, asumane...@google.com, khorimoto+w...@chromium.org, filesapp...@chromium.org, jackshira+w...@google.com, mreichhoff+watc...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, hais+wat...@google.com, francisjp...@google.com, mgiuca...@chromium.org, kuragin+web-ap...@chromium.org, gcasto+w...@chromium.org, feature-me...@chromium.org, omnibox-...@chromium.org, shuche...@chromium.org, dtraino...@chromium.org, josiah...@chromium.org, gavin...@chromium.org, loyso...@chromium.org, tburkar...@chromium.org, zelin+watch-we...@chromium.org, bhartmire+w...@google.com, chromiumme...@microsoft.com, webap...@microsoft.com, ejcaruso+wa...@chromium.org, rhalava...@chromium.org, jiajunz+wa...@google.com, ajayramamurth...@google.com, cros-report...@google.com, nektar...@chromium.org, extension...@chromium.org, yhanad...@chromium.org, dtseng...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, jackshira+w...@google.com, mtomas...@chromium.org, rrsilva+wat...@google.com, jasonrhee+w...@google.com, mfoltz+wa...@chromium.org, nona+...@chromium.org, hirokisa...@chromium.org, chadduffin+w...@chromium.org, keithle...@chromium.org, yhanada+...@chromium.org, minap+watch-p...@google.com, rginda...@chromium.org, crost...@chromium.org, crisrael+w...@google.com, arc-review...@google.com, yuzo+...@chromium.org, ajayramamurth...@google.com, abigailbk...@google.com, jackshira+w...@google.com, mfoltz+wa...@chromium.org, kyungjunle...@google.com, kaklilu+watch-...@chromium.org, asvitki...@chromium.org, jdonnel...@chromium.org, bcb+watch-pl...@chromium.org, cros-ed...@google.com, philli...@chromium.org, print-rev...@chromium.org, hidehik...@chromium.org, stevenjb+wa...@chromium.org, xlythe+wa...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Remove superfluous callback.h includes from //chrome headers"

    This reverts commit 902f4bbfac86c31b03fa5db7c2fc9c68c371171c.

    Reason for revert: In order to check that this CL doesn't really affect any failures of:
    PluginVmInstallerDownloadServiceTest.*
    PluginVmInstallerDriveTest.*
    PluginVmManagerImplTest.*
    https://ci.chromium.org/ui/b/8698446718854618721
    https://ci.chromium.org/ui/b/8698437841855785665
    Disclaimer: I understand that this CL just removed redundant #includes and shouldn't affect any behavioral changes, but this is the only one CL touching //chrome/browser/ash/plugin_vm/ recently. Let me revert this CL to confirm that this CL is not really related to the test failures. [Purely theoretically a missing #include could cause a missing template definition and could change a behavior.]

    Original change's description:
    > Remove superfluous callback.h includes from //chrome headers
    >
    > Remove unused includes mostly found by heuristics in headers that do not
    > contain keywords like "Callback" or "Closure".
    >
    > Bug: 40318405
    > Change-Id: I4cc8a9cb5a3aaf3b8d149360eb4ebd5cb002f92a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7139543
    > Reviewed-by: Victor Vianna <victor...@google.com>
    > Commit-Queue: Daniel Cheng <dch...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1543439}
    Bug: 40318405
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I08dd51dd27413971d29b842d6c1a5346994f0c45
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Auto-Submit: Yuki Shiino <yukis...@chromium.org>
    Owners-Override: Yuki Shiino <yukis...@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1543567}
    Files:
    • M chrome/browser/ash/account_manager/account_manager_edu_coexistence_controller.h
    • M chrome/browser/ash/arc/input_method_manager/arc_input_method_state.h
    • M chrome/browser/ash/exo/chrome_data_exchange_delegate.h
    • M chrome/browser/ash/file_manager/io_task_controller.h
    • M chrome/browser/ash/file_system_provider/operation_request_manager.h
    • M chrome/browser/ash/growth/ui_action_performer.h
    • M chrome/browser/ash/input_method/text_field_contextual_info_fetcher.h
    • M chrome/browser/ash/login/demo_mode/demo_mode_idle_handler.h
    • M chrome/browser/ash/login/enrollment/timebound_user_context_holder.h
    • M chrome/browser/ash/login/smart_lock/smart_lock_auth_attempt.h
    • M chrome/browser/ash/login/smart_lock/smart_lock_notification_controller.h
    • M chrome/browser/ash/plugin_vm/plugin_vm_features.h
    • M chrome/browser/ash/printing/enterprise/print_servers_provider.h
    • M chrome/browser/ash/remote_apps/remote_apps_model.h
    • M chrome/browser/ash/wallpaper_handlers/mock_sea_pen_fetcher.h
    • M chrome/browser/component_updater/afp_blocked_domain_list_component_installer.h
    • M chrome/browser/component_updater/iwa_key_distribution_component_installer.h
    • M chrome/browser/contextual_tasks/contextual_tasks_ui_service.h
    • M chrome/browser/devtools/device/adb/mock_adb_server.h
    • M chrome/browser/download/android/download_controller_base.h
    • M chrome/browser/download/android/mock_download_controller.h
    • M chrome/browser/extensions/api/image_writer_private/zip_extractor.h
    • M chrome/browser/extensions/api/settings_private/settings_private_delegate.h
    • M chrome/browser/extensions/theme_installed_infobar_delegate.h
    • M chrome/browser/glic/host/context/glic_share_image_handler.h
    • M chrome/browser/media/router/providers/wired_display/wired_display_presentation_receiver.h
    • M chrome/browser/media_galleries/mtp_read_file_worker.h
    • M chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h
    • M chrome/browser/nearby_sharing/bluetooth_advertising_interval_client.h
    • M chrome/browser/nearby_sharing/contacts/nearby_share_contact_manager.h
    • M chrome/browser/nearby_sharing/contacts/nearby_share_contact_manager_impl.h
    • M chrome/browser/nearby_sharing/instantmessaging/stream_parser.h
    • M chrome/browser/new_tab_page/chrome_colors/chrome_colors_service.h
    • M chrome/browser/notifications/notification_display_queue.h
    • M chrome/browser/notifications/scheduler/internal/display_decider.h
    • M chrome/browser/password_manager/android/grouped_affiliations/acknowledge_grouped_credential_sheet_controller_test_helper.h
    • M chrome/browser/picture_in_picture/scoped_picture_in_picture_occlusion_observation.h
    • M chrome/browser/policy/messaging_layer/util/upload_response_parser.h
    • M chrome/browser/preloading/preview/preview_test_util.h
    • M chrome/browser/resource_coordinator/tab_load_tracker.h
    • M chrome/browser/screen_ai/screen_ai_install_state.h
    • M chrome/browser/ssl/chrome_security_state_tab_helper.h
    • M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h
    • M chrome/browser/sync_file_system/local/syncable_file_operation_runner.h
    • M chrome/browser/ui/android/fast_checkout/fast_checkout_view_impl.h
    • M chrome/browser/ui/android/webid/account_selection_view_android.h
    • M chrome/browser/ui/ash/network/tether_notification_presenter.h
    • M chrome/browser/ui/autofill/autofill_suggestion_controller_test_base.h
    • M chrome/browser/ui/interventions/intervention_infobar_delegate.h
    • M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
    • M chrome/browser/ui/plus_addresses/android/all_plus_addresses_bottom_sheet_view.h
    • M chrome/browser/ui/screen_capture_notification_ui.h
    • M chrome/browser/ui/sharing_hub/fake_sharing_hub_bubble_controller.h
    • M chrome/browser/ui/tab_modal_confirm_dialog_delegate.h
    • M chrome/browser/ui/views/frame/browser_frame_header_chromeos.h
    • M chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h
    • M chrome/browser/ui/views/safe_browsing/tailored_security_unconsented_modal.h
    • M chrome/browser/ui/views/toolbar/toolbar_action_view.h
    • M chrome/browser/ui/views/webid/account_selection_bubble_view.h
    • M chrome/browser/ui/webui/nearby_internals/quick_pair/quick_pair_handler.h
    • M chrome/browser/ui/webui/signin/managed_user_profile_notice_ui.h
    • M chrome/browser/ui/webui/top_chrome/preload_candidate_selector.h
    • M chrome/browser/unexpire_flags.h
    • M chrome/browser/vr/elements/transient_element.h
    • M chrome/browser/vr/elements/ui_element.h
    • M chrome/browser/vr/test/ui_utils.h
    • M chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration.h
    • M chrome/common/profiler/native_unwinder_android_map_delegate_impl.h
    • M chrome/renderer/net/net_error_helper.h
    • M chrome/renderer/net/net_error_helper_core.h
    • M chrome/renderer/supervised_user/supervised_user_error_page_controller.h
    • M chrome/test/accessibility/ax_client/ax_client_uia.h
    • M chrome/test/chromedriver/chrome/web_view_impl.h
    • M chrome/updater/win/task_scheduler.h
    • M chrome/utility/safe_browsing/rar_analyzer.h
    • M chrome/utility/safe_browsing/seven_zip_analyzer.h
    • M chrome/utility/safe_browsing/zip_analyzer.h
    Change size: M
    Delta: 77 files changed, 79 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I08dd51dd27413971d29b842d6c1a5346994f0c45
    Gerrit-Change-Number: 7144264
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Lei Zhang (Gerrit)

    unread,
    Nov 12, 2025, 12:13:20 PMNov 12
    to Yuki Shiino, Chromium LUCI CQ, Rubber Stamper, AyeAye, Lei Zhang, Daniel Cheng, Thiabaud Engelbrecht, Tommy Li, chromium...@chromium.org, Kaan Icer, Nikhil Nayunigari, Sean Maher, Enterprise Policy Reviews, prerendering-reviews, devtools...@chromium.org, Mathias Bynens, Sophie Chang, Christian Biesinger, (Julie)Jeongeun Kim, Peter Beverloo, npm+...@chromium.org, tranbaod...@chromium.org, suetfei+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, pushi+wat...@google.com, jonmann+wa...@chromium.org, hsuregan+wa...@chromium.org, hansberry+w...@chromium.org, hansberry+w...@chromium.org, storage...@chromium.org, dclasson+w...@google.com, net-r...@chromium.org, feature-v...@chromium.org, hansenmichael...@google.com, chromium-a...@chromium.org, kinuko+...@chromium.org, cros-enterpris...@chromium.org, dmurph+watc...@chromium.org, jkeitel+watch-...@google.com, dibyapal+wa...@chromium.org, yigu+...@chromium.org, marimatthew+watc...@google.com, asumane...@google.com, khorimoto+w...@chromium.org, filesapp...@chromium.org, jackshira+w...@google.com, mreichhoff+watc...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, hais+wat...@google.com, francisjp...@google.com, mgiuca...@chromium.org, kuragin+web-ap...@chromium.org, gcasto+w...@chromium.org, feature-me...@chromium.org, omnibox-...@chromium.org, shuche...@chromium.org, dtraino...@chromium.org, josiah...@chromium.org, gavin...@chromium.org, loyso...@chromium.org, tburkar...@chromium.org, zelin+watch-we...@chromium.org, bhartmire+w...@google.com, chromiumme...@microsoft.com, webap...@microsoft.com, ejcaruso+wa...@chromium.org, rhalava...@chromium.org, jiajunz+wa...@google.com, ajayramamurth...@google.com, cros-report...@google.com, nektar...@chromium.org, extension...@chromium.org, yhanad...@chromium.org, dtseng...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, jackshira+w...@google.com, mtomas...@chromium.org, rrsilva+wat...@google.com, jasonrhee+w...@google.com, mfoltz+wa...@chromium.org, nona+...@chromium.org, hirokisa...@chromium.org, chadduffin+w...@chromium.org, keithle...@chromium.org, yhanada+...@chromium.org, minap+watch-p...@google.com, rginda...@chromium.org, crost...@chromium.org, crisrael+w...@google.com, arc-review...@google.com, yuzo+...@chromium.org, ajayramamurth...@google.com, abigailbk...@google.com, jackshira+w...@google.com, mfoltz+wa...@chromium.org, kyungjunle...@google.com, kaklilu+watch-...@chromium.org, asvitki...@chromium.org, jdonnel...@chromium.org, bcb+watch-pl...@chromium.org, cros-ed...@google.com, philli...@chromium.org, print-rev...@chromium.org, hidehik...@chromium.org, stevenjb+wa...@chromium.org, xlythe+wa...@google.com

    Lei Zhang added 1 comment

    Commit Message
    Line 17, Patchset 2 (Latest):Disclaimer: I understand that this CL just removed redundant #includes and shouldn't affect any behavioral changes, but this is the only one CL touching //chrome/browser/ash/plugin_vm/ recently. Let me revert this CL to confirm that this CL is not really related to the test failures. [Purely theoretically a missing #include could cause a missing template definition and could change a behavior.]
    Lei Zhang . resolved

    I see the red bot went green later, but the run that went green didn't contain this revert.

    From the logs, it looks like the PluginVm tests were failing because LSAN decided a StatisticsProviderImpl instantiation was leaking. That code is in //chromeos/ash.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Comment-Date: Wed, 12 Nov 2025 17:13:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Yuki Shiino (Gerrit)

    unread,
    Nov 12, 2025, 9:08:45 PMNov 12
    to Yuki Shiino, Chromium LUCI CQ, Rubber Stamper, AyeAye, Lei Zhang, Daniel Cheng, Thiabaud Engelbrecht, Tommy Li, chromium...@chromium.org, Kaan Icer, Nikhil Nayunigari, Sean Maher, Enterprise Policy Reviews, prerendering-reviews, devtools...@chromium.org, Mathias Bynens, Sophie Chang, Christian Biesinger, (Julie)Jeongeun Kim, Peter Beverloo, npm+...@chromium.org, tranbaod...@chromium.org, suetfei+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, pushi+wat...@google.com, jonmann+wa...@chromium.org, hsuregan+wa...@chromium.org, hansberry+w...@chromium.org, hansberry+w...@chromium.org, storage...@chromium.org, dclasson+w...@google.com, net-r...@chromium.org, feature-v...@chromium.org, hansenmichael...@google.com, chromium-a...@chromium.org, kinuko+...@chromium.org, cros-enterpris...@chromium.org, dmurph+watc...@chromium.org, jkeitel+watch-...@google.com, dibyapal+wa...@chromium.org, yigu+...@chromium.org, marimatthew+watc...@google.com, asumane...@google.com, khorimoto+w...@chromium.org, filesapp...@chromium.org, jackshira+w...@google.com, mreichhoff+watc...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, hais+wat...@google.com, francisjp...@google.com, mgiuca...@chromium.org, kuragin+web-ap...@chromium.org, gcasto+w...@chromium.org, feature-me...@chromium.org, omnibox-...@chromium.org, shuche...@chromium.org, dtraino...@chromium.org, josiah...@chromium.org, gavin...@chromium.org, loyso...@chromium.org, tburkar...@chromium.org, zelin+watch-we...@chromium.org, bhartmire+w...@google.com, chromiumme...@microsoft.com, webap...@microsoft.com, ejcaruso+wa...@chromium.org, rhalava...@chromium.org, jiajunz+wa...@google.com, ajayramamurth...@google.com, cros-report...@google.com, nektar...@chromium.org, extension...@chromium.org, yhanad...@chromium.org, dtseng...@chromium.org, chrome-gr...@chromium.org, dewitt...@chromium.org, jackshira+w...@google.com, mtomas...@chromium.org, rrsilva+wat...@google.com, jasonrhee+w...@google.com, mfoltz+wa...@chromium.org, nona+...@chromium.org, hirokisa...@chromium.org, chadduffin+w...@chromium.org, keithle...@chromium.org, yhanada+...@chromium.org, minap+watch-p...@google.com, rginda...@chromium.org, crost...@chromium.org, crisrael+w...@google.com, arc-review...@google.com, yuzo+...@chromium.org, ajayramamurth...@google.com, abigailbk...@google.com, jackshira+w...@google.com, mfoltz+wa...@chromium.org, kyungjunle...@google.com, kaklilu+watch-...@chromium.org, asvitki...@chromium.org, jdonnel...@chromium.org, bcb+watch-pl...@chromium.org, cros-ed...@google.com, philli...@chromium.org, print-rev...@chromium.org, hidehik...@chromium.org, stevenjb+wa...@chromium.org, xlythe+wa...@google.com

    Yuki Shiino added 1 comment

    Commit Message
    Line 17, Patchset 2 (Latest):Disclaimer: I understand that this CL just removed redundant #includes and shouldn't affect any behavioral changes, but this is the only one CL touching //chrome/browser/ash/plugin_vm/ recently. Let me revert this CL to confirm that this CL is not really related to the test failures. [Purely theoretically a missing #include could cause a missing template definition and could change a behavior.]
    Lei Zhang . resolved

    I see the red bot went green later, but the run that went green didn't contain this revert.

    From the logs, it looks like the PluginVm tests were failing because LSAN decided a StatisticsProviderImpl instantiation was leaking. That code is in //chromeos/ash.

    Yuki Shiino

    Thanks for the confirmation and investigation. Please re-land this CL. I really appreciate your patience and cooperations.

    Gerrit-Comment-Date: Thu, 13 Nov 2025 02:08:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages