chrome/browser/permissions: fix missing deps [chromium/src : main]

2 views
Skip to first unread message

Takuto Ikuta (Gerrit)

unread,
1:21 AM (14 hours ago) 1:21 AM
to Takuto Ikuta, Hidehiko Abe, Erik Chen, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, blundell+...@chromium.org, chrome-gr...@chromium.org, dominickn+wat...@chromium.org
Attention needed from Erik Chen and Hidehiko Abe

Takuto Ikuta voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I81b4c56293043db04cc2aeadf047bea80fdcd6b2
Gerrit-Change-Number: 5716288
Gerrit-PatchSet: 2
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Erik Chen <erik...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Jul 2024 05:21:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Chen (Gerrit)

unread,
1:52 AM (14 hours ago) 1:52 AM
to Takuto Ikuta, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, blundell+...@chromium.org, chrome-gr...@chromium.org, dominickn+wat...@chromium.org
Attention needed from Hidehiko Abe and Takuto Ikuta

Erik Chen added 1 comment

File chrome/browser/resource_coordinator/BUILD.gn
Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Takuto Ikuta
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I81b4c56293043db04cc2aeadf047bea80fdcd6b2
    Gerrit-Change-Number: 5716288
    Gerrit-PatchSet: 2
    Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Jul 2024 05:51:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takuto Ikuta (Gerrit)

    unread,
    3:32 AM (12 hours ago) 3:32 AM
    to Takuto Ikuta, AyeAye, Hidehiko Abe, Erik Chen, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, extension...@chromium.org, chromium-a...@chromium.org, hashimo...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, dominickn+wat...@chromium.org
    Attention needed from Erik Chen and Hidehiko Abe

    Takuto Ikuta voted and added 1 comment

    Votes added by Takuto Ikuta

    Auto-Submit+1

    1 comment

    File chrome/browser/resource_coordinator/BUILD.gn
    Line 26, Patchset 2: sources = [ "tab_lifecycle_observer.h" ]
    Erik Chen . resolved
    Takuto Ikuta

    Thanks, done.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Erik Chen
    • Hidehiko Abe
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I81b4c56293043db04cc2aeadf047bea80fdcd6b2
    Gerrit-Change-Number: 5716288
    Gerrit-PatchSet: 3
    Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Attention: Erik Chen <erik...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Jul 2024 07:32:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Erik Chen <erik...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Erik Chen (Gerrit)

    unread,
    3:39 AM (12 hours ago) 3:39 AM
    to Takuto Ikuta, AyeAye, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, extension...@chromium.org, chromium-a...@chromium.org, hashimo...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, dominickn+wat...@chromium.org
    Attention needed from Hidehiko Abe and Takuto Ikuta

    Erik Chen voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Takuto Ikuta
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I81b4c56293043db04cc2aeadf047bea80fdcd6b2
    Gerrit-Change-Number: 5716288
    Gerrit-PatchSet: 3
    Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Jul 2024 07:38:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    4:04 AM (11 hours ago) 4:04 AM
    to Takuto Ikuta, Erik Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, extension...@chromium.org, chromium-a...@chromium.org, hashimo...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, dominickn+wat...@chromium.org
    Attention needed from Takuto Ikuta

    Hidehiko Abe voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Takuto Ikuta
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I81b4c56293043db04cc2aeadf047bea80fdcd6b2
    Gerrit-Change-Number: 5716288
    Gerrit-PatchSet: 3
    Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Jul 2024 08:03:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    4:05 AM (11 hours ago) 4:05 AM
    to Takuto Ikuta, Hidehiko Abe, Erik Chen, AyeAye, chromium...@chromium.org, Permissions Reviews, extension...@chromium.org, chromium-a...@chromium.org, hashimo...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, dominickn+wat...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    chrome/browser/permissions: fix missing deps

    This is to fix build error like
    https://ci.chromium.org/ui/p/chromium/builders/build/android-build-perf-ninja/1361/overview
    Bug: 40253918
    Change-Id: I81b4c56293043db04cc2aeadf047bea80fdcd6b2
    Commit-Queue: Takuto Ikuta <tik...@chromium.org>
    Auto-Submit: Takuto Ikuta <tik...@chromium.org>
    Commit-Queue: Erik Chen <erik...@chromium.org>
    Reviewed-by: Erik Chen <erik...@chromium.org>
    Reviewed-by: Hidehiko Abe <hide...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1328696}
    Files:
    • M chrome/browser/BUILD.gn
    • M chrome/browser/ash/dbus/BUILD.gn
    • M chrome/browser/extensions/BUILD.gn
    • M chrome/browser/permissions/BUILD.gn
    • M chrome/browser/resource_coordinator/BUILD.gn
    Change size: S
    Delta: 5 files changed, 12 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Hidehiko Abe, +1 by Erik Chen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I81b4c56293043db04cc2aeadf047bea80fdcd6b2
    Gerrit-Change-Number: 5716288
    Gerrit-PatchSet: 4
    Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages