Fix byte_count.h headers in //chrome/browser [chromium/src : main]

0 views
Skip to first unread message

Eshwar Stalin (Gerrit)

unread,
Jul 9, 2026, 5:19:07 PM (6 days ago) Jul 9
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, rrsilva+wat...@google.com, tote-eng...@google.com
Attention needed from Joe Mason

Eshwar Stalin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e8accde55853120b6b0eb18e4abc14dc2a40ba1
Gerrit-Change-Number: 8070544
Gerrit-PatchSet: 1
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 21:18:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joe Mason (Gerrit)

unread,
Jul 9, 2026, 5:29:50 PM (6 days ago) Jul 9
to Eshwar Stalin, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, rrsilva+wat...@google.com, tote-eng...@google.com

Joe Mason voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e8accde55853120b6b0eb18e4abc14dc2a40ba1
Gerrit-Change-Number: 8070544
Gerrit-PatchSet: 1
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 21:29:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 9, 2026, 6:38:35 PM (6 days ago) Jul 9
to Eshwar Stalin, chromium...@chromium.org, chrome-gr...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, rrsilva+wat...@google.com, tote-eng...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix byte_count.h headers in //chrome/browser

Fixes IWYU errors in files that were converted from ByteCount to
ByteSize without updating the includes.
Bug: 448661443
Change-Id: I8e8accde55853120b6b0eb18e4abc14dc2a40ba1
Reviewed-by: Eshwar Stalin <est...@chromium.org>
Auto-Submit: Joe Mason <joenot...@google.com>
Commit-Queue: Joe Mason <joenot...@google.com>
Cr-Commit-Position: refs/heads/main@{#1659904}
Files:
  • M chrome/browser/chrome_content_browser_client.cc
  • M chrome/browser/memory/oom_memory_details.cc
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
  • M chrome/browser/task_manager/providers/browser_process_task.cc
  • M chrome/browser/task_manager/providers/browser_process_task.h
  • M chrome/browser/task_manager/providers/child_process_task.cc
  • M chrome/browser/task_manager/providers/child_process_task.h
  • M chrome/browser/task_manager/providers/task.h
  • M chrome/browser/task_manager/providers/web_contents/renderer_task.cc
  • M chrome/browser/task_manager/providers/web_contents/renderer_task.h
  • M chrome/browser/task_manager/sampling/task_group.cc
  • M chrome/browser/task_manager/sampling/task_group.h
  • M chrome/browser/task_manager/sampling/task_group_sampler.h
  • M chrome/browser/task_manager/sampling/task_manager_impl.cc
  • M chrome/browser/task_manager/sampling/task_manager_impl.h
  • M chrome/browser/task_manager/task_manager_interface.cc
  • M chrome/browser/task_manager/task_manager_tester.cc
  • M chrome/browser/task_manager/test_task_manager.h
  • M chrome/browser/ui/ash/holding_space/holding_space_downloads_delegate.cc
  • M chrome/browser/ui/views/plugin_vm/plugin_vm_installer_view.cc
  • M chrome/browser/ui/webui/ash/crostini_installer/crostini_installer_ui.cc
  • M chrome/browser/ui/webui/ash/settings/pages/crostini/crostini_section.cc
  • M chrome/browser/ui/webui/ash/settings/pages/files/google_drive_page_handler.cc
  • M chrome/browser/ui/webui/ash/settings/pages/storage/device_storage_handler.cc
  • M chrome/browser/ui/webui/ash/settings/pages/storage/device_storage_handler_unittest.cc
  • M chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
Change size: M
Delta: 27 files changed, 24 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Eshwar Stalin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e8accde55853120b6b0eb18e4abc14dc2a40ba1
Gerrit-Change-Number: 8070544
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages