Fix include guard presubmit warnings [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
11:33 AM (8 hours ago) 11:33 AM
to Avi Drissman, SLSA Policy Verification Service, chromium...@chromium.org, Hans Wennborg, Sadrul Chowdhury, Enterprise Policy Reviews, Zijie He, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, browser-comp...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, jimmyxgong+watch...@chromium.org, network-ser...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, gfhuan...@chromium.org, chromiumme...@microsoft.com, joeantonetti+wa...@google.com, ios-revie...@chromium.org, keithle...@chromium.org, cc-...@chromium.org, hidehik...@chromium.org, filesapp...@chromium.org, net-r...@chromium.org, feature-v...@chromium.org, mpdento...@chromium.org, chrome-intell...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, tranbaod...@chromium.org, chromium-a...@chromium.org, chrome-gr...@chromium.org, halliwe...@chromium.org, msrame...@chromium.org, arc-review...@google.com, ios-r...@chromium.org, nwoked...@chromium.org, jdeblas...@chromium.org, ajayramamurthy+w...@google.com, kinuko...@chromium.org, dullweb...@chromium.org, roblia...@chromium.org, yhanada+...@chromium.org, blink-re...@chromium.org, fuchsia...@chromium.org, dkrahn...@chromium.org, chromeos-gfx-...@google.com, croissant-...@chromium.org, extension...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, marq+...@chromium.org, oshima...@chromium.org, jonmann+watc...@chromium.org, blink-...@chromium.org, nona+...@chromium.org, vaapi-...@chromium.org, mattreyno...@chromium.org, yhanad...@chromium.org, media-cro...@chromium.org, mac-r...@chromium.org
Attention needed from Avi Drissman

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Victor Vianna . resolved

Avi, please take a look and OO+1 if it looks good to you

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I765467f184ee89b8ba9bf9889756e175512f6b73
Gerrit-Change-Number: 8203984
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Aug 2026 15:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
11:44 AM (8 hours ago) 11:44 AM
to Victor Vianna, Avi Drissman, SLSA Policy Verification Service, chromium...@chromium.org, Hans Wennborg, Sadrul Chowdhury, Enterprise Policy Reviews, Zijie He, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, browser-comp...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, jimmyxgong+watch...@chromium.org, network-ser...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, gfhuan...@chromium.org, chromiumme...@microsoft.com, joeantonetti+wa...@google.com, ios-revie...@chromium.org, keithle...@chromium.org, cc-...@chromium.org, hidehik...@chromium.org, filesapp...@chromium.org, net-r...@chromium.org, feature-v...@chromium.org, mpdento...@chromium.org, chrome-intell...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, tranbaod...@chromium.org, chromium-a...@chromium.org, chrome-gr...@chromium.org, halliwe...@chromium.org, msrame...@chromium.org, arc-review...@google.com, ios-r...@chromium.org, nwoked...@chromium.org, jdeblas...@chromium.org, ajayramamurthy+w...@google.com, kinuko...@chromium.org, dullweb...@chromium.org, roblia...@chromium.org, yhanada+...@chromium.org, blink-re...@chromium.org, fuchsia...@chromium.org, dkrahn...@chromium.org, chromeos-gfx-...@google.com, croissant-...@chromium.org, extension...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, marq+...@chromium.org, oshima...@chromium.org, jonmann+watc...@chromium.org, blink-...@chromium.org, nona+...@chromium.org, vaapi-...@chromium.org, mattreyno...@chromium.org, yhanad...@chromium.org, media-cro...@chromium.org, mac-r...@chromium.org
Attention needed from Victor Vianna

Avi Drissman voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I765467f184ee89b8ba9bf9889756e175512f6b73
    Gerrit-Change-Number: 8203984
    Gerrit-PatchSet: 4
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hans Wennborg <ha...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 15:44:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    11:45 AM (8 hours ago) 11:45 AM
    to Victor Vianna, Avi Drissman, SLSA Policy Verification Service, chromium...@chromium.org, Hans Wennborg, Sadrul Chowdhury, Enterprise Policy Reviews, Zijie He, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, browser-comp...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, jimmyxgong+watch...@chromium.org, network-ser...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, gfhuan...@chromium.org, chromiumme...@microsoft.com, joeantonetti+wa...@google.com, ios-revie...@chromium.org, keithle...@chromium.org, cc-...@chromium.org, hidehik...@chromium.org, filesapp...@chromium.org, net-r...@chromium.org, feature-v...@chromium.org, mpdento...@chromium.org, chrome-intell...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, tranbaod...@chromium.org, chromium-a...@chromium.org, chrome-gr...@chromium.org, halliwe...@chromium.org, msrame...@chromium.org, arc-review...@google.com, ios-r...@chromium.org, nwoked...@chromium.org, jdeblas...@chromium.org, ajayramamurthy+w...@google.com, kinuko...@chromium.org, dullweb...@chromium.org, roblia...@chromium.org, yhanada+...@chromium.org, blink-re...@chromium.org, fuchsia...@chromium.org, dkrahn...@chromium.org, chromeos-gfx-...@google.com, croissant-...@chromium.org, extension...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, marq+...@chromium.org, oshima...@chromium.org, jonmann+watc...@chromium.org, blink-...@chromium.org, nona+...@chromium.org, vaapi-...@chromium.org, mattreyno...@chromium.org, yhanad...@chromium.org, media-cro...@chromium.org, mac-r...@chromium.org
    Attention needed from Victor Vianna

    Avi Drissman voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Victor Vianna
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I765467f184ee89b8ba9bf9889756e175512f6b73
    Gerrit-Change-Number: 8203984
    Gerrit-PatchSet: 4
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hans Wennborg <ha...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 15:44:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    11:45 AM (8 hours ago) 11:45 AM
    to Avi Drissman, SLSA Policy Verification Service, chromium...@chromium.org, Hans Wennborg, Sadrul Chowdhury, Enterprise Policy Reviews, Zijie He, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, browser-comp...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, jimmyxgong+watch...@chromium.org, network-ser...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, gfhuan...@chromium.org, chromiumme...@microsoft.com, joeantonetti+wa...@google.com, ios-revie...@chromium.org, keithle...@chromium.org, cc-...@chromium.org, hidehik...@chromium.org, filesapp...@chromium.org, net-r...@chromium.org, feature-v...@chromium.org, mpdento...@chromium.org, chrome-intell...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, tranbaod...@chromium.org, chromium-a...@chromium.org, chrome-gr...@chromium.org, halliwe...@chromium.org, msrame...@chromium.org, arc-review...@google.com, ios-r...@chromium.org, nwoked...@chromium.org, jdeblas...@chromium.org, ajayramamurthy+w...@google.com, kinuko...@chromium.org, dullweb...@chromium.org, roblia...@chromium.org, yhanada+...@chromium.org, blink-re...@chromium.org, fuchsia...@chromium.org, dkrahn...@chromium.org, chromeos-gfx-...@google.com, croissant-...@chromium.org, extension...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, marq+...@chromium.org, oshima...@chromium.org, jonmann+watc...@chromium.org, blink-...@chromium.org, nona+...@chromium.org, vaapi-...@chromium.org, mattreyno...@chromium.org, yhanad...@chromium.org, media-cro...@chromium.org, mac-r...@chromium.org
    Attention needed from Avi Drissman

    Victor Vianna voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 15:45:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:27 PM (2 hours ago) 5:27 PM
    to Victor Vianna, Avi Drissman, SLSA Policy Verification Service, chromium...@chromium.org, Hans Wennborg, Sadrul Chowdhury, Enterprise Policy Reviews, Zijie He, Peter Beverloo, android-bu...@system.gserviceaccount.com, browser-comp...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, jackshira+wat...@google.com, jimmyxgong+watch...@chromium.org, network-ser...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, gfhuan...@chromium.org, chromiumme...@microsoft.com, joeantonetti+wa...@google.com, ios-revie...@chromium.org, keithle...@chromium.org, cc-...@chromium.org, hidehik...@chromium.org, filesapp...@chromium.org, net-r...@chromium.org, feature-v...@chromium.org, mpdento...@chromium.org, chrome-intell...@chromium.org, print-rev...@chromium.org, asvitki...@chromium.org, tranbaod...@chromium.org, chromium-a...@chromium.org, chrome-gr...@chromium.org, halliwe...@chromium.org, msrame...@chromium.org, arc-review...@google.com, ios-r...@chromium.org, nwoked...@chromium.org, jdeblas...@chromium.org, ajayramamurthy+w...@google.com, kinuko...@chromium.org, dullweb...@chromium.org, roblia...@chromium.org, yhanada+...@chromium.org, blink-re...@chromium.org, fuchsia...@chromium.org, dkrahn...@chromium.org, chromeos-gfx-...@google.com, croissant-...@chromium.org, extension...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, marq+...@chromium.org, oshima...@chromium.org, jonmann+watc...@chromium.org, blink-...@chromium.org, nona+...@chromium.org, vaapi-...@chromium.org, mattreyno...@chromium.org, yhanad...@chromium.org, media-cro...@chromium.org, mac-r...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix include guard presubmit warnings

    `git cl presubmit --all` reported 185 CheckForIncludeGuards warnings on
    headers that predate the check or drifted from it.
    Bug: 542921651
    Change-Id: I765467f184ee89b8ba9bf9889756e175512f6b73
    Owners-Override: Avi Drissman <a...@chromium.org>
    Commit-Queue: Victor Vianna <victor...@google.com>
    SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Reviewed-by: Avi Drissman <a...@chromium.org>
    Auto-Submit: Victor Vianna <victor...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1674510}
    Files:
    • M ash/public/cpp/keyboard/keyboard_switches.h
    • M ash/wallpaper/online_wallpaper_variant_info_fetcher.h
    • M ash/webui/common/trusted_types_test_util.h
    • M base/test/scoped_chromeos_version_info.h
    • M base/test/scoped_running_on_chromeos.h
    • M base/third_party/cityhash/city.h
    • M chrome/browser/android/browsing_data/url_filter_bridge.h
    • M chrome/browser/ash/app_list/arc/arc_vpn_provider_manager.h
    • M chrome/browser/ash/arc/test/test_arc_session_manager.h
    • M chrome/browser/ash/attestation/tpm_challenge_key_result.h
    • M chrome/browser/ash/drive/drivefs_native_message_host_ash.h
    • M chrome/browser/ash/input_method/assistive_window_properties.h
    • M chrome/browser/ash/notifications/tpm_auto_update_notification.h
    • M chrome/browser/chromeos/drivefs/drivefs_native_message_host.h
    • M chrome/browser/chromeos/extensions/login_screen/login/cleanup/clipboard_cleanup_handler.h
    • M chrome/browser/chromeos/extensions/login_screen/login/cleanup/extension_cleanup_handler.h
    • M chrome/browser/chromeos/extensions/login_screen/login/cleanup/pinned_apps_cleanup_handler.h
    • M chrome/browser/chromeos/extensions/login_screen/login/cleanup/print_jobs_cleanup_handler.h
    • M chrome/browser/chromeos/extensions/login_screen/login/cleanup/web_app_cleanup_handler.h
    • M chrome/browser/chromeos/policy/dlp/dlp_download_observer_factory.h
    • M chrome/browser/notifications/metrics/notification_metrics_logger.h
    • M chrome/browser/optimization_guide/model_validator_keyed_service_factory.h
    • M chrome/browser/resource_coordinator/resource_coordinator_parts.h
    • M chrome/browser/ui/ash/input_method/assistive_delegate.h
    • M chrome/browser/vr/pose_util.h
    • M chromecast/base/metrics/grouped_histogram.h
    • M chromecast/common/queryable_data.h
    • M chromecast/device/bluetooth/le/ble_notification_logger.h
    • M chromecast/graphics/gestures/cast_gesture_handler.h
    • M chromecast/metrics/mock_cast_event_builder.h
    • M chromecast/public/bluetooth/le_scanner.h
    • M chromeos/ash/components/auth_panel/impl/factor_auth_view.h
    • M chromeos/ash/services/device_sync/cryptauth_device_activity_getter.h
    • M chromeos/ash/services/device_sync/cryptauth_device_notifier.h
    • M chromeos/ash/services/device_sync/cryptauth_device_notifier_impl.h
    • M chromeos/ash/services/device_sync/cryptauth_feature_status_getter.h
    • M chromeos/ash/services/device_sync/cryptauth_feature_status_setter.h
    • M chromeos/ash/services/device_sync/cryptauth_feature_status_setter_impl.h
    • M chromeos/ash/services/device_sync/cryptauth_group_private_key_sharer.h
    • M chromeos/ash/services/device_sync/cryptauth_group_private_key_sharer_impl.h
    • M chromeos/ash/services/device_sync/fake_cryptauth_device_notifier.h
    • M chromeos/ash/services/device_sync/fake_cryptauth_feature_status_getter.h
    • M chromeos/ash/services/device_sync/fake_cryptauth_feature_status_setter.h
    • M chromeos/ash/services/device_sync/fake_cryptauth_group_private_key_sharer.h
    • M chromeos/ash/services/device_sync/feature_status_change.h
    • M chromeos/ash/services/device_sync/group_private_key_and_better_together_metadata_status.h
    • M chromeos/ui/frame/caption_buttons/frame_back_button.h
    • M chromeos/ui/frame/caption_buttons/frame_center_button.h
    • M components/autofill/content/renderer/a11y_utils.h
    • M components/autofill/content/renderer/focus_test_utils.h
    • M components/domain_reliability/google_configs.h
    • M components/embedder_support/android/util/response_delegate_impl.h
    • M components/gcm_driver/gcm_driver_constants.h
    • M components/history/core/test/thumbnail-inl.h
    • M components/optimization_guide/core/noisy_metrics_recorder.h
    • M components/password_manager/core/browser/password_manager_setting.h
    • M components/policy/core/common/cloud/mock_signing_service.h
    • M components/policy/core/common/cloud/signing_service.h
    • M components/remote_cocoa/app_shim/NSToolbar+Private.h
    • M components/url_formatter/spoof_checks/top_domains/test_top_bucket_domains.h
    • M components/url_formatter/spoof_checks/top_domains/top_bucket_domains.h
    • M components/viz/test/surface_id_allocator_set.h
    • M content/browser/media/audible_metrics.h
    • M fuchsia_web/webinstance_host/fuchsia_web_debug_proxy.h
    • M gpu/command_buffer/common/gpu_memory_allocation.h
    • M ios/chrome/browser/shared/ui/animated_promo/animated_promo_utils.h
    • M media/gpu/vaapi/vaapi_image_decoder_test_common.h
    • M net/dns/dns_platform_android_attempt.h
    • M net/dns/netinet_in_var_ios.h
    • M net/http/http_response_body_drainer.h
    • M net/proxy_resolution/proxy_config_service_android.h
    • M printing/backend/cups_weak_functions.h
    • M sandbox/linux/syscall_broker/broker_client.h
    • M sandbox/linux/syscall_broker/broker_file_permission.h
    • M sandbox/linux/syscall_broker/broker_host.h
    • M sandbox/policy/linux/landlock_util.h
    • M services/network/trust_tokens/pending_trust_token_store.h
    • M testing/platform_test.h
    • M third_party/blink/public/common/metrics/accept_language_and_content_language_usage.h
    • M third_party/blink/public/common/security/security_style.h
    • M third_party/blink/public/common/user_agent/user_agent_brand_version_type.h
    • M tools/clang/blink_gc_plugin/BadPatternFinder.h
    • M tools/clang/blink_gc_plugin/DiagnosticsReporter.h
    • M tools/clang/blink_gc_plugin/JsonWriter.h
    • M tools/clang/blink_gc_plugin/NeedsTracing.h
    • M tools/clang/blink_gc_plugin/TracingStatus.h
    • M tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.h
    • M tools/clang/blink_gc_plugin/tests/base_requires_tracing.h
    • M tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.h
    • M tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.h
    • M tools/clang/blink_gc_plugin/tests/class_overrides_new.h
    • M tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h
    • M tools/clang/blink_gc_plugin/tests/class_requires_trace_method_tmpl.h
    • M tools/clang/blink_gc_plugin/tests/crash_on_invalid.h
    • M tools/clang/blink_gc_plugin/tests/cycle_ptrs.h
    • M tools/clang/blink_gc_plugin/tests/cycle_sub.h
    • M tools/clang/blink_gc_plugin/tests/cycle_super.h
    • M tools/clang/blink_gc_plugin/tests/cycle_super_neg.h
    • M tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.h
    • M tools/clang/blink_gc_plugin/tests/fields_illegal_tracing.h
    • M tools/clang/blink_gc_plugin/tests/fields_require_tracing.h
    • M tools/clang/blink_gc_plugin/tests/finalize_after_dispatch.h
    • M tools/clang/blink_gc_plugin/tests/forbidden_fields.h
    • M tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h
    • M tools/clang/blink_gc_plugin/tests/heap/stubs.h
    • M tools/clang/blink_gc_plugin/tests/ignore_class.h
    • M tools/clang/blink_gc_plugin/tests/ignore_fields.h
    • M tools/clang/blink_gc_plugin/tests/inner_class.h
    • M tools/clang/blink_gc_plugin/tests/left_most_gc_base.h
    • M tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h
    • M tools/clang/blink_gc_plugin/tests/non_virtual_trace.h
    • M tools/clang/blink_gc_plugin/tests/part_object_to_gc_derived_class.h
    • M tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.h
    • M tools/clang/blink_gc_plugin/tests/persistent_no_trace.h
    • M tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h
    • M tools/clang/blink_gc_plugin/tests/pure_virtual_trace.h
    • M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h
    • M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class_error.h
    • M tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.h
    • M tools/clang/blink_gc_plugin/tests/stack_allocated.h
    • M tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.h
    • M tools/clang/blink_gc_plugin/tests/trace_after_dispatch.h
    • M tools/clang/blink_gc_plugin/tests/trace_collections.h
    • M tools/clang/blink_gc_plugin/tests/trace_if_needed.h
    • M tools/clang/blink_gc_plugin/tests/trace_if_needed_resolved.h
    • M tools/clang/blink_gc_plugin/tests/trace_templated_super.h
    • M tools/clang/blink_gc_plugin/tests/traceimpl.h
    • M tools/clang/blink_gc_plugin/tests/unique_ptr_to_gc_managed_class.h
    • M tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.h
    • M tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.h
    • M tools/clang/plugins/tests/inline_copy_ctor.h
    • M tools/clang/plugins/tests/third_party/blink/public/public.h
    • M tools/clang/raw_ptr_plugin/tests/bad_raw_ptr_main.h
    • M tools/clang/raw_ptr_plugin/tests/bad_raw_ptr_unrelated.h
    • M tools/clang/raw_ptr_plugin/tests/third_party/blink/public/public.h
    • M tools/clang/rewrite_raw_ptr_fields/tests/base/containers/span.h
    • M tools/clang/rewrite_to_chrome_style/EditTracker.h
    • M tools/clang/rewrite_to_chrome_style/tests/gen/thing.h
    • M tools/mac/power/power_sampler/smc_sampler.h
    • M tools/strict_enum_value_checker/changed_file_1.h
    • M tools/strict_enum_value_checker/changed_file_10.h
    • M tools/strict_enum_value_checker/changed_file_2.h
    • M tools/strict_enum_value_checker/changed_file_3.h
    • M tools/strict_enum_value_checker/changed_file_4.h
    • M tools/strict_enum_value_checker/changed_file_5.h
    • M tools/strict_enum_value_checker/changed_file_6.h
    • M tools/strict_enum_value_checker/changed_file_7.h
    • M tools/strict_enum_value_checker/changed_file_8.h
    • M tools/strict_enum_value_checker/changed_file_9.h
    • M tools/strict_enum_value_checker/mock_enum.h
    • M ui/base/x/x11_clipboard_helper.h
    • M ui/events/test/test_event_handler.h
    • M ui/gfx/x/wm_sync.h
    • M ui/gfx/x/xproto_internal.h
    • M ui/gl/gl_version_info.h
    • M ui/views/controls/menu/menu_pre_target_handler.h
    • M ui/views/win/test_support/fake_ipen_device.h
    • M ui/views/win/test_support/fake_ipen_device_statics.h
    Change size: L
    Delta: 158 files changed, 207 insertions(+), 175 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Avi Drissman
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I765467f184ee89b8ba9bf9889756e175512f6b73
    Gerrit-Change-Number: 8203984
    Gerrit-PatchSet: 5
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages