Cleanup: Remove unnecessary base/compiler_specific.h [chromium/src : main]

0 views

Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,

Oct 31, 2025, 8:57:09 AM (5 days ago) Oct 31

to Sadrul Chowdhury, Thiabaud Engelbrecht, Raphael Kubo da Costa, Wanming Lin, Rijubrata Bhaumik, Hu, Ningxin, chromium...@chromium.org, Jiewei Qian, Sean Maher, Peter Beverloo, agriev...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, roblia...@chromium.org, torne...@chromium.org, chrome-gr...@chromium.org, bartek...@chromium.org, pasko...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, mattreyno...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, gab+...@chromium.org, asvitki...@chromium.org, grt+...@chromium.org, network-ser...@chromium.org, chromium-a...@chromium.org, mpdento...@chromium.org, lizeb...@chromium.org, fuzzin...@chromium.org, pdf-r...@chromium.org, marinacio...@chromium.org, rsesek...@chromium.org, chromiumme...@microsoft.com, yfriedm...@chromium.org, fdoray...@chromium.org, nyquis...@chromium.org, mac-r...@chromium.org, filesapp...@chromium.org, olka+...@chromium.org, extension...@chromium.org

Arthur Sonzogni has uploaded the change for review

Commit message

Cleanup: Remove unnecessary base/compiler_specific.h

This CL programmatically removes unnecessary #include directives for
base/compiler_specific.h, which contains 43 macros, from files that do
not use any of the functionality it provides.

This header is still in use, but over time, specific macro uses
(like UNSAFE_TODO) have been removed from various files. The
corresponding #include directives were often left behind.

Manually checking for removable includes after each small change (e.g.,
removing a single UNSAFE_TODO use) is inefficient. A scripted,
programmatic cleanup is preferable to periodically remove these
obsolete includes, which reduces unnecessary dependencies and
improves build hygiene.

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).

Script: https://docs.google.com/document/d/1kou4RitvP4aB5eHI3CjOsRUEemaQ4dd1k-QUnDBbMhs/edit?usp=sharing

AX-Relnotes: N/A

Bug: 435317390

Change-Id: I0bde7a17a461d333038a976a2a7524ac2b1cb268

Change diff

Change information

Files:

M base/allocator/dispatcher/reentry_guard.cc
M base/allocator/partition_alloc_features.h
M base/android/android_info.cc
M base/android/apk_info.cc
M base/android/device_info.cc
M base/android/jni_android.h
M base/android/task_scheduler/task_runner_android.cc
M base/apple/mach_port_rendezvous_mac.cc
M base/atomicops.h
M base/big_endian.h
M base/cancelable_callback.h
M base/check_deref.h
M base/check_example.cc
M base/files/important_file_writer_unittest.cc
M base/functional/bind.h
M base/i18n/streaming_utf8_validator_perftest.cc
M base/message_loop/fd_watch_controller_posix_unittest.cc
M base/message_loop/message_pump_epoll.cc
M base/metrics/histogram.h
M base/metrics/histogram_samples.cc
M base/metrics/sample_vector.cc
M base/observer_list_threadsafe_unittest.cc
M base/posix/file_descriptor_shuffle.h
M base/power_monitor/power_observer.h
M base/process/memory_unittest.cc
M base/profiler/stack_sampler.cc
M base/profiler/stack_sampling_profiler_unittest.cc
M base/profiler/stack_unwind_data.cc
M base/profiler/win32_stack_frame_unwinder_unittest.cc
M base/rand_util.h
M base/safe_numerics_unittest.cc
M base/sampling_heap_profiler/poisson_allocation_sampler.cc
M base/sequence_checker_impl.cc
M base/strings/string_number_conversions_internal.h
M base/synchronization/lock_metrics_recorder.h
M base/synchronization/lock_perftest.cc
M base/synchronization/waitable_event.cc
M base/synchronization/waitable_event_unittest.cc
M base/synchronization/waitable_event_watcher_win.cc
M base/task/common/checked_lock_unittest.cc
M base/task/deferred_sequenced_task_runner.h
M base/task/sequence_manager/task_queue_impl.cc
M base/task/sequence_manager/task_queue_selector_unittest.cc
M base/task/task_runner.cc
M base/task/thread_pool/thread_pool_impl.cc
M base/test/null_task_runner.h
M base/test/simple_test_clock.h
M base/test/simple_test_tick_clock.h
M base/test/test_io_thread.h
M base/test/test_message_loop.cc
M base/test/test_reg_util_win_unittest.cc
M base/test/test_simple_task_runner.h
M base/threading/platform_thread_linux.cc
M base/threading/platform_thread_unittest.cc
M base/threading/scoped_thread_priority.h
M base/threading/simple_thread.h
M base/threading/thread_collision_warner.h
M base/threading/thread_collision_warner_unittest.cc
M base/threading/thread_local_storage.cc
M base/threading/watchdog.cc
M base/threading/watchdog.h
M base/time/default_clock.h
M base/time/pr_time_unittest.cc
M base/time/time_unittest.cc
M base/trace_event/heap_profiler.h
M base/types/expected_macros.h
M base/uuid.cc
M base/win/message_window.cc
M base/win/message_window.h
M base/win/registry_unittest.cc
M base/win/security_descriptor.cc
M extensions/browser/api/declarative/deduping_factory.h
M extensions/browser/api/declarative/rules_registry.h
M extensions/browser/api/declarative_webrequest/webrequest_action.h
M extensions/browser/api/management/management_api.h
M extensions/browser/api/messaging/message_service.h
M extensions/browser/api/storage/local_value_store_cache.h
M extensions/browser/api/storage/settings_storage_quota_enforcer.h
M extensions/browser/api/storage/settings_test_util.h
M extensions/browser/api/storage/storage_api.h
M extensions/browser/api/storage/weak_unlimited_settings_storage.h
M extensions/browser/event_router.h
M extensions/browser/event_router_unittest.cc
M extensions/browser/extension_error.h
M extensions/browser/extension_protocols.cc
M extensions/browser/extension_registry.h
M extensions/browser/extension_registry_factory.h
M extensions/browser/extension_web_contents_observer.h
M extensions/browser/image_loader.cc
M extensions/browser/lazy_background_task_queue.h
M extensions/browser/null_app_sorting.h
M extensions/browser/process_map_factory.h
M extensions/browser/renderer_startup_helper.h
M extensions/browser/test_extensions_browser_client.h
M extensions/browser/updater/extension_downloader.h
M extensions/browser/updater/request_queue_impl.h
M extensions/browser/user_script_loader.h
M extensions/common/features/feature_flags.cc
M extensions/renderer/activity_log_converter_strategy.h
M extensions/renderer/api/automation/automation_internal_custom_bindings.h
M extensions/renderer/api/file_system_natives.h
M extensions/renderer/api/web_request_natives.h
M extensions/renderer/binding_generating_native_handler.h
M extensions/renderer/console.cc
M extensions/renderer/module_system.h
M extensions/renderer/native_extension_bindings_system.cc
M extensions/renderer/runtime_custom_bindings.h
M extensions/renderer/script_context.h
M extensions/renderer/script_context_set.cc
M extensions/renderer/static_v8_external_one_byte_string_resource.h
M extensions/shell/app/shell_main_delegate.h
M extensions/shell/browser/default_shell_browser_main_delegate.h
M extensions/shell/browser/shell_app_window_client.h
M extensions/shell/browser/shell_browser_main_parts.h
M extensions/shell/browser/shell_content_browser_client.h
M extensions/shell/browser/shell_desktop_controller_aura.h
M extensions/shell/browser/shell_extension_system.h
M extensions/shell/browser/shell_extensions_browser_client.h
M extensions/shell/browser/shell_network_controller_chromeos.h
M extensions/shell/renderer/shell_content_renderer_client.h
M google_apis/calendar/calendar_api_response_types.h
M google_apis/common/dummy_auth_service.h
M google_apis/drive/drive_api_parser.h
M google_apis/gaia/fake_oauth2_access_token_manager.h
M google_apis/gaia/oauth_multilogin_result.cc
M google_apis/gcm/base/fake_encryptor.h
M google_apis/gcm/base/socket_stream.h
M google_apis/gcm/tools/mcs_probe.cc
M pdf/loader/data_document_loader.cc
M pdf/loader/url_loader_wrapper_impl.cc
M pdf/pdfium/pdfium_page_unittest.cc
M pdf/pdfium/pdfium_searchify.cc
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc
M sandbox/linux/services/init_process_reaper.cc
M sandbox/linux/services/yama_unittest.cc
M sandbox/linux/syscall_broker/broker_permission_list.cc
M sandbox/linux/tests/scoped_temporary_file_unittest.cc
M sandbox/policy/linux/bpf_cros_arm_gpu_policy_linux.cc
M sandbox/policy/linux/bpf_gpu_policy_linux.cc
M sandbox/win/src/broker_services.h
M sandbox/win/src/crosscall_client.h
M sandbox/win/src/policy_low_level.cc
M sandbox/win/src/policy_opcodes_unittest.cc
M services/audio/input_controller.cc
M services/audio/mixing_graph_impl.cc
M services/audio/output_controller.cc
M services/audio/processing_audio_fifo_unittest.cc
M services/audio/public/cpp/output_device_unittest.cc
M services/audio/snooper_node_unittest.cc
M services/audio/sync_reader.h
M services/device/generic_sensor/platform_sensor_provider_linux.cc
M services/device/geolocation/fake_location_provider.cc
M services/device/geolocation/fake_location_provider.h
M services/device/geolocation/geolocation_provider_impl.h
M services/device/geolocation/location_provider_android.h
M services/device/geolocation/wifi_data_provider_chromeos.h
M services/device/hid/hid_service_linux.h
M services/device/hid/input_service_linux.h
M services/device/public/cpp/geolocation/location_provider.h
M services/network/proxy_resolving_client_socket.cc
M services/network/proxy_resolving_client_socket.h
M services/network/proxy_resolving_client_socket_unittest.cc
M services/network/resource_scheduler/resource_scheduler.h
M services/network/restricted_cookie_manager.cc
M services/network/session_cleanup_cookie_store.h
M services/network/web_bundle/web_bundle_chunked_buffer.h
M services/preferences/public/cpp/tracked/mock_validation_delegate.h
M services/preferences/tracked/pref_hash_filter.h
M services/preferences/tracked/pref_hash_filter_unittest.cc
M services/preferences/tracked/pref_hash_store_impl.h
M services/preferences/tracked/tracked_atomic_preference.h
M services/preferences/tracked/tracked_split_preference.h
M services/proxy_resolver/proxy_resolver_v8.cc
M services/proxy_resolver/proxy_resolver_v8.h
M services/proxy_resolver/proxy_resolver_v8_unittest.cc
M services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h
M services/tracing/public/cpp/perfetto/traced_value_proto_writer_unittest.cc
M services/viz/public/cpp/gpu/context_provider_command_buffer.h
M services/webnn/tflite/tensor_impl_tflite.cc
M testing/libfuzzer/fuzzers/v8_fuzzer.cc
M tools/android/forwarder2/device_forwarder_main.cc
M tools/android/forwarder2/device_listener.h
M tools/android/forwarder2/host_controller.h

Change size: L

Delta: 183 files changed, 0 insertions(+), 309 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Arthur Sonzogni (Gerrit)

unread,

Oct 31, 2025, 9:44:01 AM (5 days ago) Oct 31

to Raphael Kubo da Costa, Wanming Lin, devtools...@chromium.org, Rijubrata Bhaumik, Hu, Ningxin, chromium...@chromium.org, Hiroki Nakagawa, Jiewei Qian, Peter Beverloo, agriev...@chromium.org, spang...@chromium.org, iclella...@chromium.org, chadduffin+wa...@chromium.org, chrome-gr...@chromium.org, twifka...@chromium.org, jiajunz+wat...@google.com, horo+...@chromium.org, creis...@chromium.org, hsuregan+wat...@chromium.org, mattreyno...@chromium.org, tracing...@chromium.org, hansberry+wa...@chromium.org, khorimoto+wa...@chromium.org, feature-me...@chromium.org, wfh+...@chromium.org, jackshira+wa...@google.com, storage...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, network-ser...@chromium.org, scheduler-b...@chromium.org, mfoltz+wa...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, chfreme...@chromium.org, dmurph+wa...@chromium.org, chasej...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, marinacio...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, blink-work...@chromium.org, servicewor...@chromium.org, edgesto...@microsoft.com, derinel+wat...@google.com, nikhilcn+wat...@google.com, navigation...@chromium.org, enne...@chromium.org, jophba...@chromium.org, ajwong...@chromium.org, olka+...@chromium.org, hayato...@chromium.org, shimazu+se...@chromium.org

Arthur Sonzogni has uploaded the change for review

Commit message

Cleanup: Remove unnecessary base/compiler_specific.h

This CL programmatically removes unnecessary #include directives for
base/compiler_specific.h, which contains 43 macros, from files that do
not use any of the functionality it provides.

This header is still in use, but over time, specific macro uses
(like UNSAFE_TODO) have been removed from various files. The
corresponding #include directives were often left behind.

Manually checking for removable includes after each small change (e.g.,
removing a single UNSAFE_TODO use) is inefficient. A scripted,
programmatic cleanup is preferable to periodically remove these
obsolete includes, which reduces unnecessary dependencies and
improves build hygiene.

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).

Script: https://docs.google.com/document/d/1kou4RitvP4aB5eHI3CjOsRUEemaQ4dd1k-QUnDBbMhs/edit?usp=sharing

AX-Relnotes: N/A

Bug: 435317390

Change-Id: Ib781579f777e3064be51257c4562767c7f0d14e9

Change diff

Change information

Files:

M content/browser/android/devtools_auth.cc
M content/browser/back_forward_cache_browsertest.h
M content/browser/browser_process_io_thread.cc
M content/browser/byte_stream_unittest.cc
M content/browser/cache_storage/cache_storage_cache.cc
M content/browser/cache_storage/cache_storage_cache_unittest.cc
M content/browser/cache_storage/cache_storage_dispatcher_host.cc
M content/browser/code_cache/generated_code_cache_unittest.cc
M content/browser/devtools/devtools_http_handler.cc
M content/browser/devtools/devtools_stream_file.cc
M content/browser/devtools/protocol_unittest.cc
M content/browser/file_system_access/file_system_access_manager_impl.cc
M content/browser/gpu/gpu_process_host.cc
M content/browser/indexed_db/indexed_db_leveldb_coding.cc
M content/browser/indexed_db/instance/leveldb/indexed_db_leveldb_operations.cc
M content/browser/interest_group/auction_worklet_manager.cc
M content/browser/loader/merkle_integrity_source_stream.cc
M content/browser/network_context_client_base_impl_unittest.cc
M content/browser/notifications/notification_database_conversions_unittest.cc
M content/browser/plugin_service_impl.cc
M content/browser/renderer_host/media/media_stream_manager.cc
M content/browser/scheduler/responsiveness/jank_monitor_impl.cc
M content/browser/service_worker/service_worker_installed_script_reader.cc
M content/browser/service_worker/service_worker_registration_unittest.cc
M content/browser/service_worker/service_worker_updated_script_loader.cc
M content/browser/site_instance_impl_unittest.cc
M content/browser/speech/soda_speech_recognition_engine_impl.cc
M content/browser/web_contents/web_contents_delegate_unittest.cc
M content/browser/web_package/prefetched_signed_exchange_cache.cc
M content/browser/web_package/signed_exchange_prologue.cc
M content/browser/web_package/signed_exchange_signature_header_field.cc
M content/browser/webauth/authenticator_impl_unittest.cc
M content/common/common_param_traits_unittest.cc
M content/common/content_switches_internal.cc
M content/common/features.h
M content/public/browser/web_contents_delegate.cc
M content/public/test/content_test_suite_base.cc
M content/public/test/fenced_frame_test_util.h
M content/public/test/test_download_http_response.cc
M content/public/test/test_file_error_injector.cc
M content/renderer/dom_serializer_browsertest.cc
M content/renderer/render_process_impl.cc
M content/shell/browser/shell_download_manager_delegate.cc
M content/test/test_render_frame_host_factory.cc
M content/web_test/browser/web_test_origin_trial_throttle.cc
M content/web_test/renderer/gamepad_controller.cc
M content/web_test/renderer/web_test_grammar_checker.cc
M content/web_test/renderer/web_test_spell_checker.cc
M content/zygote/zygote_linux.cc
M content/zygote/zygote_main_linux.cc
M device/base/device_info_query_win.cc
M device/bluetooth/android/outcome.cc
M device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc
M device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc
M device/bluetooth/dbus/bluetooth_gatt_descriptor_service_provider_impl.cc
M device/bluetooth/emulation/fake_bluetooth.h
M device/bluetooth/emulation/fake_central.h
M device/bluetooth/emulation/fake_peripheral.h
M device/bluetooth/floss/floss_adapter_client_unittest.cc
M device/bluetooth/floss/floss_admin_client_unittest.cc
M device/bluetooth/floss/floss_dbus_client.cc
M device/fido/pin.cc
M device/fido/virtual_ctap2_device.cc
M device/gamepad/gamepad_monitor.h
M device/gamepad/gamepad_platform_data_fetcher.h
M device/gamepad/gamepad_platform_data_fetcher_linux.h
M device/gamepad/gamepad_user_gesture.cc
M device/gamepad/public/cpp/gamepad_mojom_traits.cc
M device/gamepad/xinput_data_fetcher_win.h
M mojo/core/channel.h
M mojo/core/ports/message_queue.cc
M mojo/core/trap_unittest.cc
M mojo/public/cpp/bindings/connector.h
M mojo/public/cpp/bindings/message_header_validator.h
M mojo/public/cpp/bindings/pipe_control_message_handler.h
M mojo/public/cpp/system/buffer.h
M mojo/public/cpp/system/message_pipe.h

M skia/ext/image_operations_unittest.cc
M skia/ext/rgba_to_yuva.cc
M storage/browser/blob/view_blob_internals_job.cc
M storage/browser/file_system/file_stream_reader.h
M storage/browser/file_system/local_file_util.h
M storage/browser/file_system/sandbox_file_system_backend.h
M storage/browser/file_system/sandbox_quota_observer.h
M storage/browser/quota/quota_task.h
M storage/browser/test/mock_file_change_observer.h
M storage/browser/test/mock_file_update_observer.h
M storage/browser/test/mock_quota_client.h

M tools/android/forwarder2/device_forwarder_main.cc
M tools/android/forwarder2/device_listener.h
M tools/android/forwarder2/host_controller.h

Change size: M

Delta: 127 files changed, 0 insertions(+), 220 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages