Modularize //chrome/browser/metrics [chromium/src : main]

0 views
Skip to first unread message

Erik Chen (Gerrit)

unread,
Apr 21, 2026, 2:15:03 AM (4 days ago) Apr 21
to Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, croissant-...@chromium.org, cros-setti...@google.com, dewitt...@chromium.org, dmurph+wat...@chromium.org, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jkeitel+watch-...@google.com, keithle...@chromium.org, mreichhoff+watc...@chromium.org, nona+...@chromium.org, petewi...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, yhanada+...@chromium.org
Attention needed from Thomas Lukaszewicz

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f549eb8cf92bcf0074946706625f46f27f0fb93
Gerrit-Change-Number: 7777321
Gerrit-PatchSet: 3
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 06:14:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexei Svitkine (Gerrit)

unread,
Apr 21, 2026, 10:23:24 AM (4 days ago) Apr 21
to Erik Chen, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, croissant-...@chromium.org, cros-setti...@google.com, dewitt...@chromium.org, dmurph+wat...@chromium.org, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jkeitel+watch-...@google.com, keithle...@chromium.org, mreichhoff+watc...@chromium.org, nona+...@chromium.org, petewi...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, yhanada+...@chromium.org
Attention needed from Erik Chen and Thomas Lukaszewicz

Alexei Svitkine added 1 comment

File chrome/browser/metrics/BUILD.gn
Line 381, Patchset 3 (Latest): "structured/arena_event_buffer.cc",
Alexei Svitkine . unresolved

Could we modularize further by having e.g. c/b/metrics/structured be its own thing?

Maybe can be a TODO + bug to not delay this CL.

Similar for:
desktop_session_duration/
usage_scenario/
power/
perf/

Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
  • Thomas Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1f549eb8cf92bcf0074946706625f46f27f0fb93
    Gerrit-Change-Number: 7777321
    Gerrit-PatchSet: 3
    Gerrit-Owner: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Attention: Erik Chen <erik...@chromium.org>
    Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 14:23:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Erik Chen (Gerrit)

    unread,
    Apr 21, 2026, 11:06:32 AM (4 days ago) Apr 21
    to Alexei Svitkine, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, croissant-...@chromium.org, cros-setti...@google.com, dewitt...@chromium.org, dmurph+wat...@chromium.org, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jkeitel+watch-...@google.com, keithle...@chromium.org, mreichhoff+watc...@chromium.org, nona+...@chromium.org, petewi...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, yhanada+...@chromium.org
    Attention needed from Alexei Svitkine and Thomas Lukaszewicz

    Erik Chen added 1 comment

    File chrome/browser/metrics/BUILD.gn
    Line 381, Patchset 3: "structured/arena_event_buffer.cc",
    Alexei Svitkine . resolved

    Could we modularize further by having e.g. c/b/metrics/structured be its own thing?

    Maybe can be a TODO + bug to not delay this CL.

    Similar for:
    desktop_session_duration/
    usage_scenario/
    power/
    perf/

    Erik Chen

    I filed: https://b.corp.google.com/issues/504980566 and added a TODO to the top of this file.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexei Svitkine
    • Thomas Lukaszewicz
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1f549eb8cf92bcf0074946706625f46f27f0fb93
      Gerrit-Change-Number: 7777321
      Gerrit-PatchSet: 4
      Gerrit-Owner: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
      Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
      Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
      Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
      Gerrit-Comment-Date: Tue, 21 Apr 2026 15:06:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Alexei Svitkine <asvi...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Thomas Lukaszewicz (Gerrit)

      unread,
      Apr 21, 2026, 2:33:16 PM (4 days ago) Apr 21
      to Erik Chen, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, croissant-...@chromium.org, cros-setti...@google.com, dewitt...@chromium.org, dmurph+wat...@chromium.org, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jkeitel+watch-...@google.com, keithle...@chromium.org, mreichhoff+watc...@chromium.org, nona+...@chromium.org, petewi...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, yhanada+...@chromium.org
      Attention needed from Alexei Svitkine and Erik Chen

      Thomas Lukaszewicz voted and added 2 comments

      Votes added by Thomas Lukaszewicz

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 3:
      Thomas Lukaszewicz . resolved

      lgtm

      File chrome/browser/metrics/tab_stats/tab_stats_data_store.h
      Line 19, Patchset 3:#include "chrome/browser/resource_coordinator/lifecycle_unit_state.mojom.h" // nogncheck
      Thomas Lukaszewicz . unresolved

      nit: I believe we can drop this nogncheck by adding `"//chrome/browser/resource_coordinator:mojo_bindings"` to `public_deps` in `chrome/browser/metrics/BUILD.gn`

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alexei Svitkine
      • Erik Chen
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I1f549eb8cf92bcf0074946706625f46f27f0fb93
        Gerrit-Change-Number: 7777321
        Gerrit-PatchSet: 5
        Gerrit-Owner: Erik Chen <erik...@chromium.org>
        Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
        Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
        Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
        Gerrit-Attention: Erik Chen <erik...@chromium.org>
        Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
        Gerrit-Comment-Date: Tue, 21 Apr 2026 18:32:45 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Erik Chen (Gerrit)

        unread,
        Apr 21, 2026, 2:58:00 PM (4 days ago) Apr 21
        to Thomas Lukaszewicz, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, croissant-...@chromium.org, cros-setti...@google.com, dewitt...@chromium.org, dmurph+wat...@chromium.org, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jkeitel+watch-...@google.com, keithle...@chromium.org, mreichhoff+watc...@chromium.org, nona+...@chromium.org, petewi...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, yhanada+...@chromium.org
        Attention needed from Alexei Svitkine

        Erik Chen voted and added 1 comment

        Votes added by Erik Chen

        Commit-Queue+2

        1 comment

        File chrome/browser/metrics/tab_stats/tab_stats_data_store.h
        Line 19, Patchset 3:#include "chrome/browser/resource_coordinator/lifecycle_unit_state.mojom.h" // nogncheck
        Thomas Lukaszewicz . resolved

        nit: I believe we can drop this nogncheck by adding `"//chrome/browser/resource_coordinator:mojo_bindings"` to `public_deps` in `chrome/browser/metrics/BUILD.gn`

        Erik Chen

        will send you a followup CL shortly.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alexei Svitkine
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I1f549eb8cf92bcf0074946706625f46f27f0fb93
          Gerrit-Change-Number: 7777321
          Gerrit-PatchSet: 5
          Gerrit-Owner: Erik Chen <erik...@chromium.org>
          Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
          Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
          Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
          Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
          Gerrit-Comment-Date: Tue, 21 Apr 2026 18:57:51 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Thomas Lukaszewicz <tl...@chromium.org>
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Apr 21, 2026, 3:02:41 PM (4 days ago) Apr 21
          to Erik Chen, Thomas Lukaszewicz, Alexei Svitkine, chromium...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, croissant-...@chromium.org, cros-setti...@google.com, dewitt...@chromium.org, dmurph+wat...@chromium.org, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jkeitel+watch-...@google.com, keithle...@chromium.org, mreichhoff+watc...@chromium.org, nona+...@chromium.org, petewi...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org, yhanada+...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          Modularize //chrome/browser/metrics

          This CL refactors the build graph for `chrome/browser/metrics` by moving
          its sources out of the top-level `//chrome/browser` static library into
          dedicated `source_set("metrics")` (public headers) and
          `source_set("impl")` targets within `chrome/browser/metrics/BUILD.gn`.
          Consumer `BUILD.gn` files across the tree are updated to depend directly
          on `//chrome/browser/metrics`, and a parallel split is applied to
          `chrome/browser/updates`. A few `#include` lines gain `// nogncheck`
          annotations and one forward-declaration of
          `glic::GlicSyntheticTrialManager` replaces a header include to break a
          dep cycle. No functional code changes.

          AGENT_GENERATED_CL
          Bug: 353332589
          Change-Id: I1f549eb8cf92bcf0074946706625f46f27f0fb93
          Commit-Queue: Erik Chen <erik...@chromium.org>
          Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1618360}
          Files:
          • M chrome/browser/BUILD.gn
          • M chrome/browser/apps/app_service/BUILD.gn
          • M chrome/browser/ash/arc/optin/BUILD.gn
          • M chrome/browser/ash/growth/BUILD.gn
          • M chrome/browser/ash/input_method/BUILD.gn
          • M chrome/browser/ash/login/BUILD.gn
          • M chrome/browser/ash/login/demo_mode/BUILD.gn
          • M chrome/browser/ash/login/screens/BUILD.gn
          • M chrome/browser/ash/login/session/BUILD.gn
          • M chrome/browser/ash/main_parts/BUILD.gn
          • M chrome/browser/ash/system_web_apps/apps/camera_app/BUILD.gn
          • M chrome/browser/autofill/BUILD.gn
          • M chrome/browser/feed/BUILD.gn
          • M chrome/browser/glic/BUILD.gn
          • M chrome/browser/gpu/BUILD.gn
          • M chrome/browser/metrics/BUILD.gn
          • M chrome/browser/metrics/chrome_metrics_service_accessor.h
          • M chrome/browser/metrics/chrome_metrics_service_client.cc
          • M chrome/browser/metrics/family_link_user_metrics_provider.cc
          • M chrome/browser/metrics/tab_stats/tab_stats_data_store.h
          • M chrome/browser/metrics/tab_stats/tab_stats_tracker.cc
          • M chrome/browser/metrics/tab_stats/tab_stats_tracker.h
          • M chrome/browser/metrics/usage_scenario/video_capture_event_provider.h
          • M chrome/browser/optimization_guide/BUILD.gn
          • M chrome/browser/plus_addresses/BUILD.gn
          • M chrome/browser/regional_capabilities/BUILD.gn
          • M chrome/browser/resource_coordinator/BUILD.gn
          • M chrome/browser/search_engine_choice/BUILD.gn
          • M chrome/browser/segmentation_platform/BUILD.gn
          • M chrome/browser/sync/BUILD.gn
          • M chrome/browser/tab_group_sync/BUILD.gn
          • M chrome/browser/ui/BUILD.gn
          • M chrome/browser/ui/autofill/BUILD.gn
          • M chrome/browser/ui/hats/BUILD.gn
          • M chrome/browser/ui/webui/ash/settings/pages/privacy/BUILD.gn
          • M chrome/browser/ui/webui/ash/settings/services/metrics/BUILD.gn
          • M chrome/browser/updates/BUILD.gn
          Change size: L
          Delta: 37 files changed, 529 insertions(+), 242 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Thomas Lukaszewicz
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I1f549eb8cf92bcf0074946706625f46f27f0fb93
          Gerrit-Change-Number: 7777321
          Gerrit-PatchSet: 6
          Gerrit-Owner: Erik Chen <erik...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
          Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
          Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages