[bedrock] Use GetWindow()->Minimize()/Maximize()/Restore() in chrome/ [chromium/src : main]

0 views
Skip to first unread message

Neil Bao (Gerrit)

unread,
Jun 8, 2026, 8:49:58 PMJun 8
to Thomas Lukaszewicz, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, chrome-gr...@chromium.org, chromeos-kio...@google.com, croissant-...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, estali...@chromium.org, francisjp...@google.com, headless...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, shend...@chromium.org, tranbaod...@chromium.org, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org
Attention needed from Qikai Zhong and Thomas Lukaszewicz

Neil Bao voted and added 1 comment

Votes added by Neil Bao

Auto-Submit+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Neil Bao . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c8546adff578b0c2852c2f04137936e1259a839
Gerrit-Change-Number: 7901981
Gerrit-PatchSet: 1
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 00:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
Jun 8, 2026, 9:27:17 PMJun 8
to Neil Bao, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, chrome-gr...@chromium.org, chromeos-kio...@google.com, croissant-...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, estali...@chromium.org, francisjp...@google.com, headless...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, shend...@chromium.org, tranbaod...@chromium.org, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org
Attention needed from Neil Bao and Qikai Zhong

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
Thomas Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
  • Qikai Zhong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c8546adff578b0c2852c2f04137936e1259a839
Gerrit-Change-Number: 7901981
Gerrit-PatchSet: 1
Gerrit-Owner: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Neil Bao <nei...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 01:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Qikai Zhong (Gerrit)

unread,
Jun 8, 2026, 9:55:31 PMJun 8
to Neil Bao, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, chrome-gr...@chromium.org, chromeos-kio...@google.com, croissant-...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, estali...@chromium.org, francisjp...@google.com, headless...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, shend...@chromium.org, tranbaod...@chromium.org, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org
Attention needed from Neil Bao

Qikai Zhong voted and added 1 comment

Votes added by Qikai Zhong

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Qikai Zhong . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Neil Bao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c8546adff578b0c2852c2f04137936e1259a839
    Gerrit-Change-Number: 7901981
    Gerrit-PatchSet: 1
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Neil Bao <nei...@microsoft.com>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 01:54:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 8, 2026, 11:15:40 PMJun 8
    to Neil Bao, Qikai Zhong, Thomas Lukaszewicz, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, chrome-gr...@chromium.org, chromeos-kio...@google.com, croissant-...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, estali...@chromium.org, francisjp...@google.com, headless...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nicolas...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, shend...@chromium.org, tranbaod...@chromium.org, ydago...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bedrock] Use GetWindow()->Minimize()/Maximize()/Restore() in chrome/

    Phase 1 (cont.): replace browser->window()->{Minimize,Maximize,Restore}()
    with browser->GetWindow()->{Minimize,Maximize,Restore}() across chrome/.

    Step toward eliminating Browser::window(). GetWindow() returns
    ui::BaseWindow*, which is sufficient for these window-state operations.
    No behavior change.
    Bug: 496674143
    Change-Id: I8c8546adff578b0c2852c2f04137936e1259a839
    Auto-Submit: Neil Bao <nei...@microsoft.com>
    Reviewed-by: Qikai Zhong <qikai...@microsoft.com>
    Commit-Queue: Neil Bao <nei...@microsoft.com>
    Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1643649}
    Files:
    • M chrome/browser/ash/accessibility/spoken_feedback_app_list_browsertest.cc
    • M chrome/browser/ash/app_list/app_list_client_impl_browsertest.cc
    • M chrome/browser/ash/app_list/search/help_app_search_browsertest.cc
    • M chrome/browser/ash/browser_delegate/browser_delegate_impl.cc
    • M chrome/browser/ash/integration_tests/screenshot_integration_test.cc
    • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_time_of_day_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_wallpaper_daily_refresh_browsertest.cc
    • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_wallpaper_info_browsertest.cc
    • M chrome/browser/ash/video_conference/video_conference_integration_browsertest.cc
    • M chrome/browser/chromeos/app_mode/kiosk_browser_window_handler.cc
    • M chrome/browser/devtools/devtools_interactive_uitest.cc
    • M chrome/browser/glic/browser_ui/context_sharing_border_view_interactive_uitest.cc
    • M chrome/browser/glic/host/glic_actor_general_interactive_uitest.cc
    • M chrome/browser/glic/host/glic_api_browsertest.cc
    • M chrome/browser/glic/widget/glic_instance_coordinator_interactive_uitest.cc
    • M chrome/browser/headless/test/headless_mode_browsertest_mac.mm
    • M chrome/browser/headless/test/headless_mode_browsertest_win.cc
    • M chrome/browser/performance_manager/policies/page_discarding_helper_browsertest.cc
    • M chrome/browser/picture_in_picture/auto_picture_in_picture_window_occlusion_interactive_uitest.cc
    • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
    • M chrome/browser/sessions/session_restore_browsertest.cc
    • M chrome/browser/sessions/session_restore_browsertest_chromeos.cc
    • M chrome/browser/sessions/session_restore_interactive_uitest.cc
    • M chrome/browser/signin/mirror_interactive_uitest.cc
    • M chrome/browser/ui/ash/app_list/app_list_with_recent_apps_browsertest.cc
    • M chrome/browser/ui/ash/desks/desks_client_browsertest.cc
    • M chrome/browser/ui/ash/desks/desks_templates_app_launch_handler.cc
    • M chrome/browser/ui/ash/keyboard/keyboard_end_to_end_browsertest.cc
    • M chrome/browser/ui/ash/shelf/chrome_shelf_controller_browsertest.cc
    • M chrome/browser/ui/browser_command_controller.cc
    • M chrome/browser/ui/cookie_controls/roll_back_mode_b_infobar_controller_browsertest.cc
    • M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
    • M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
    • M chrome/browser/ui/views/frame/browser_frame_view_chromeos_browsertest.cc
    • M chrome/browser/ui/views/frame/immersive_mode_controller_chromeos_browsertest.cc
    • M chrome/browser/ui/views/tabs/dragging/tab_drag_controller_interactive_uitest.cc
    • M chrome/browser/ui/views/user_education/impl/browser_feature_promo_preconditions_interactive_uitest.cc
    • M chrome/browser/ui/waap/initial_webui_browsertest.cc
    Change size: M
    Delta: 38 files changed, 81 insertions(+), 82 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Qikai Zhong, +1 by Thomas Lukaszewicz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c8546adff578b0c2852c2f04137936e1259a839
    Gerrit-Change-Number: 7901981
    Gerrit-PatchSet: 2
    Gerrit-Owner: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Neil Bao <nei...@microsoft.com>
    Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages