[ResourceCoordinator] Improve os metrics gathering [chromium/src : main]
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
Warning: gwsq did not assign any reviewers.
Related details
- Siddhartha S
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Siddhartha S (Gerrit)
Siddhartha S voted and added 1 comment![]( "Open in Gerrit")
Votes added by Siddhartha S
| Code-Review | +1 |
1 comment
return false;can you do `CHECK(pid == null || pid = current)` ?
When you actually fix the caller to use this for child process, you can remove this check? for now this might help ensure that we do not accidentally break some flow that calls for child process.
Related details
- Dave Tapuska
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Dave Tapuska added 1 comment![]( "Open in Gerrit")
return false;can you do `CHECK(pid == null || pid = current)` ?
When you actually fix the caller to use this for child process, you can remove this check? for now this might help ensure that we do not accidentally break some flow that calls for child process.
I think the ResourceCoordinator will actually fail for this...
Actually calls this method but it was actually getting metrics from the parent process. Adding joenotcharles@ to comment.
Related details
- Joe Mason
- Siddhartha S
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Siddhartha S (Gerrit)
Siddhartha S added 1 comment![]( "Open in Gerrit")
return false;Dave Tapuskacan you do `CHECK(pid == null || pid = current)` ?
When you actually fix the caller to use this for child process, you can remove this check? for now this might help ensure that we do not accidentally break some flow that calls for child process.
I think the ResourceCoordinator will actually fail for this...
Actually calls this method but it was actually getting metrics from the parent process. Adding joenotcharles@ to comment.
hm i guess the existing code was broken then. it always used to fetch mach_task_self(). This cl does not make this worse. So, fine with this change. but Joe can comment.
Related details
- Dave Tapuska
- Joe Mason
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Dave Tapuska voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dave Tapuska
| Commit-Queue | +2 |
1 comment
return false;Dave Tapuskacan you do `CHECK(pid == null || pid = current)` ?
When you actually fix the caller to use this for child process, you can remove this check? for now this might help ensure that we do not accidentally break some flow that calls for child process.
Siddhartha SI think the ResourceCoordinator will actually fail for this...
Actually calls this method but it was actually getting metrics from the parent process. Adding joenotcharles@ to comment.
hm i guess the existing code was broken then. it always used to fetch mach_task_self(). This cl does not make this worse. So, fine with this change. but Joe can comment.
Chatted with Joe. I've created a bug (https://issues.chromium.org/u/1/issues/353039532) so they can track this.
Related details
- Joe Mason
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[ResourceCoordinator] Improve os metrics gathering
Support passing a non-null pid in for Windows. Linux already
supported this.
Add a new API for querying metrics on Apple platforms passing
in a mach_port_t which allows the browser process to query
the metrics of a child process.
- M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics.h
- M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_mac.cc
- M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_win.cc
Code-Review: +1 by Siddhartha S
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |