[webrtc] Use `c/b/permissions/system` for system permissions [chromium/src : main]

0 views
Skip to first unread message

Elias Klim (Gerrit)

unread,
Sep 3, 2024, 12:15:03 PM9/3/24
to Achuith Bhandarkar, Kyle Horimoto, Andy Paicu, Greg Thompson, Guido Urdaneta, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, chrome-gr...@chromium.org, phoglun...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, mac-r...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, rmcelra...@chromium.org, dominickn+wat...@chromium.org
Attention needed from Kyle Horimoto

Elias Klim added 1 comment

Patchset-level comments
File-level comment, Patchset 33 (Latest):
Elias Klim . resolved

@khorimoto I fixed a unit tests, please check chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Horimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id33d4f932c2b97ab0cb3b942d79345f638c62dfc
Gerrit-Change-Number: 5791112
Gerrit-PatchSet: 33
Gerrit-Owner: Elias Klim <el...@chromium.org>
Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
Gerrit-Reviewer: Elias Klim <el...@chromium.org>
Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Sep 2024 12:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kyle Horimoto (Gerrit)

unread,
Sep 3, 2024, 10:04:42 PM9/3/24
to Elias Klim, Kyle Horimoto, Achuith Bhandarkar, Andy Paicu, Greg Thompson, Guido Urdaneta, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, chrome-gr...@chromium.org, phoglun...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, mac-r...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, rmcelra...@chromium.org, dominickn+wat...@chromium.org
Attention needed from Elias Klim

Kyle Horimoto voted and added 1 comment

Votes added by Kyle Horimoto

Code-Review+1

1 comment

Patchset-level comments
Elias Klim . resolved

@khorimoto I fixed a unit tests, please check chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc

Kyle Horimoto

LGTM (didn't review the rest of the CL).

Open in Gerrit

Related details

Attention is currently required from:
  • Elias Klim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id33d4f932c2b97ab0cb3b942d79345f638c62dfc
Gerrit-Change-Number: 5791112
Gerrit-PatchSet: 33
Gerrit-Owner: Elias Klim <el...@chromium.org>
Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
Gerrit-Reviewer: Elias Klim <el...@chromium.org>
Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Elias Klim <el...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Sep 2024 22:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Elias Klim <el...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 4, 2024, 6:15:41 AM9/4/24
to Elias Klim, Kyle Horimoto, Achuith Bhandarkar, Andy Paicu, Greg Thompson, Guido Urdaneta, Rijubrata Bhaumik, Simon Hangl, Andrew Rayskiy, AyeAye, chromium...@chromium.org, Permissions Reviews, chrome-gr...@chromium.org, phoglun...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, mac-r...@chromium.org, feature-me...@chromium.org, chfreme...@chromium.org, rmcelra...@chromium.org, dominickn+wat...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[webrtc] Use `c/b/permissions/system` for system permissions

`c/b/permissions/system` has an implementation for detecting
system-level permission status for all platforms. ‘webrtc’ should
use it so that gUM shares macOS logic on other platforms.
Bug: 359192723
Change-Id: Id33d4f932c2b97ab0cb3b942d79345f638c62dfc
Reviewed-by: Kyle Horimoto <khor...@chromium.org>
Commit-Queue: Elias Klim <el...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350608}
Files:
  • M chrome/browser/ash/privacy_hub/privacy_hub_util.cc
  • M chrome/browser/ash/privacy_hub/privacy_hub_util.h
  • M chrome/browser/content_settings/page_specific_content_settings_delegate.cc
  • M chrome/browser/media/webrtc/BUILD.gn
  • M chrome/browser/media/webrtc/desktop_capture_access_handler.cc
  • M chrome/browser/media/webrtc/display_media_access_handler.cc
  • M chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
  • M chrome/browser/media/webrtc/system_media_capture_permissions_mac.h
  • M chrome/browser/media/webrtc/system_media_capture_permissions_mac.mm
  • M chrome/browser/media/webrtc/system_media_capture_permissions_stats_mac.h
  • M chrome/browser/media/webrtc/system_media_capture_permissions_stats_mac.mm
  • M chrome/browser/media/webrtc/webrtc_getdisplaymedia_browsertest.cc
  • M chrome/browser/permissions/BUILD.gn
  • M chrome/browser/permissions/chrome_permissions_client.cc
  • A chrome/browser/permissions/system/BUILD.gn
  • M chrome/browser/permissions/system/geolocation_observation.cc
  • R chrome/browser/permissions/system/media_authorization_wrapper_mac.h
  • A chrome/browser/permissions/system/system_media_capture_permissions_mac.h
  • A chrome/browser/permissions/system/system_media_capture_permissions_mac.mm
  • M chrome/browser/permissions/system/system_permission_settings_chromeos.cc
  • M chrome/browser/permissions/system/system_permission_settings_mac.cc
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
  • M chrome/browser/ui/BUILD.gn
  • M chrome/browser/ui/content_settings/content_setting_bubble_model.cc
  • M chrome/browser/ui/content_settings/content_setting_image_model.cc
  • M chrome/browser/ui/content_settings/content_setting_media_image_model_unittest.mm
  • M chrome/browser/ui/content_settings/media_authorization_wrapper_test.h
  • M chrome/browser/ui/views/permissions/embedded_permission_prompt.cc
Change size: L
Delta: 28 files changed, 392 insertions(+), 330 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kyle Horimoto
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id33d4f932c2b97ab0cb3b942d79345f638c62dfc
Gerrit-Change-Number: 5791112
Gerrit-PatchSet: 34
Gerrit-Owner: Elias Klim <el...@chromium.org>
Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Elias Klim <el...@chromium.org>
Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages