Revert "Use base::ByteCount in base::SysInfo." [chromium/src : main]

0 views

Skip to first unread message

Peter Pakkenberg (Gerrit)

unread,

Aug 14, 2025, 4:49:16 AMAug 14

to AyeAye, Rubber Stamper, Francois Pierre Doray, Chromium LUCI CQ, Gabriel Charette, chromium...@chromium.org, Will Harris, Andrew Rayskiy, Rijubrata Bhaumik, Thiabaud Engelbrecht, bfcach...@chromium.org, Dirk Schulze, luci-bi...@appspot.gserviceaccount.com, Stephen Chenney, Simon Hangl, Zijie He, Enterprise Policy Reviews, prerendering-reviews, rsesek...@chromium.org, grt+...@chromium.org, lizeb...@chromium.org, lens-chrome...@google.com, cros-report...@google.com, nyquis...@chromium.org, mercer...@google.com, navigation...@chromium.org, kinuko...@chromium.org, blink-reviews-p...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, chrome-gr...@chromium.org, android-web...@chromium.org, kinuko+...@chromium.org, alexmo...@chromium.org, chrome-intelligence-te...@google.com, torne...@chromium.org, feature-me...@chromium.org, tburkar...@chromium.org, creis...@chromium.org, rmcelra...@chromium.org, ios-r...@chromium.org, fmalit...@chromium.org, fuchsia...@chromium.org, asvitki...@chromium.org, fserb...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, chromeos-kio...@google.com, jessemcke...@google.com, mac-r...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, thiabaud+watch-d...@google.com, browser-comp...@chromium.org, spang...@chromium.org, yfriedm...@chromium.org, stanfie...@google.com, blink-...@chromium.org, cc-...@chromium.org, borealis-re...@google.com, glazuno...@chromium.org, marq+...@chromium.org, rouslan+au...@chromium.org, tracing...@chromium.org, chromiumme...@microsoft.com, chfreme...@chromium.org, extension...@chromium.org, wfh+...@chromium.org, chromium-a...@chromium.org, chikamu...@chromium.org, performance-m...@chromium.org, chrome-intell...@chromium.org, bartek...@chromium.org, gavin...@chromium.org, pasko...@chromium.org, rhalava...@chromium.org, ozone-...@chromium.org, drott+bl...@chromium.org, ios-revie...@chromium.org, agriev...@chromium.org

Attention needed from Francois Pierre Doray, Gabriel Charette and Joe Mason

Peter Pakkenberg voted Owners-Override+1

Owners-Override

Open in Gerrit

Related details

Attention is currently required from:

Francois Pierre Doray
Gabriel Charette
Joe Mason

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

Aug 14, 2025, 4:49:21 AMAug 14

to Peter Pakkenberg, AyeAye, Francois Pierre Doray, Chromium LUCI CQ, Gabriel Charette, chromium...@chromium.org, Will Harris, Andrew Rayskiy, Rijubrata Bhaumik, Thiabaud Engelbrecht, bfcach...@chromium.org, Dirk Schulze, luci-bi...@appspot.gserviceaccount.com, Stephen Chenney, Simon Hangl, Zijie He, Enterprise Policy Reviews, prerendering-reviews, rsesek...@chromium.org, grt+...@chromium.org, lizeb...@chromium.org, lens-chrome...@google.com, cros-report...@google.com, nyquis...@chromium.org, mercer...@google.com, navigation...@chromium.org, kinuko...@chromium.org, blink-reviews-p...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, chrome-gr...@chromium.org, android-web...@chromium.org, kinuko+...@chromium.org, alexmo...@chromium.org, chrome-intelligence-te...@google.com, torne...@chromium.org, feature-me...@chromium.org, tburkar...@chromium.org, creis...@chromium.org, rmcelra...@chromium.org, ios-r...@chromium.org, fmalit...@chromium.org, fuchsia...@chromium.org, asvitki...@chromium.org, fserb...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, chromeos-kio...@google.com, jessemcke...@google.com, mac-r...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, thiabaud+watch-d...@google.com, browser-comp...@chromium.org, spang...@chromium.org, yfriedm...@chromium.org, stanfie...@google.com, blink-...@chromium.org, cc-...@chromium.org, borealis-re...@google.com, glazuno...@chromium.org, marq+...@chromium.org, rouslan+au...@chromium.org, tracing...@chromium.org, chromiumme...@microsoft.com, chfreme...@chromium.org, extension...@chromium.org, wfh+...@chromium.org, chromium-a...@chromium.org, chikamu...@chromium.org, performance-m...@chromium.org, chrome-intell...@chromium.org, bartek...@chromium.org, gavin...@chromium.org, pasko...@chromium.org, rhalava...@chromium.org, ozone-...@chromium.org, drott+bl...@chromium.org, ios-revie...@chromium.org, agriev...@chromium.org

Attention needed from Francois Pierre Doray, Gabriel Charette and Joe Mason

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Francois Pierre Doray
Gabriel Charette
Joe Mason

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 14, 2025, 4:49:42 AMAug 14

to Peter Pakkenberg, Rubber Stamper, AyeAye, Francois Pierre Doray, Gabriel Charette, chromium...@chromium.org, Will Harris, Andrew Rayskiy, Rijubrata Bhaumik, Thiabaud Engelbrecht, bfcach...@chromium.org, Dirk Schulze, luci-bi...@appspot.gserviceaccount.com, Stephen Chenney, Simon Hangl, Zijie He, Enterprise Policy Reviews, prerendering-reviews, rsesek...@chromium.org, grt+...@chromium.org, lizeb...@chromium.org, lens-chrome...@google.com, cros-report...@google.com, nyquis...@chromium.org, mercer...@google.com, navigation...@chromium.org, kinuko...@chromium.org, blink-reviews-p...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, chrome-gr...@chromium.org, android-web...@chromium.org, kinuko+...@chromium.org, alexmo...@chromium.org, chrome-intelligence-te...@google.com, torne...@chromium.org, feature-me...@chromium.org, tburkar...@chromium.org, creis...@chromium.org, rmcelra...@chromium.org, ios-r...@chromium.org, fmalit...@chromium.org, fuchsia...@chromium.org, asvitki...@chromium.org, fserb...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, chromeos-kio...@google.com, jessemcke...@google.com, mac-r...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, thiabaud+watch-d...@google.com, browser-comp...@chromium.org, spang...@chromium.org, yfriedm...@chromium.org, stanfie...@google.com, blink-...@chromium.org, cc-...@chromium.org, borealis-re...@google.com, glazuno...@chromium.org, marq+...@chromium.org, rouslan+au...@chromium.org, tracing...@chromium.org, chromiumme...@microsoft.com, chfreme...@chromium.org, extension...@chromium.org, wfh+...@chromium.org, chromium-a...@chromium.org, chikamu...@chromium.org, performance-m...@chromium.org, chrome-intell...@chromium.org, bartek...@chromium.org, gavin...@chromium.org, pasko...@chromium.org, rhalava...@chromium.org, ozone-...@chromium.org, drott+bl...@chromium.org, ios-revie...@chromium.org, agriev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "Use base::ByteCount in base::SysInfo."

This reverts commit 1d9a1d3425f0ab9b5350a70203c03a05ea83eabc.

Reason for revert: https://crbug.com/438649892
    Test failure on `android-arm-tests`

Bug: 429140103
Original change's description:
> Use base::ByteCount in base::SysInfo.
>
> Use base::ByteCount as the return value of
> SysInfo::AmountOfPhysicalMemory() and
> SysInfo::AmountOfAvailablePhysicalMemory() and adjust call sites across
> the codebase. Note that other methods in base::SysInfo could also return
> base::Bytes, but they're not upgraded in this CL to avoid making it
> bigger.
>
> base::ByteCount is a class to make bytes manipulations type safe, easier
> to read and less error-prone.
>
> NO_IFTTT=Code style change in base/system/sys_info.cc, does not affect code behavior.
>
> AX-Relnotes: n/a
> Bug: 429140103
> Change-Id: I540a58b843b1765a61d03bb5d7867b3bf8a2ddd1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6698912
> Reviewed-by: Gabriel Charette <g...@chromium.org>
> Owners-Override: Gabriel Charette <g...@chromium.org>
> Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1501122}

Bug: 429140103

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Change-Id: Id7d43b002ec1529c57a816e1fda14c6ca7ad608e

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6849446

Auto-Submit: Peter Pakkenberg <pb...@chromium.org>

Owners-Override: Peter Pakkenberg <pb...@chromium.org>

Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/heads/main@{#1501264}

Files:

M android_webview/browser/aw_browser_main_parts.cc
M ash/display/window_tree_host_manager.cc
M ash/test/pixel/ash_pixel_test_helper.cc
M base/allocator/miracle_parameter.cc
M base/allocator/miracle_parameter.h
M base/allocator/partition_alloc_support.cc
M base/android/sys_utils_unittest.cc
M base/features.cc
M base/features.h
M base/process/process_metrics_apple.mm
M base/process/process_metrics_unittest.cc
M base/system/sys_info.cc
M base/system/sys_info.h
M base/system/sys_info_apple.mm
M base/system/sys_info_freebsd.cc
M base/system/sys_info_fuchsia.cc
M base/system/sys_info_ios.mm
M base/system/sys_info_linux.cc
M base/system/sys_info_mac.mm
M base/system/sys_info_openbsd.cc
M base/system/sys_info_unittest.cc
M base/system/sys_info_win.cc
M base/test/scoped_amount_of_physical_memory_override.cc
M base/test/scoped_amount_of_physical_memory_override.h
M base/win/hardware_check.cc
M cc/tiles/image_decode_cache_utils.cc
M chrome/browser/android/oom_intervention/oom_intervention_config.cc
M chrome/browser/ash/app_mode/metrics/periodic_metrics_service.cc
M chrome/browser/ash/borealis/borealis_hardware_checker.cc
M chrome/browser/ash/borealis/borealis_hardware_checker_unittest.cc
M chrome/browser/ash/borealis/borealis_survey_handler.cc
M chrome/browser/ash/borealis/borealis_survey_handler_unittest.cc
M chrome/browser/ash/bruschetta/bruschetta_installer_impl.cc
M chrome/browser/ash/bruschetta/bruschetta_installer_impl_unittest.cc
M chrome/browser/ash/policy/status_collector/device_status_collector.cc
M chrome/browser/ash/policy/status_collector/device_status_collector.h
M chrome/browser/feedback/android/system_info_feedback_source.cc
M chrome/browser/media/webrtc/webrtc_text_log_handler.cc
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
M chrome/browser/metrics/structured/storage_manager_impl.cc
M chrome/browser/metrics/usage_scenario/chrome_responsiveness_calculator_delegate.cc
M chrome/browser/performance_manager/chrome_browser_main_extra_parts_performance_manager.cc
M chrome/browser/performance_manager/metrics/metrics_provider_common.cc
M chrome/browser/performance_manager/policies/background_tab_loading_policy.cc
M chrome/browser/policy/site_isolation_policy_browsertest.cc
M chrome/browser/preloading/prefetch/search_prefetch/field_trial_settings.cc
M chrome/browser/preloading/search_preload/search_preload_features.cc
M chrome/browser/resource_coordinator/session_restore_policy.cc
M chrome/browser/site_isolation/chrome_site_isolation_policy_unittest.cc
M chrome/browser/ui/browser_browsertest.cc
M chrome/browser/ui/lens/lens_overlay_entry_point_controller.cc
M chrome/browser/ui/performance_controls/memory_saver_opt_in_iph_controller.cc
M chrome/browser/ui/performance_controls/performance_controls_hats_service.cc
M chrome/browser/ui/views/performance_controls/memory_saver_iph_interactive_uitest.cc
M chromeos/ash/components/memory/swap_configuration.cc
M components/autofill/content/browser/risk/fingerprint.cc
M components/discardable_memory/service/discardable_shared_memory_manager.cc
M components/gwp_asan/client/gwp_asan.cc
M components/metrics/metrics_log.cc
M components/metrics/metrics_log_unittest.cc
M components/miracle_parameter/common/public/miracle_parameter.cc
M components/miracle_parameter/common/public/miracle_parameter.h
M components/miracle_parameter/common/public/miracle_parameter_unittest.cc
M components/segmentation_platform/internal/execution/processing/custom_input_processor.cc
M components/site_isolation/site_isolation_policy.cc
M components/site_isolation/site_isolation_policy_unittest.cc
M components/update_client/protocol_serializer.cc
M components/viz/client/frame_eviction_manager.cc
M content/browser/back_forward_cache_browsertest.cc
M content/browser/network/network_service_util_internal.cc
M content/browser/network/shared_dictionary_util.cc
M content/browser/preloading/prerender/prerender_browsertest.cc
M content/browser/preloading/prerender/prerender_host_registry.cc
M content/browser/renderer_host/navigation_transitions/navigation_entry_screenshot_manager_unittest.cc
M content/browser/renderer_host/navigation_transitions/navigation_transition_config.cc
M content/browser/renderer_host/render_process_host_impl.cc
M content/browser/renderer_host/spare_render_process_host_manager_browsertest.cc
M content/browser/renderer_host/spare_render_process_host_manager_impl.cc
M content/browser/tracing/tracing_controller_impl.cc
M content/child/blink_platform_impl.cc
M content/common/content_navigation_policy.cc
M extensions/browser/api/system_memory/memory_info_provider.cc
M gin/isolate_holder.cc
M gpu/command_buffer/client/shared_memory_limits.h
M gpu/command_buffer/service/service_discardable_manager.cc
M gpu/config/gpu_finch_features.cc
M gpu/config/gpu_util.cc
M gpu/config/skia_limits.cc
M ios/chrome/app/memory_monitor.mm
M media/base/demuxer_memory_limit_android.cc
M net/disk_cache/blockfile/backend_impl.cc
M net/disk_cache/memory/mem_backend_impl.cc
M sandbox/policy/linux/sandbox_linux.cc
M sandbox/policy/win/sandbox_win.cc
M sandbox/policy/win/sandbox_win_unittest.cc
M services/on_device_model/ml/performance_class.cc
M services/on_device_model/public/cpp/cpu.cc
M services/screen_ai/screen_ai_ocr_perf_test.cc
M services/screen_ai/screen_ai_service_impl.cc
M storage/browser/blob/blob_memory_controller.cc
M storage/browser/file_system/obfuscated_file_util_memory_delegate.cc
M storage/browser/quota/quota_device_info_helper.cc
M third_party/blink/common/device_memory/approximated_device_memory.cc
M third_party/blink/renderer/controller/memory_saver_controller.cc
M third_party/blink/renderer/platform/fonts/font_cache.cc
M third_party/blink/renderer/platform/widget/compositing/layer_tree_settings.cc
M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
M ui/gl/gl_surface_egl.cc

Change size: L

Delta: 108 files changed, 392 insertions(+), 421 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages