Francois Pierre Doray (Gerrit)

unread,

Aug 11, 2025, 10:40:12 AMAug 11

to Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Attention needed from Patrick Monette

Francois Pierre Doray voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Patrick Monette

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Patrick Monette (Gerrit)

unread,

Aug 11, 2025, 2:57:24 PMAug 11

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org

Attention needed from Francois Pierre Doray

Patrick Monette voted and added 1 comment

Votes added by Patrick Monette

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Patrick Monette . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Francois Pierre Doray

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 11, 2025, 3:00:09 PMAug 11

to Francois Pierre Doray, Patrick Monette, chromium...@chromium.org, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[resource coordinator] Remove DiscardBeforeUnloadHelper.

It was added by crrev.com/c/1231739. The intent was to detect pages
with a beforeunload handler that returns an empty string, to make
them eligible for discarding. But that was never done.

Related:
https://chromium-review.googlesource.com/c/chromium/src/+/1768322

Bug: 877550

Change-Id: I6530b3f7e7e9c2f82d138353303d4b5f8da314da

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6836151

Auto-Submit: Francois Pierre Doray <fdo...@chromium.org>

Commit-Queue: Patrick Monette <pmon...@chromium.org>

Reviewed-by: Patrick Monette <pmon...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1499731}

Files:

D chrome/browser/resource_coordinator/discard_before_unload_helper.cc
D chrome/browser/resource_coordinator/discard_before_unload_helper.h
D chrome/browser/resource_coordinator/discard_before_unload_helper_browsertest.cc
M chrome/test/BUILD.gn

Change size: L

Delta: 4 files changed, 0 insertions(+), 254 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Patrick Monette

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[resource coordinator] Remove DiscardBeforeUnloadHelper. [chromium/src : main]

Francois Pierre Doray (Gerrit)

Francois Pierre Doray voted

Related details

Patrick Monette (Gerrit)

Patrick Monette voted and added 1 comment

Votes added by Patrick Monette

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information