Prepare to remove services/ from unsafe_buffer_paths.txt [chromium/src : main]

3 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
May 24, 2024, 12:47:45 PMMay 24
to Colin Blundell, Kenichi Ishibashi, Reilly Grant, danakj, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com
Attention needed from Colin Blundell, Kenichi Ishibashi, Reilly Grant and danakj

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tom Sepez . resolved

Dana, needs re-review as I've dropped the unsafe_buffer_paths.txt file, OO possible?

Owners -- added as a heads-up.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Kenichi Ishibashi
  • Reilly Grant
  • danakj
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d8c114bedec74c487b2af4aa9290d0668cb217d
Gerrit-Change-Number: 5563744
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Matthew Riley <mat...@chromium.org>
Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: danakj <dan...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Comment-Date: Fri, 24 May 2024 16:47:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

danakj (Gerrit)

unread,
May 24, 2024, 12:53:17 PMMay 24
to Tom Sepez, Colin Blundell, Kenichi Ishibashi, Reilly Grant, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com
Attention needed from Colin Blundell, Kenichi Ishibashi, Reilly Grant and Tom Sepez

danakj voted and added 1 comment

Votes added by danakj

Code-Review+1

1 comment

Patchset-level comments
danakj . resolved

LGTM (a services owner can approve as well?)

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Kenichi Ishibashi
  • Reilly Grant
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d8c114bedec74c487b2af4aa9290d0668cb217d
Gerrit-Change-Number: 5563744
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Matthew Riley <mat...@chromium.org>
Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Comment-Date: Fri, 24 May 2024 16:53:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Reilly Grant (Gerrit)

unread,
May 24, 2024, 2:05:21 PMMay 24
to Tom Sepez, Reilly Grant, danakj, Colin Blundell, Kenichi Ishibashi, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com
Attention needed from Colin Blundell, Kenichi Ishibashi and Tom Sepez

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review+1

1 comment

Patchset-level comments
Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Kenichi Ishibashi
  • Tom Sepez
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Comment-Date: Fri, 24 May 2024 18:05:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kenichi Ishibashi (Gerrit)

unread,
May 26, 2024, 7:35:36 PMMay 26
to Tom Sepez, Reilly Grant, danakj, Colin Blundell, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com
Attention needed from Colin Blundell and Tom Sepez

Kenichi Ishibashi voted and added 2 comments

Votes added by Kenichi Ishibashi

Code-Review+1

2 comments

Patchset-level comments
Kenichi Ishibashi . resolved

services/network lgtm

Commit Message
Line 14, Patchset 4 (Latest):Change-Id: I2d8c114bedec74c487b2af4aa9290d0668cb217d
Kenichi Ishibashi . unresolved

Can you add `Bug: 40284755` here?

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Tom Sepez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2d8c114bedec74c487b2af4aa9290d0668cb217d
    Gerrit-Change-Number: 5563744
    Gerrit-PatchSet: 4
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: danakj <dan...@chromium.org>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Matthew Riley <mat...@chromium.org>
    Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Wanming Lin <wanmi...@intel.com>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Comment-Date: Sun, 26 May 2024 23:35:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Colin Blundell (Gerrit)

    unread,
    May 27, 2024, 3:36:31 AMMay 27
    to Tom Sepez, Colin Blundell, Kenichi Ishibashi, Reilly Grant, danakj, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com
    Attention needed from Tom Sepez

    Colin Blundell voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Sepez
    Gerrit-Comment-Date: Mon, 27 May 2024 07:36:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    danakj (Gerrit)

    unread,
    May 27, 2024, 9:42:37 AMMay 27
    to Tom Sepez, Hans Wennborg, Colin Blundell, Kenichi Ishibashi, Reilly Grant, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com
    Attention needed from Colin Blundell and Tom Sepez

    danakj added 1 comment

    Patchset-level comments
    danakj . resolved

    We should maybe wait for the clang roll to finish, because we keep adding places that call span(ptr,size) ctors and then block the roll.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2d8c114bedec74c487b2af4aa9290d0668cb217d
    Gerrit-Change-Number: 5563744
    Gerrit-PatchSet: 4
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: danakj <dan...@chromium.org>
    Gerrit-CC: Hans Wennborg <ha...@chromium.org>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Matthew Riley <mat...@chromium.org>
    Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Wanming Lin <wanmi...@intel.com>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Comment-Date: Mon, 27 May 2024 13:42:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    danakj (Gerrit)

    unread,
    May 27, 2024, 9:43:03 AMMay 27
    to Tom Sepez, Hans Wennborg, Colin Blundell, Kenichi Ishibashi, Reilly Grant, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com
    Attention needed from Colin Blundell and Tom Sepez

    danakj added 1 comment

    Patchset-level comments
    danakj . resolved

    We should maybe wait for the clang roll to finish, because we keep adding places that call span(ptr,size) ctors and then block the roll.

    danakj

    (the clang roll has a fix for the bug that was not catching calls to that ctor)

    Gerrit-Comment-Date: Mon, 27 May 2024 13:42:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: danakj <dan...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Sepez (Gerrit)

    unread,
    Jul 2, 2024, 6:51:13 PMJul 2
    to Hans Wennborg, Colin Blundell, Kenichi Ishibashi, Reilly Grant, danakj, Matthew Riley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, Raphael Kubo Da Costa, Rijubrata Bhaumik, Wanming Lin, gavin...@chromium.org, mbarowsky+watc...@chromium.org, rhalava...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, zhangwen...@google.com

    Tom Sepez abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages