[bytesize] Migrate some Performance Manager code from the old ByteCount to ByteSize. [chromium/src : main]

0 views
Skip to first unread message

Francois Pierre Doray (Gerrit)

unread,
Jan 6, 2026, 4:17:00 PM (11 days ago) Jan 6
to Avi Drissman, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org
Attention needed from Avi Drissman

Francois Pierre Doray voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43644531c0f749c40231dc27e2f0482600d9d275
Gerrit-Change-Number: 7326667
Gerrit-PatchSet: 6
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 21:16:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 6, 2026, 4:21:51 PM (11 days ago) Jan 6
to Avi Drissman, Francois Pierre Doray, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org

Avi Drissman voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43644531c0f749c40231dc27e2f0482600d9d275
Gerrit-Change-Number: 7326667
Gerrit-PatchSet: 6
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Comment-Date: Tue, 06 Jan 2026 21:21:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 6, 2026, 5:22:12 PM (11 days ago) Jan 6
to Avi Drissman, Francois Pierre Doray, Code Review Nudger, chromium...@chromium.org, chrome-gr...@chromium.org, performance-m...@chromium.org, rhalava...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[bytesize] Migrate some Performance Manager code from the old ByteCount to ByteSize.

Replaces [u]int64_t and ByteCount with stronger types to increase
clarity and type safety:
- ByteSize: A non-negative amount of bytes.
- ByteSizeDelta: A delta of bytes, which can be positive or negative.
Bug: 448661443
Change-Id: I43644531c0f749c40231dc27e2f0482600d9d275
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Commit-Queue: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1565276}
Files:
  • M chrome/browser/memory/enterprise_memory_limit_evaluator.cc
  • M chrome/browser/performance_manager/chrome_browser_main_extra_parts_performance_manager.cc
  • M chrome/browser/performance_manager/mechanisms/page_discarder.cc
  • M chrome/browser/performance_manager/mechanisms/page_discarder.h
  • M chrome/browser/performance_manager/mechanisms/page_discarder_browsertest.cc
  • M chrome/browser/performance_manager/policies/page_discarding_helper.cc
  • M chrome/browser/performance_manager/policies/page_discarding_helper_unittest.cc
  • M chrome/browser/performance_manager/policies/termination_target_policy.cc
  • M chrome/browser/performance_manager/policies/termination_target_policy_unittest.cc
  • M chrome/browser/performance_manager/public/user_tuning/user_performance_tuning_manager.h
  • M chrome/browser/performance_manager/public/user_tuning/user_tuning_utils.h
  • M chrome/browser/performance_manager/test_support/page_discarding_utils.cc
  • M chrome/browser/performance_manager/test_support/page_discarding_utils.h
  • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_manager.cc
  • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_notifier.cc
  • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_notifier.h
  • M chrome/browser/performance_manager/user_tuning/user_performance_tuning_notifier_unittest.cc
  • M chrome/browser/performance_manager/user_tuning/user_tuning_utils.cc
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
  • M chrome/browser/screen_ai/resource_monitor.cc
  • M chrome/browser/ui/performance_controls/memory_saver_utils.cc
  • M chrome/browser/ui/performance_controls/tab_resource_usage_collector.cc
  • M chrome/browser/ui/views/performance_controls/memory_saver_interactive_ui_test.cc
  • M chrome/browser/ui/views/performance_controls/test_support/memory_saver_unit_test_mixin.h
  • M components/performance_manager/decorators/process_metrics_decorator_unittest.cc
  • M components/performance_manager/freezing/freezing_policy.cc
  • M components/performance_manager/freezing/freezing_policy.h
  • M components/performance_manager/freezing/freezing_policy_unittest.cc
  • M components/performance_manager/graph/frame_node_impl.cc
  • M components/performance_manager/graph/frame_node_impl.h
  • M components/performance_manager/graph/page_node_impl.cc
  • M components/performance_manager/graph/page_node_impl.h
  • M components/performance_manager/graph/process_node_impl.cc
  • M components/performance_manager/graph/process_node_impl.h
  • M components/performance_manager/graph/process_node_impl_unittest.cc
  • M components/performance_manager/graph/worker_node_impl.cc
  • M components/performance_manager/graph/worker_node_impl.h
  • M components/performance_manager/metrics/page_resource_monitor_unittest.cc
  • M components/performance_manager/public/graph/frame_node.h
  • M components/performance_manager/public/graph/page_node.h
  • M components/performance_manager/public/graph/process_node.h
  • M components/performance_manager/public/graph/worker_node.h
  • M components/performance_manager/public/resource_attribution/memory_measurement_delegate.h
  • M components/performance_manager/public/resource_attribution/query_results.h
  • M components/performance_manager/resource_attribution/memory_measurement_delegate.cc
  • M components/performance_manager/resource_attribution/memory_measurement_provider_browsertest.cc
  • M components/performance_manager/resource_attribution/queries_unittest.cc
  • M components/performance_manager/resource_attribution/query_scheduler_unittest.cc
Change size: L
Delta: 49 files changed, 304 insertions(+), 284 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43644531c0f749c40231dc27e2f0482600d9d275
Gerrit-Change-Number: 7326667
Gerrit-PatchSet: 7
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages