[discard] Set single_outermost_main_frame for WebContentsDiscard [chromium/src : main]
0 views
Skip to first unread message
Tom Lukaszewicz (Gerrit)
Nov 25, 2025, 5:28:33 PMNov 25
to Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Keren Zhu
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Keren Zhu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Dec 2, 2025, 12:12:50 AMDec 2
to Chromium LUCI CQ, Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Tom Lukaszewicz . resolved
I believe the failure was unrelated - should be good now
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Dec 2, 2025, 2:50:49 PMDec 2
to Chromium LUCI CQ, Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Keren Zhu
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tom Lukaszewicz . resolved
Flake seems to be specific to test infra setup on android bots. Filed a bug and disabled the test on android in the upstream CL. PTAL when you get a chance.
Related details
Attention is currently required from:
- Keren Zhu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keren Zhu (Gerrit)
Dec 2, 2025, 3:38:34 PMDec 2
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Tom Lukaszewicz
Keren Zhu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Keren Zhu
| Code-Review | +1 |
1 comment
Patchset-level comments
Keren Zhu . resolved
looks reasonable but admittedly I don't understand the code.
Related details
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Dec 7, 2025, 7:56:33 PMDec 7
to Keren Zhu, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Tom Lukaszewicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 7, 2025, 8:57:32 PMDec 7
to Tom Lukaszewicz, Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[discard] Set single_outermost_main_frame for WebContentsDiscard
This CL updates AttemptFastKillForDiscard() to set the
single_outermost_main_frame param for FastShutdownIfPossible() when
running the WebContentsDiscard experiment.
This param allows fast-kills in the case where all frames resident
in a process belong to a single WebContents, vs page_count which
checks for RenderWidgetHost counts (all of which may belong to
a single tab but add to a count greater than 0).
This CL affects behavior only when running WebContentsDiscard
(behavior is unchanged otherwise).
Bug: 463735439
Change-Id: Ide557a6821f7a8c66dd6871b7281d04bd0693cbf
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Reviewed-by: Keren Zhu <kere...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1555253}
Files:
- M chrome/browser/resource_coordinator/utils.cc
Change size: S
Delta: 1 file changed, 12 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Keren Zhu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Sakamoto (Gerrit)
Dec 7, 2025, 10:37:03 PMDec 7
to Chromium LUCI CQ, Tom Lukaszewicz, Keren Zhu, chromium...@chromium.org, chrome-gr...@chromium.org
Takashi Sakamoto has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages