Turn iterator .end() DCHECK() into CHECK() for chrome [chromium/src : main]

0 views

Skip to first unread message

Alex Gough (Gerrit)

unread,

Jul 8, 2024, 5:59:02 PM (9 days ago) Jul 8

to Matthew Jones, David Trainor, Peter Beverloo, chromium...@chromium.org, Nancy Wang, Andrew Rayskiy, devtools...@chromium.org, Rijubrata Bhaumik, Tommy Li, Simon Hangl, Lei Zhang, prerendering-reviews, dominickn+...@chromium.org, chlily...@chromium.org, vakh+safe_br...@chromium.org, tommasin+watch-...@chromium.org, zackha...@chromium.org, philli...@chromium.org, cros-ed...@google.com, dominickn+watc...@chromium.org, nburris+pa...@chromium.org, feature-me...@chromium.org, gogerald+pa...@chromium.org, asvitki...@chromium.org, zelin+watch-we...@chromium.org, print-rev...@chromium.org, rouslan+...@chromium.org, cros-print...@google.com, erickun...@chromium.org, mfoltz...@chromium.org, chromium-a...@chromium.org, dmurph+watchin...@chromium.org, kinuko+...@chromium.org, knollr+wat...@chromium.org, druber...@chromium.org, dpr-eng+c...@google.com, dullweb...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, steimel+...@chromium.org, tsergea...@chromium.org, kuragin+web-ap...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, alancutter...@chromium.org, dibyapal+wa...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, blundell+...@chromium.org, chrome-gr...@chromium.org, dullweber+watch...@chromium.org, gavin...@chromium.org, hidehik...@chromium.org, dominickn+wat...@chromium.org, mattreyno...@chromium.org, lingqi...@chromium.org, oshima...@chromium.org, feature-v...@chromium.org, dtseng...@chromium.org, tburkar...@chromium.org, performance-m...@chromium.org, alimariam+watch...@google.com, grt+...@chromium.org, pmonett...@chromium.org, xinghui...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, dmurph+wat...@chromium.org, chfreme...@chromium.org, mgiuca...@chromium.org, yhanada+...@chromium.org, chromiumme...@microsoft.com, mvanouwerkerk...@chromium.org, msrame...@chromium.org, dtraino...@chromium.org, ericwillige...@chromium.org, rginda...@chromium.org, mac-r...@chromium.org, jophba...@chromium.org, mxcai+watch...@chromium.org, extension...@chromium.org, Alex Gough

Attention needed from David Trainor and Matthew Jones

Alex Gough has uploaded the change for review

Alex Gough would like Matthew Jones and David Trainor to review this change.

Commit message

Turn iterator .end() DCHECK() into CHECK() for chrome

Accessing an invalid iterator can sometimes be a security
issue and these checks are cheap, so upgrade to CHECKs.

For this CL instances were located with a weggli query
of `DCHECK(_ != _.end());` and some filtering of paths.

This CL was uploaded by git cl split.

R=dtra...@chromium.org, mdj...@chromium.org

Bug: 351745839

Change-Id: Id4b1cef91fabdefee188d76a3dcb8b8c5fd79278

Change diff

Change information

Files:

M chrome/browser/android/compositor/tab_content_manager.cc
M chrome/browser/android/historical_tab_saver.cc
M chrome/browser/android/httpclient/http_client.cc
M chrome/browser/apps/app_service/app_icon/app_icon_reader.cc
M chrome/browser/apps/app_service/app_notifications.cc
M chrome/browser/apps/app_service/app_service_proxy_ash.cc
M chrome/browser/apps/app_shim/app_shim_manager_mac.cc
M chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc
M chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc
M chrome/browser/component_updater/third_party_module_list_component_installer_win.cc
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc
M chrome/browser/devtools/device/devtools_android_bridge.cc
M chrome/browser/devtools/devtools_ui_bindings.cc
M chrome/browser/download/bubble/download_bubble_update_service.cc
M chrome/browser/download/chrome_download_manager_delegate.cc
M chrome/browser/download/notification/multi_profile_download_notifier.cc
M chrome/browser/enterprise/connectors/analysis/files_request_handler.cc
M chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
M chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.cc
M chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc
M chrome/browser/extensions/api/messaging/incognito_connectability.cc
M chrome/browser/extensions/api/passwords_private/passwords_private_utils.cc
M chrome/browser/extensions/api/web_authentication_proxy/web_authentication_proxy_api.cc
M chrome/browser/extensions/chrome_app_icon_service.cc
M chrome/browser/extensions/device_permissions_dialog_controller.cc
M chrome/browser/extensions/extension_assets_manager_chromeos.cc
M chrome/browser/extensions/global_shortcut_listener.cc
M chrome/browser/extensions/global_shortcut_listener_win.cc
M chrome/browser/extensions/updater/extension_updater.cc
M chrome/browser/image_fetcher/image_decoder_impl.cc
M chrome/browser/intranet_redirect_detector.cc
M chrome/browser/lacros/lacros_extension_apps_controller.cc
M chrome/browser/lacros/lacros_extension_apps_publisher.cc
M chrome/browser/media/cast_remoting_connector.cc
M chrome/browser/media/router/providers/cast/cast_app_availability_tracker.cc
M chrome/browser/media/router/providers/dial/dial_activity_manager.cc
M chrome/browser/media/router/providers/openscreen/discovery/open_screen_listener.cc
M chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
M chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
M chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc
M chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc
M chrome/browser/media_galleries/media_file_system_registry.cc
M chrome/browser/media_galleries/media_galleries_permission_controller.cc
M chrome/browser/metrics/power/process_monitor.cc
M chrome/browser/metrics/usage_scenario/tab_usage_scenario_tracker.cc
M chrome/browser/notifications/notification_channels_provider_android_unittest.cc
M chrome/browser/notifications/scheduler/internal/display_decider.cc
M chrome/browser/notifications/scheduler/internal/impression_history_tracker_unittest.cc
M chrome/browser/performance_manager/user_tuning/profile_discard_opt_out_list_helper.cc
M chrome/browser/performance_monitor/system_monitor.cc
M chrome/browser/predictors/autocomplete_action_predictor.cc
M chrome/browser/predictors/preconnect_manager.cc
M chrome/browser/predictors/prefetch_manager.cc
M chrome/browser/preloading/prefetch/search_prefetch/search_prefetch_service.cc
M chrome/browser/printing/print_backend_service_manager.cc
M chrome/browser/privacy_sandbox/privacy_sandbox_settings_browsertest.cc
M chrome/browser/profiles/profile_destroyer.cc
M chrome/browser/profiles/profile_manager.cc
M chrome/browser/push_messaging/push_messaging_refresher.cc
M chrome/browser/resource_coordinator/session_restore_policy.cc
M chrome/browser/resource_coordinator/tab_load_tracker.cc
M chrome/browser/safe_browsing/download_protection/download_protection_service.cc
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
M chrome/browser/sessions/tab_loader.cc
M chrome/browser/sharing/sharing_message_sender.cc
M chrome/browser/signin/chrome_signin_proxying_url_loader_factory.cc
M chrome/browser/speech/tts_ash.cc
M chrome/browser/sync/test/integration/bookmarks_helper.cc
M chrome/browser/task_manager/mock_web_contents_task_manager.cc
M chrome/browser/task_manager/providers/web_contents/web_contents_task_provider.cc
M chrome/browser/task_manager/providers/worker_task_provider.cc
M chrome/browser/task_manager/sampling/shared_sampler_win.cc
M chrome/browser/task_manager/sampling/task_manager_impl.cc
M chrome/browser/trusted_vault/trusted_vault_client_android.cc
M chrome/browser/ui/android/device_dialog/usb_chooser_dialog_android.cc
M chrome/browser/ui/android/hats/hats_service_android.cc
M chrome/browser/ui/hats/hats_service_desktop.cc
M chrome/browser/ui/hid/hid_chooser_controller.cc
M chrome/browser/ui/hung_plugin_tab_helper.cc
M chrome/browser/ui/thumbnails/thumbnail_image.cc
M chrome/browser/ui/thumbnails/thumbnail_scheduler_impl.cc
M chrome/browser/ui/toolbar/toolbar_actions_model.cc
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
M chrome/browser/ui/views/download/bubble/download_bubble_row_view.cc
M chrome/browser/ui/views/download/download_shelf_view.cc
M chrome/browser/ui/views/extensions/extensions_menu_view.cc
M chrome/browser/ui/views/extensions/extensions_toolbar_container.cc
M chrome/browser/ui/views/global_media_controls/media_item_ui_device_selector_view.cc
M chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc
M chrome/browser/ui/views/payments/editor_view_controller.cc
M chrome/browser/ui/views/profiles/profile_picker_view.cc
M chrome/browser/ui/views/toolbar/app_menu.cc
M chrome/browser/ui/views/toolbar/pinned_toolbar_actions_container.cc
M chrome/browser/ui/webui/discards/graph_dump_impl.cc
M chrome/browser/ui/webui/new_tab_page/new_tab_page_handler.cc
M chrome/browser/ui/webui/signin/profile_picker_handler.cc
M chrome/browser/usb/usb_chooser_controller.cc
M chrome/browser/vr/test/mock_xr_device_hook_base.cc
M chrome/browser/vr/webxr_vr_input_browser_test.cc
M chrome/browser/web_applications/externally_managed_app_manager.cc
M chrome/browser/web_applications/externally_managed_app_manager_impl_unittest.cc
M chrome/browser/web_applications/web_app_sync_bridge.cc
M chrome/browser/win/conflicts/incompatible_applications_updater.cc
M chrome/browser/win/conflicts/module_blocklist_cache_updater.cc
M chrome/browser/win/conflicts/module_database.cc
M chrome/services/printing/print_backend_service_impl.cc
M chrome/test/base/testing_profile_manager.cc

Change size: L

Delta: 108 files changed, 341 insertions(+), 210 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

David Trainor
Matthew Jones

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Gough (Gerrit)

unread,

Jul 8, 2024, 6:32:49 PM (9 days ago) Jul 8

to Alex Gough, David Trainor, Matthew Jones, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Nancy Wang, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, Tommy Li, alancutter...@chromium.org, alimariam+watch...@google.com, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blundell+...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dominickn+wat...@chromium.org, dominickn+watc...@chromium.org, dominickn+...@chromium.org, dominickn+watch-...@chromium.org, dpr-eng+c...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweber+watch...@chromium.org, dullweb...@chromium.org, erickun...@chromium.org, ericwillige...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, jophba...@chromium.org, kinuko+...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, mvanouwerkerk...@chromium.org, mxcai+watch...@chromium.org, nburris+pa...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pmonett...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, steimel+...@chromium.org, tburkar...@chromium.org, tommasin+watch-...@chromium.org, tsergea...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yhanada+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Alex Gough abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages