Remove DanglingUntriaged from TabLifecycleUnit. [chromium/src : main]

0 views
Skip to first unread message

Vovo Yang (Gerrit)

unread,
Aug 5, 2025, 1:48:26 AMAug 5
to Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org
Attention needed from Joe Mason

Vovo Yang voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf63810cb66e5456be005aa35a87aff23663484b
Gerrit-Change-Number: 6817909
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Tue, 05 Aug 2025 05:47:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 5, 2025, 1:51:01 AMAug 5
to Vovo Yang, chromium...@chromium.org, chrome-gr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove DanglingUntriaged from TabLifecycleUnit.

This should move the crash in https://crbug.com/433534062 to the point
where the raw_ptr becomes dangling, not the point where it's accessed,
which will be easier to debug.
Bug: 433534062
Change-Id: Iaf63810cb66e5456be005aa35a87aff23663484b
Auto-Submit: Joe Mason <joenot...@google.com>
Reviewed-by: Vovo Yang <vo...@chromium.org>
Commit-Queue: Vovo Yang <vo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1496733}
Files:
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vovo Yang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf63810cb66e5456be005aa35a87aff23663484b
Gerrit-Change-Number: 6817909
Gerrit-PatchSet: 3
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Vovo Yang <vo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages