Remove base/logging.h include from validation_errors.h [chromium/src : main]

[Daniel Cheng (Gerrit)]

Attention needed from Lei Zhang

Daniel Cheng added 3 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Daniel Cheng . resolved

There are definitely some tradeoffs being made here, but I think it has enough impact to be worth it.

I would like to try to land something we're moderately OK with and then try to iterate further from there, since the base/logging.h IWYU issues are likely to regress.

File mojo/public/cpp/bindings/lib/validation_errors.h

Line 153, Patchset 14 (Latest): const ArrayExpectedSizeError& details);

Daniel Cheng . resolved

But at the very least, I'll think about ways to consolidate this a bit.

Line 102, Patchset 14 (Latest):COMPONENT_EXPORT(MOJO_CPP_BINDINGS_BASE)

Daniel Cheng . resolved

I will admit that adding 6 new overloads isn't the best, but it seems unlikely we'll add more.

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: If52b10f4928b7920ea7b120754a1798c125fefa7

Gerrit-Change-Number: 7730404

Gerrit-PatchSet: 14

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Ian Vollick <vol...@chromium.org>

Gerrit-CC: James Su <su...@chromium.org>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Lin, Wanming <wanmi...@intel.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Victor Tan <vict...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Tue, 07 Apr 2026 06:55:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Lei Zhang (Gerrit)]

Attention needed from Daniel Cheng

Lei Zhang voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Tue, 07 Apr 2026 07:07:26 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: If52b10f4928b7920ea7b120754a1798c125fefa7

Gerrit-Change-Number: 7730404

Gerrit-PatchSet: 16

Gerrit-Comment-Date: Tue, 07 Apr 2026 07:45:22 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Gerrit-Comment-Date: Tue, 07 Apr 2026 08:24:40 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Unreviewed changes

14 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Remove base/logging.h include from validation_errors.h

This header is included in many C++ source files generated from .mojom
and is fairly heavyweight. While moving the logging out of the headers
is straightforward, array validation failures generate a std::string
with some runtime details. `std::string_view` handles both cases nicely,
but there is value in minimizing the includes in this file as much as
possible. `const char*` and using `.c_str()` was the initial approach
considered, but discarded as a bit too hacky after some prototyping.

Instead, the helpers that create additional context for array validation
failures now return a struct with details about the failure. The various
validation error reporting functions have additional overloads that
internally stringify the details so that validation errors are still
reported in the exact same way.

gemini-cli was used to quickly prototype some ideas as well as implement
the overall CL, with some manual followups to improve naming and reduce
duplication.

One unintended side effect is a minor improvement in binary size, since
the new error detail structs are trivially destructible, unlike
std::string.

Bug: 499476145

Change-Id: If52b10f4928b7920ea7b120754a1798c125fefa7

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7730404

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Lei Zhang <the...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1610607}

Files:

• M mojo/public/cpp/bindings/lib/array_internal.cc
• M mojo/public/cpp/bindings/lib/array_internal.h
• M mojo/public/cpp/bindings/lib/validation_errors.cc
• M mojo/public/cpp/bindings/lib/validation_errors.h

Change size: M

Delta: 4 files changed, 155 insertions(+), 68 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Lei Zhang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: If52b10f4928b7920ea7b120754a1798c125fefa7

Gerrit-Change-Number: 7730404

Gerrit-PatchSet: 17

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

[Eriko Kurimoto (Gerrit)]

Eriko Kurimoto has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: revert