Revert of Blacklist rooksbas.dll in sandboxed processes (issue 2003373003 by erikchen@chromium.org)

4 views
Skip to first unread message

erik...@chromium.org

unread,
May 24, 2016, 1:49:50 PM5/24/16
to sco...@chromium.org, jsc...@chromium.org, w...@chromium.org, csh...@chromium.org, tav...@google.com, a...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, rickyz...@chromium.org, a...@chromium.org, chrome-blackli...@chromium.org
Reviewers: scottmg (ooo until 24may), jschuh (very slow), Will Harris (slow thru 23 May), csharp, taviso1, Avi
CL: https://codereview.chromium.org/2003373003/

Message:
Created Revert of Blacklist rooksbas.dll in sandboxed processes

Description:
Revert of Blacklist rooksbas.dll in sandboxed processes (patchset #1 id:1 of
https://codereview.chromium.org/2004573003/ )

Reason for revert:
This causes full browser hangs when the Trusteer Rapport product is enabled. We
probably need to also blacklist dlls from the browser process.

Original issue's description:
> Blacklist rooksbas.dll in sandboxed processes
>
> This is a source of many renderer hangs. See bug for more details.
>
> BUG=609262
>
> Committed: https://crrev.com/9a3648a17691625a13ee8acdb798813280193fb3
> Cr-Commit-Position: refs/heads/master@{#395377}

TBR=sco...@chromium.org,jsc...@chromium.org,w...@chromium.org,csh...@chromium.org,tav...@google.com,a...@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609262

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+0, -2 lines):
M content/common/sandbox_win.cc


Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index fe5c1235c9744f09bd910d541c458569dc78a171..35c33d597cc2a730df0c55f89cfa67fb6ea27f5f 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -111,8 +111,6 @@
L"radprlib.dll", // Radiant Naomi Internet Filter.
L"rapportnikko.dll", // Trustware Rapport.
L"rlhook.dll", // Trustware Bufferzone.
- L"rooksbas.dll", // IBM Trusteer Rapport.
- L"rooksbas_x64.dll" // IBM Trusteer Rapport.
L"rooksdol.dll", // Trustware Rapport.
L"rndlpepperbrowserrecordhelper.dll", // RealPlayer.
L"rpchromebrowserrecordhelper.dll", // RealPlayer.


csh...@chromium.org

unread,
May 24, 2016, 2:11:08 PM5/24/16
to erik...@chromium.org, sco...@chromium.org, jsc...@chromium.org, w...@chromium.org, tav...@google.com, a...@chromium.org, chromium...@chromium.org, dari...@chromium.org, j...@chromium.org, rickyz...@chromium.org, a...@chromium.org, chrome-blackli...@chromium.org
Reply all
Reply to author
Forward
0 new messages